[Bug 14523] New: msiexec hangs when installing msxml3.msi in 1.1.1

http://bugs.winehq.org/show_bug.cgi?id=14523

Summary: msiexec hangs when installing msxml3.msi in 1.1.1
           Product: Wine
           Version: 1.1.1
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: richedit
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Tested in openSUSE 10.3, Wine 1.1.1, with a clean wineprefix.

I tried this both using winetricks and running msiexec from the command line.
The Microsoft XML Parser Wizard starts up, but after clicking "Next" the first
dialog box disappears and the EULA dialog, which should be next, never appears.
There are no more messages in the terminal from that point, though Wine is
still running and has to be killed.

The console output is: 
dimesio@linux-95tw:~> wine msiexec /i /home/dimesio/.winetrickscache/msxml3.msi
fixme:advapi:LookupAccountNameW (null) L"dimesio" (nil) 0x32f8ac (nil) 0x32f8b0
0x32f8a4 - stub
fixme:advapi:LookupAccountNameW (null) L"dimesio" 0x15a8d0 0x32f8ac 0x15ab28
0x32f8b0 0x32f8a4 - stub
fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates -> 2 ignored
L"Upgrade" table values
err:richedit:ReadStyleSheet ReadStyleSheet: skipping optional destination
err:richedit:ReadStyleSheet ReadStyleSheet: skipping optional destination

A regression test identified this patch:

49468e1824cac4df5d09614884100f79b33b50cb is first bad commit
commit 49468e1824cac4df5d09614884100f79b33b50cb
Author: Dylan Smith 
Date:   Thu Jul 10 10:17:30 2008 -0400

richedit: Tabs cause lines to wrap but not end of paragraph run.

:040000 040000 fcddb2e76b2747c9c367012961738d6e13fda33b
f34a818551c3c1bfbaecbb39cd9d7bf1dc608064 M       dlls

[Bug 14523] msiexec hangs when installing msxml3.msi in 1.1.1

http://bugs.winehq.org/show_bug.cgi?id=14523

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1

--- Comment #1 from Dylan Smith   2008-07-17 00:27:31 ---
I can confirm that my change somehow caused this bug, so I will look into the
cause of this.

[Bug 14523] msiexec hangs when installing msxml3.msi in 1.1.1

http://bugs.winehq.org/show_bug.cgi?id=14523

--- Comment #2 from Dylan Smith   2008-07-17 10:57:56 ---
Created an attachment (id=14868)
 --> (http://bugs.winehq.org/attachment.cgi?id=14868)
richedit: Fixed regression that caused endless loop

Large tab sizes were causing a single tab to wrap, but the start rows were
being inserted before the tab, even if it was at the start of the row.  In this
case the tab should be inserted after the tab, otherwise an endless loop
occurs, so this patch takes this approach to fix the bug.

The large tab sizes that cause this problem weren't a result of this
regression, but can be seen by looking at the end user licence to see the tab
sizes. This is most likely a missing conversion from twips to pixels when
streaming rich text.

[Bug 14523] msiexec hangs when installing msxml3.msi in 1.1.1

http://bugs.winehq.org/show_bug.cgi?id=14523

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 14523] msiexec hangs when installing msxml3.msi in 1.1.1

http://bugs.winehq.org/show_bug.cgi?id=14523

--- Comment #3 from Dylan Smith   2008-07-18 07:11:30 ---
My fix is in the git tree:
e86a1d623af8daf6c4807198cd53530403454fcc
richedit: Fixed regression that caused endless loop.

Could you test it to make sure it works for you.

[Bug 14523] msiexec hangs when installing msxml3.msi in 1.1.1

http://bugs.winehq.org/show_bug.cgi?id=14523

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from [e-mail]  2008-07-18 08:35:31 ---
Works for me.

[Bug 14523] msiexec hangs when installing msxml3.msi in 1.1.1

http://bugs.winehq.org/show_bug.cgi?id=14523

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from [e-mail]  2008-07-18 16:38:59 ---
(In reply to comment #3)
> My fix is in the git tree:
> e86a1d623af8daf6c4807198cd53530403454fcc
> richedit: Fixed regression that caused endless loop.
>
> Could you test it to make sure it works for you.

Works OK, thanks...

[Bug 14523] msiexec hangs when installing msxml3.msi in 1.1.1

http://bugs.winehq.org/show_bug.cgi?id=14523

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2008-07-25 13:24:35 ---
Closing bugs fixed in 1.1.2.