[Bug 19430] New: winedump: null pointer dereference in spec mode

http://bugs.winehq.org/show_bug.cgi?id=19430

Summary: winedump: null pointer dereference in spec mode
           Product: Wine
           Version: 1.1.26
          Platform: All
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P5
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=22556)
 --> (http://bugs.winehq.org/attachment.cgi?id=22556)
diff against git that solved the problem

I think a null pointer dereference may occur when running winedump in spec
mode. I encountered a segmentation fault when invoking ./winedump spec -c
/tmp/poly/poly.dll -I /tmp/poly/. The reason seems to be line 1598 in
tools/winedump/pe.c where dll_current_symbol may be NULL. This affects version
1.1.26 as well as a fresh git checkout. The attached URL contains a quick hack
that worked for me but certainly requires review from somebody more familiar
with the code.

[Bug 19430] winedump: null pointer dereference in spec mode

http://bugs.winehq.org/show_bug.cgi?id=19430

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22556|0                           |1
        is obsolete|                            |

[Bug 19430] winedump: null pointer dereference in spec mode

http://bugs.winehq.org/show_bug.cgi?id=19430

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other

--- Comment #1 from Dmitry Timoshkov   2009-07-23 10:27:53 ---
Please next time attach a diff, not an url to an external site. Patches
shpuld be sent to wine-patches, or if you are unsure to wine-devel for
discussion.

[Bug 19430] winedump: null pointer dereference in spec mode

http://bugs.winehq.org/show_bug.cgi?id=19430

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #2 from Austin English   2009-07-23 11:17:03 ---
diff --git a/tools/winedump/pe.c b/tools/winedump/pe.c
index 5ff8a16..85540d9 100644
--- a/tools/winedump/pe.c
+++ b/tools/winedump/pe.c
 -1595,7 +1595,7 @@ int dll_open (const char *dll_name)
  */
 int dll_next_symbol (parsed_symbol * sym)
 {
-    if (!dll_current_symbol->symbol)
+    if (!dll_current_symbol || !dll_current_symbol->symbol)
        return 1;

assert (dll_symbols);

[Bug 19430] winedump: null pointer dereference in spec mode

http://bugs.winehq.org/show_bug.cgi?id=19430

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |programs

[Bug 19430] winedump: null pointer dereference in spec mode

http://bugs.winehq.org/show_bug.cgi?id=19430

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|programs                    |urlmon

[Bug 19430] winedump: null pointer dereference in spec mode

http://bugs.winehq.org/show_bug.cgi?id=19430

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|urlmon                      |tools

--- Comment #3 from Hans Leidekker   2009-07-24 01:40:12 ---
oops

[Bug 19430] winedump: null pointer dereference in spec mode

http://bugs.winehq.org/show_bug.cgi?id=19430

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from André H.   2010-01-04 15:13:27 ---
patch is fine, please e-mail it to [e-mail]

[Bug 19430] winedump: null pointer dereference in spec mode

http://bugs.winehq.org/show_bug.cgi?id=19430

--- Comment #5 from André H.   2010-01-05 12:05:15 ---
http://source.winehq.org/patches/ says "Apply failure"
was the patch against a recent git?

[Bug 19430] winedump: null pointer dereference in spec mode

http://bugs.winehq.org/show_bug.cgi?id=19430

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from André H.   2010-01-07 07:31:52 ---
fixed in yesterdays git.
congrats!

[Bug 19430] winedump: null pointer dereference in spec mode

http://bugs.winehq.org/show_bug.cgi?id=19430

--- Comment #7 from Nikolay Sivov   2010-01-07 07:50:23 ---
(In reply to comment #6)
> fixed in yesterdays git.
> congrats!

Fixed by commit 29e58e30f14cbb6aadb1b99851718f36b014916d.

Please specify a commit that fixed a bug next time, it extends search
capabilities.

[Bug 19430] winedump: null pointer dereference in spec mode

http://bugs.winehq.org/show_bug.cgi?id=19430

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Jeff Zaroyko   2010-01-09 04:49:45 ---
Closing bugs fixed in 1.1.36.

[Bug 19430] winedump: null pointer dereference in spec mode

https://bugs.winehq.org/show_bug.cgi?id=19430

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |29e58e30f14cbb6aadb1b998517
                   |                            |18f36b014916d