[Bug 46599] New: GNUTLS_PK_ECDSA not found in recent gnutls.h

https://bugs.winehq.org/show_bug.cgi?id=46599

Bug ID: 46599
           Summary: GNUTLS_PK_ECDSA not found in recent gnutls.h
           Product: Wine
           Version: 4.1
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Compilation in macOS 10.13.6 with Xcode10.1 and recent gnutls library installed
by MacPort failed with claim that GNUTLS_PK_ECDSA is undefined.

dll/bcrypt/gnutls.c
~~~
#if GNUTLS_VERSION_MAJOR < 3
#define GNUTLS_CIPHER_AES_192_CBC 92
#define GNUTLS_CIPHER_AES_128_GCM 93
#define GNUTLS_CIPHER_AES_256_GCM 94
#define GNUTLS_PK_ECC 4
#define GNUTLS_PK_ECDSA 4
~~~~

But file gnutls.h having version #define GNUTLS_VERSION "3.3.12"
and doesn't contain GNUTLS_PK_ECDSA
so I just replace it by GNUTLS_PK_ECC that has the same value.

I don't know initial idea of (#if GNUTLS_VERSION_MAJOR < 3) so I can't propose
the common patch.

[Bug 46599] GNUTLS_PK_ECDSA not found in recent gnutls.h

https://bugs.winehq.org/show_bug.cgi?id=46599

--- Comment #1 from Hans Leidekker  ---
This applies to wine-staging only, right?

[Bug 46599] GNUTLS_PK_ECDSA not found in recent gnutls.h

https://bugs.winehq.org/show_bug.cgi?id=46599

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |[e-mail]

--- Comment #2 from Alistair Leslie-Hughes  ---
(In reply to Sergey Isakov from comment #0)
> But file gnutls.h having version #define GNUTLS_VERSION "3.3.12"
> and doesn't contain GNUTLS_PK_ECDSA
> so I just replace it by GNUTLS_PK_ECC that has the same value.

I've already updated the this patch a few times for various compile issues,
including this one.

(In reply to Hans Leidekker from comment #1)
> This applies to wine-staging only, right?

Yes only in staging.

[Bug 46599] GNUTLS_PK_ECDSA not found in recent gnutls.h

https://bugs.winehq.org/show_bug.cgi?id=46599

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |-unknown
                 CC|                            |[e-mail]
            Product|Wine                        |Wine-staging

[Bug 46599] GNUTLS_PK_ECDSA not found in recent gnutls.h

https://bugs.winehq.org/show_bug.cgi?id=46599

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alistair Leslie-Hughes  ---
Closing Fixed Staging bugs.