[Bug 45660] New: SuperPower 2 demo fails to install

https://bugs.winehq.org/show_bug.cgi?id=45660

Bug ID: 45660
           Summary: SuperPower 2 demo fails to install
           Product: Wine
           Version: 3.13
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 62087
  --> https://bugs.winehq.org/attachment.cgi?id=62087
+msi output

Steps to reproduce:

1. Install
https://web.archive.org/web/20160305010920/www.installengine.com/isengine/isscript.msi
with `msiexec /i`.

2. Install SuperPower 2 demo from
https://download.cnet.com/SuperPower-2/3000-7483_4-10319338.html.

The installation fails with error -1603. Output with WINEDEBUG=+msi is
attached. The most interesting line is:

0070:err:msi:ITERATE_Actions Execution halted, action L"ISStartup" returned
1603

This used to work as recently as Wine 3.12. A regression test said:

457431ab5bc1dd10c4957f145de85c4ba6d0ef72 is the first bad commit
commit 457431ab5bc1dd10c4957f145de85c4ba6d0ef72
Author: Zebediah Figura 
Date:   Tue Jul 10 12:08:47 2018 +0200

msi: Reuse the custom action server process where possible.

We use a named pipe to communicate between the client (i.e. the process
that
    called MsiInstallProduct() and the custom action server. The naïve approach
    has the client send custom action GUIDs to the server and the server send
    back the results of executing the action, but this fails in the case of
    nested custom actions, so instead we send back handles of threads for the
    client to wait on.

Signed-off-by: Zebediah Figura 
    Signed-off-by: Hans Leidekker 
    Signed-off-by: Alexandre Julliard

$ sha256sum isscript.msi 
1cc2c839b8ba08a5d06bcce9b6fa6c32f3f05e9750fc9d5dc1981aeb4e5b04af

$ sha256sum SP2Demo.exe 
b96fed502d25569dcdd65c6cdc371dbe9367ae8bf805049774f2ee3e028038d4

[Bug 45660] SuperPower 2 demo fails to install

https://bugs.winehq.org/show_bug.cgi?id=45660

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |457431ab5bc1dd10c4957f145de
                   |                            |85c4ba6d0ef72
           See Also|                            |https://bugs.winehq.org/sho
                   |                            |w_bug.cgi?id=30182
             Blocks|                            |30185
           Keywords|                            |download, regression
                URL|                            |https://download.cnet.com/S
                   |                            |uperPower-2/3000-7483_4-103
                   |                            |19338.html
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 45660] SuperPower 2 demo fails to install

https://bugs.winehq.org/show_bug.cgi?id=45660

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62087|0                           |1
        is obsolete|                            |

--- Comment #1 from Alex Henrie  ---
Created attachment 62088
  --> https://bugs.winehq.org/attachment.cgi?id=62088
+msi output

[Bug 45660] SuperPower 2 demo fails to install

https://bugs.winehq.org/show_bug.cgi?id=45660

--- Comment #2 from Zebediah Figura  ---
Can you please test with 3.14? I can't reproduce this, and I suspect it may
have been fixed by 6387476d99f4f762628cb0d72b2d43c23f76f563.

[Bug 45660] SuperPower 2 demo fails to install

https://bugs.winehq.org/show_bug.cgi?id=45660

--- Comment #3 from Austin English  ---
The content of attachment 62087 has been deleted for the following reason:

contains private info

[Bug 45660] SuperPower 2 demo fails to install

https://bugs.winehq.org/show_bug.cgi?id=45660

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |2592690540a87498db09753a32c
                   |                            |416cfe7f26e81
             Status|NEW                         |RESOLVED

--- Comment #4 from Alex Henrie  ---
In reply to Zebediah Figura from comment #2)
> Can you please test with 3.14? I can't reproduce this, and I suspect it may
> have been fixed by 6387476d99f4f762628cb0d72b2d43c23f76f563.

The installer works fine with Wine 3.14. It looks like you fixed it yesterday
with
https://source.winehq.org/git/wine.git/commitdiff/2592690540a87498db09753a32...
- thank you!

[Bug 45660] SuperPower 2 demo fails to install

https://bugs.winehq.org/show_bug.cgi?id=45660

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Zebediah Figura  ---
*** Bug 45653 has been marked as a duplicate of this bug. ***

[Bug 45660] SuperPower 2 demo fails to install

https://bugs.winehq.org/show_bug.cgi?id=45660

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 3.15.