http://bugs.winehq.org/show_bug.cgi?id=25261
Summary: AutoCAD 2009 LT: Running AcDelTree.exe causes Wine error Product: Wine Version: 1.3.7 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: shlwapi AssignedTo: wine-bugs@winehq.org ReportedBy: lukasz.wojnilowicz@gmail.com
Created an attachment (id=32081) --> (http://bugs.winehq.org/attachment.cgi?id=32081) Terminal output on wine-1.3.7-172-g8925024
Steps to reproduce: 1) remove ~/.wine 2) winetricks gecko 3) wine AcDelTree.exe
Behaviour: Wine error window
Expected behaviour: Nothing
http://bugs.winehq.org/show_bug.cgi?id=25261
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|AutoCAD 2009 LT: Running |AutoCAD 2009 LT: Running |AcDelTree.exe causes Wine |AcDelTree.exe crashes |error |
http://bugs.winehq.org/show_bug.cgi?id=25261
--- Comment #1 from NSLW lukasz.wojnilowicz@gmail.com 2011-01-13 12:51:28 CST --- It's still bug in wine-1.3.11-180-g856da7e
http://bugs.winehq.org/show_bug.cgi?id=25261
--- Comment #2 from NSLW lukasz.wojnilowicz@gmail.com 2011-02-02 07:28:30 CST --- It's still bug in wine-1.3.12-272-g2d6b748
http://bugs.winehq.org/show_bug.cgi?id=25261
Carlo Bramini carlo.bramix@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |carlo.bramix@libero.it
--- Comment #3 from Carlo Bramini carlo.bramix@libero.it 2012-04-14 14:06:41 CDT --- I looked the terminal output in the attachment of this bug and then I did some debugging on Windows. I tested StrCpyW and also StrCatW (my intuition suggested me to do so) and I discovered that:
StrCpyW(myDestination, mySource) does not crash, it copies the content of mySource into myDestination, pointer to myDestination is returned.
StrCpyW(myDestination, NULL) does not crash, it leaves myDestination unchanged, pointer to myDestination is returned.
StrCpyW(NULL, NULL) does not crash, it returns NULL.
StrCatW has the same behavior of StrCpyW. Actually, it seems to me that many string functions implemented into shlwapi are already protected against wrong parameters, evidently StrCpyW and StrCatW have need the same fixes that have been made elsewhere, since strcpyW and strcatW don't do it.
I made a patch with this fix here:
http://source.winehq.org/patches/data/85432
Sincerely,
Carlo Bramini.
http://bugs.winehq.org/show_bug.cgi?id=25261
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com
--- Comment #4 from Bruno Jesus 00cpxxx@gmail.com 2012-04-19 17:50:34 CDT --- Patch commited: http://source.winehq.org/git/wine.git/commitdiff/f6524a9f77cfad6b2d6c7745cdc...
http://bugs.winehq.org/show_bug.cgi?id=25261
--- Comment #5 from Carlo Bramini carlo.bramix@libero.it 2012-04-28 05:55:12 CDT --- The above fix is now available in WINE-1.5.3. Is it possible to retest this bug, please?
http://bugs.winehq.org/show_bug.cgi?id=25261
NSLW lukasz.wojnilowicz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #6 from NSLW lukasz.wojnilowicz@gmail.com 2012-04-28 09:11:23 CDT --- (In reply to comment #5)
The above fix is now available in WINE-1.5.3. Is it possible to retest this bug, please?
Fixed in Wine 1.5.3. Thanks!
http://bugs.winehq.org/show_bug.cgi?id=25261
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |f6524a9f77cfad6b2d6c7745cdc | |8598e50e4bdf4 CC| |adys.wh@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=25261
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org 2012-05-11 13:21:56 CDT --- Closing bugs fixed in 1.5.4.
http://bugs.winehq.org/show_bug.cgi?id=25261
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.4.x
http://bugs.winehq.org/show_bug.cgi?id=25261
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.4.x |---