http://bugs.winehq.org/show_bug.cgi?id=26443
Summary: GitWeb: 'patch' links within a commitdiff don't work Product: WineHQ.org Version: unspecified Platform: All OS/Version: All Status: UNCONFIRMED Severity: minor Priority: P2 Component: www-unknown AssignedTo: wine-bugs@winehq.org ReportedBy: ken@codeweavers.com
On a commitdiff page such as http://source.winehq.org/git/wine.git/commitdiff/0b396208db68c950725adae49cedd1486ee56afd, there are "patch" links next to each changed file in the summary (along with "blob", "blame", and "history"). Those patch links should link to an anchor within the page. However, they're currently broken, being something like http://source.winehq.org/git/gitweb.cgi#patch4. The anchor is right, but the page URL is not for the current page.
I have tested with Firefox 3.6.15 and Safari 5.0.3 on Mac OS X 10.6, although I have no reason to believe the browser or OS affect the issue.
http://bugs.winehq.org/show_bug.cgi?id=26443
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
--- Comment #1 from Jerome Leclanche adys.wh@gmail.com 2011-03-16 06:40:21 CDT --- This is because of the <base> in the header.
<base href="http://source.winehq.org/git/gitweb.cgi" />
Any reason why this is still there?
http://bugs.winehq.org/show_bug.cgi?id=26443
--- Comment #2 from Alexandre Julliard julliard@winehq.org 2011-03-16 11:25:35 CDT --- It's a gitweb bug. It will probably be fixed in the next git release.
http://bugs.winehq.org/show_bug.cgi?id=26443
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #3 from Ken Sharp kennybobs@o2.co.uk 2011-04-14 18:07:36 CDT --- Confirming as per comment 2
http://bugs.winehq.org/show_bug.cgi?id=26443
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other OS/Version|All |other
--- Comment #4 from Austin English austinenglish@gmail.com 2012-02-23 15:19:52 CST --- Removing deprecated 'All' Platform/OS.
http://bugs.winehq.org/show_bug.cgi?id=26443
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kennybobs@o2.co.uk
--- Comment #5 from Ken Sharp kennybobs@o2.co.uk 2013-07-13 17:54:03 CDT --- Still present. I assume git has been updated since 2011?
https://bugs.winehq.org/show_bug.cgi?id=26443
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |focht@gmx.net Resolution|--- |FIXED
--- Comment #6 from Anastasius Focht focht@gmx.net --- Hello folks,
works fine here, resolving 'fixed'.
Regards
https://bugs.winehq.org/show_bug.cgi?id=26443
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Bruno Jesus 00cpxxx@gmail.com --- Closing other products fixed bugs.
-
wine-bugs＠winehq.org