[Bug 39096] New: Nvidia Physx uninstaller completely removes PATH registry key from 'HKLM\System\CurrentControlSet\Control\Session Manager\Environment'

https://bugs.winehq.org/show_bug.cgi?id=39096

Bug ID: 39096
           Summary: Nvidia Physx uninstaller completely removes PATH
                    registry key from
                    'HKLM\System\CurrentControlSet\Control\Session
                    Manager\Environment'
           Product: Wine
           Version: 1.7.49
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, Installer
          Severity: minor
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

When creating a new prefix, the registry key
'HKLM\System\CurrentControlSet\Control\Session Manager\Environment\PATH'
contains the paths
C:\windows\system32;C:\windows;C:\windows\system32\wbem
The Nvidia Physx installer adds
'C:\Program Files\NVIDIA Corporation\PhysX\Common'
to the already existing path.
When you remove Physx using 'wine uninstaller', the whole PATH registry key is
removed. The installer should only remove the 'C:\Program Files\NVIDIA
Corporation\PhysX\Common' path, which was added by the installer itself.

1. create a new wineprefix
2. winetricks physx (start regedit and see that the new path was added).
3. launch 'wine uninstaller' and select Physx to remove. After Physx was
removed open regedit and look for the PATH registry key under
'HKLM\System\CurrentControlSet\Control\Session Manager\Environment' ...it's
missing.

Plain terminal output doesn't show too much:
err:msi:msi_dialog_icon_control Failed to load bitmap L"Icon"
err:msi:msiobj_release Invalid handle!
err:msi:msi_dialog_create_controls no handler for element type L"Billboard"
err:msi:msiobj_release Invalid handle!
err:msi:msiobj_release Invalid handle!

wine-1.7.49-41-g36a39ce

[Bug 39096] Nvidia Physx uninstaller completely removes PATH registry key from 'HKLM\System\CurrentControlSet\Control\Session Manager\Environment'

https://bugs.winehq.org/show_bug.cgi?id=39096

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |msi

--- Comment #1 from Hans Leidekker  ---
Confirmed. The bug is in ITERATE_RemoveEnvironmentString.

[Bug 39096] Nvidia Physx uninstaller completely removes PATH registry key from 'HKLM\System\CurrentControlSet\Control\Session Manager\Environment'

https://bugs.winehq.org/show_bug.cgi?id=39096

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 39096] Nvidia Physx uninstaller completely removes PATH registry key from 'HKLM\System\CurrentControlSet\Control\Session Manager\Environment'

https://bugs.winehq.org/show_bug.cgi?id=39096

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |99dfc15e72cc456e565b3139b32
                   |                            |e6f9b908f6609
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Béla Gyebrószki  ---
Fixed by
http://source.winehq.org/git/wine.git/commit/99dfc15e72cc456e565b3139b32e6f9...

[Bug 39096] Nvidia Physx uninstaller completely removes PATH registry key from 'HKLM\System\CurrentControlSet\Control\Session Manager\Environment'

https://bugs.winehq.org/show_bug.cgi?id=39096

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.50.