[Bug 55014] New: kernel32:comm crashes in WoW64 mode on Linux

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55014

Bug ID: 55014
           Summary: kernel32:comm crashes in WoW64 mode on Linux
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: kernel32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

kernel32:comm crashes in WoW64 mode on Linux:

comm.c:708: Found Com port COM1. Connected devices may disturb results
Unhandled exception: page fault on read access to 0x0000000000000000 in 64-bit
code (0x007f47b448083c).
[...]
=>0 0x007f47b448083c wait_for_event+0x1c(arg=<internal error>)
[/home/winetest/tools/testbot/var/wine-wow64/../wine/dlls/ntdll/unix/serial.c:945]
in ntdll.so (0000000000000000)
0x007f47b448083c wait_for_event+0x1c
[/home/winetest/tools/testbot/var/wine-wow64/../wine/dlls/ntdll/unix/serial.c:945]
in ntdll.so: mov (%rdi), %rdi
945        if (!server_get_unix_fd( commio->hDevice, FILE_READ_DATA |
FILE_WRITE_DATA, &fd, &needs_close, NULL, NULL ))

See https://test.winehq.org/data/patterns.html#kernel32:comm

The failure seems to only happen on the TestBot VMs, maybe because of QEmu,
particularly because it does not set the baud rate correctly.

A bisect shows that this failure started with the commit below:

commit b337c5b1a1757b2abbc90a7c6955d64242861ab9
Author: Alexandre Julliard 
Date:   Fri Jun 2 09:35:29 2023 +0200

ntdll: Use the default ABI for all functions on the Unix side.

[Bug 55014] kernel32:comm crashes in WoW64 mode on Linux

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55014

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |b337c5b1a1757b2abbc90a7c695
                   |                            |5d64242861ab9
           Keywords|                            |regression, source,
                   |                            |testcase

[Bug 55014] kernel32:comm crashes in WoW64 mode on Linux

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55014

Eric Pouech  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Eric Pouech  ---
Created attachment 74791
  --> https://bugs.winehq.org/attachment.cgi?id=74791
hacky patch

this is not directly because of QEMU... it's rather that the QEMU VMs are
likely the last to have a proper serial line setup <g>, and we only get the
failure on these

the commit from #1 removed all function calling convention in unix .so part of
DLLs, but serial.c: wait_for_event() is supposed to be a thread entry point,
hence requires a ms_abi calling convention

using the attached hack make it work again

not sure however it's the best way forward: there's a FIXME in serial.c hinting
at getting rid of the thread and use async io instead (but this may require
server evolution); but is it worth putting lots of energy in serial code
support ?

[Bug 55014] kernel32:comm crashes in WoW64 mode on Linux

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55014

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m

[Bug 55014] kernel32:comm crashes in WoW64 mode on Linux

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55014

--- Comment #2 from Eric Pouech  ---
Tried the patch in #2 as a simple MR, but got rejected as the proper fix has to
use asynchronous I/O.

[Bug 55014] kernel32:comm crashes in WoW64 mode on Linux

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55014

Eric Pouech  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]       |

[Bug 55014] kernel32:comm crashes in WoW64 mode on Linux

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55014

[e-mail]  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail]  ---
https://bugs.winehq.org/show_bug.cgi?id=55947

[Bug 55014] kernel32:comm crashes in WoW64 mode on Linux

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55014

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #4 from Hans Leidekker  ---
Duplicate.

*** This bug has been marked as a duplicate of bug 55947 ***

[Bug 55014] kernel32:comm crashes in WoW64 mode on Linux

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55014

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alistair Leslie-Hughes  ---
Closing duplicate.