[Bug 56123] New: Git for windows installer freezes at the last step (but does install the files correctly)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56123

Bug ID: 56123
           Summary: Git for windows installer freezes at the last step
                    (but does install the files correctly)
           Product: Wine
           Version: 9.0-rc3
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

The git for windows installer freezes at the end. The computer beeps when the
window is clicked. The window does not react to the X to close, but it does
react to the minimize button. Afterwards the window can not be restored again.
The installer did install the needed files, as VSCodium did gain git
capabilities.

To reproduce:

Download git for windows:
https://github.com/git-for-windows/git/releases/download/v2.43.0.windows.1/G...
$ rm -rf ~/wine-tmp/
$ mkdir ~/wine-tmp
$ export WINEPREFIX=~/wine-tmp
$ cd ~/wine-tmp
$ cp ~/Downloads/Git-2.43.0-64-bit.exe .
$ wine Git-2.43.0-64-bit.exe Now the installer starts. Accpet the defaults.
Now the installer does it's steps, and stops at "Running post-install script".
When I ctrl-C in the console, the bash promt returns, but the installer window
remains. The computer beeps when the window is clicked. The window does not
react to the X to close, but it does react to the minimize button. Afterwards
the window can not be restored again.

Console output:
[cedric@cedric wine-tmp]$ cp ~/Downloads/Git-2.43.0-64-bit.exe .
[cedric@cedric wine-tmp]$ wine Git-2.43.0-64-bit.exe 
002c:fixme:actctx:parse_depend_manifests Could not find dependent assembly
L"Microsoft.Windows.Common-Controls" (6.0.0.0)
004c:fixme:actctx:parse_depend_manifests Could not find dependent assembly
L"Microsoft.Windows.Common-Controls" (6.0.0.0)
0054:fixme:actctx:parse_depend_manifests Could not find dependent assembly
L"Microsoft.Windows.Common-Controls" (6.0.0.0)
004c:err:ole:StdMarshalImpl_MarshalInterface Failed to create ifstub, hr
0x80004002
004c:err:ole:CoMarshalInterface Failed to marshal the interface
{6d5140c1-7436-11ce-8034-00aa006009fa}, hr 0x80004002
004c:err:ole:apartment_get_local_server_stream Failed: 0x80004002
0054:err:ole:StdMarshalImpl_MarshalInterface Failed to create ifstub, hr
0x80004002
0054:err:ole:CoMarshalInterface Failed to marshal the interface
{6d5140c1-7436-11ce-8034-00aa006009fa}, hr 0x80004002
0054:err:ole:apartment_get_local_server_stream Failed: 0x80004002
0054:err:ole:start_rpcss Failed to open RpcSs service
0090:fixme:file:NtLockFile I/O completion on lock not implemented yet
0090:fixme:ntdll:NtQuerySystemInformation info_class
SYSTEM_PERFORMANCE_INFORMATION
0090:fixme:msi:internal_ui_handler internal UI not implemented for message
0x0b000000 (UI level = 1)
0090:fixme:msi:internal_ui_handler internal UI not implemented for message
0x0b000000 (UI level = 1)
00f0:fixme:msg:pack_message msg 14 (WM_ERASEBKGND) not supported yet
0118:fixme:hid:handle_IRP_MN_QUERY_ID Unhandled type 00000005
0118:fixme:hid:handle_IRP_MN_QUERY_ID Unhandled type 00000005
0118:fixme:hid:handle_IRP_MN_QUERY_ID Unhandled type 00000005
wine: configuration in L"/home/cedric/wine-tmp" has been updated.
0118:fixme:hid:handle_IRP_MN_QUERY_ID Unhandled type 00000005
0024:fixme:thread:GetThreadUILanguage : stub, returning default language.
0024:fixme:nls:RtlGetThreadPreferredUILanguages 00000038, 005ED99C, 00000000
005ED9C4
0024:fixme:nls:get_dummy_preferred_ui_language (0x38 0x409 005ED99C 00000000
005ED9C4) returning a dummy value (current locale)
0024:fixme:nls:RtlGetThreadPreferredUILanguages 00000038, 005ED99C, 015EA680
005ED9C4
0024:fixme:nls:get_dummy_preferred_ui_language (0x38 0x409 005ED99C 015EA680
005ED9C4) returning a dummy value (current locale)
0148:fixme:thread:GetThreadUILanguage : stub, returning default language.
0148:fixme:nls:RtlGetThreadPreferredUILanguages 00000038, 0081D9E8, 00000000
0081DA10
0148:fixme:nls:get_dummy_preferred_ui_language (0x38 0x409 0081D9E8 00000000
0081DA10) returning a dummy value (current locale)
0148:fixme:nls:RtlGetThreadPreferredUILanguages 00000038, 0081D9E8, 019319B0
0081DA10
0148:fixme:nls:get_dummy_preferred_ui_language (0x38 0x409 0081D9E8 019319B0
0081DA10) returning a dummy value (current locale)
0148:fixme:wtsapi:WTSRegisterSessionNotification Stub 000100A4 0x00000000
0148:fixme:uxtheme:BufferedPaintInit Stub ()
0148:fixme:win:DisableProcessWindowsGhosting : stub
0148:fixme:graphics:ShutdownBlockReasonDestroy (000100A4): stub
0148:fixme:graphics:ShutdownBlockReasonCreate (000100A4, L"Installing"): stub
0148:fixme:graphics:ShutdownBlockReasonDestroy (000100A4): stub
0148:fixme:graphics:ShutdownBlockReasonCreate (000100A4, L"Installing Git."):
stub
0148:fixme:system:EnableNonClientDpiScaling (000100B2): stub
0148:fixme:msg:ChangeWindowMessageFilterEx 000100B2 c051 1 00000000
0148:fixme:system:EnableNonClientDpiScaling (000200B2): stub
0148:fixme:msg:ChangeWindowMessageFilterEx 000200B2 c051 1 00000000
0148:fixme:msg:ChangeWindowMessageFilterEx 000100BC c051 1 00000000
0148:fixme:msg:ChangeWindowMessageFilterEx 000200BC c051 1 00000000
0148:fixme:shell:SHAutoComplete stub
0148:fixme:shell:SHAutoComplete stub
0148:fixme:explorerframe:taskbar_list_SetProgressValue iface 01FBDD50, hwnd
000100A4, ullCompleted 0, ullTotal 503 stub!
0148:fixme:sfc:SfcIsFileProtected (00000000, L"C:\Program
Files\Git\unins000.exe") stub
0148:fixme:explorerframe:taskbar_list_SetProgressState iface 01FBDD50, hwnd
000100A4, flags 0 stub!
0188:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
0198:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
0198:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
01a8:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
01a8:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
01b8:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
01b8:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
01c8:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
01c8:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
01d8:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
01d8:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
01e8:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
01e8:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
01f8:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
01f8:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
0208:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
0208:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
0218:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
0218:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
0228:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
0228:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
0238:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
0238:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
0248:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
0248:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
0258:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
0258:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
0268:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
0268:fixme:file:NtFsControlFile FSCTL_GET_REPARSE_POINT semi-stub
0290:fixme:heap:GetNumaHighestNodeNumber semi-stub: 00007FFFFE2FF8C4
02b0:fixme:ntdll:NtSetInformationToken unimplemented class 4
02b0:fixme:security:GetWindowsAccountDomainSid (00000007FFFFC2A0
00000000007C2CF8 00000007FFFFC29C): semi-stub
02b0:fixme:netapi32:DsEnumerateDomainTrustsW ((null), 0x0023, 00000007FFFFC368,
00000007FFFFC354): stub
02b8:fixme:wldap32:ldap_set_optionW Unsupported option: 0x95
02b8:fixme:wldap32:ldap_set_optionW Unsupported option: 0x96
02b0:fixme:netapi32:NetUserGetInfo Only implemented for local computer, but
remote serverL"\\@" was requested.
^C02bc:fixme:console:default_ctrl_handler Terminating process 20 on event 0
[cedric@cedric wine-tmp]$ ^C

I'm running Arch linux, LXDE on Xorg, AMD video card with the open source
drivers.
$ wine --version
wine-9.0-rc3
$ uname -a
Linux cedric 6.6.7-arch1-1 #1 SMP PREEMPT_DYNAMIC Thu, 14 Dec 2023 03:45:42
+0000 x86_64 GNU/Linux

[Bug 56123] Git for windows installer freezes at the last step (but does install the files correctly)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56123

--- Comment #1 from Cedric  ---
After 2 attemps I now have two cores loaded with 100%, and the following in
top:
 38437 cedric    20   0   17400  15872   2048 R  55.8   0.0   2:30.90 wineser+ 
  35141 cedric    20   0   20868  19712   2048 R  54.8   0.1  42:56.48 wineser+ 
  35434 cedric    20   0   10.4g  48728  26432 R  52.5   0.1  41:22.42 bash.exe 
  38699 cedric    20   0   10.4g  41620  26356 R  52.2   0.1   2:22.24 bash.exe

After killing both wineservers (with signal 15), my system is idle again, but
the two installer windows are still there. They don't update anymore.

[Bug 56123] Git for windows installer freezes at the last step with 100% cpu (but does install the files correctly)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56123

Cedric  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Git for windows installer   |Git for windows installer
                   |freezes at the last step    |freezes at the last step
                   |(but does install the files |with 100% cpu (but does
                   |correctly)                  |install the files
                   |                            |correctly)

[Bug 56123] Git for windows installer freezes at the last step with 100% cpu (but does install the files correctly)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56123

Cedric  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/git-for-
                   |                            |windows/git/releases/downlo
                   |                            |ad/v2.43.0.windows.1/Git-2.
                   |                            |43.0-64-bit.exe
           Keywords|                            |download

[Bug 56123] Git for windows installer freezes at the last step with 100% cpu (but does install the files correctly)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56123

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from joaopa  ---
I confirm the problem. But it is not a wine problem
https://github.com/git-for-windows/git/issues/3636

[Bug 56123] Git for windows installer freezes at the last step with 100% cpu (but does install the files correctly)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56123

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Installer, source

[Bug 56123] Git for windows installer freezes at the last step with 100% cpu (but does install the files correctly)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56123

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Fabian Maurer  ---
Pretty sure this is a Wine issue, although I feel like I know this bug already,
I currently can't find a duplicate.

[Bug 56123] Git for windows installer freezes at the last step with 100% cpu (but does install the files correctly)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56123

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Bernhard Übelacker  ---
Created attachment 75809
  --> https://bugs.winehq.org/attachment.cgi?id=75809
Patch by Jinoh Kang from 2021

Killing wineserver might not do what you want, because this leaves the
application processes back hanging. Better might be to use `wineserver -k`.
This instructs wineserver to first kill all applications in this wine prefix,
then wineserver can stop normally. (Would also be good before removing a
prefix.)

This hang in the git installer looks like it is reported in the
msys2 or cygwin installers when running post installation tasks, e.g. bug
52105.

Applying not yet committed parts of
  https://source.winehq.org/patches/data/220602
make the hang go away.
For convenience I attach the rebased version of this patch.

This might also be subject of this merge request:
  https://gitlab.winehq.org/wine/wine/-/merge_requests/498

[Bug 56123] Git for windows installer freezes at the last step with 100% cpu (but does install the files correctly)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56123

Joel Holdsworth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]