[Bug 28302] New: nearly all wine tests show invalid reads/uninitialized values in dib engine
http://bugs.winehq.org/show_bug.cgi?id=28302
Summary: nearly all wine tests show invalid reads/uninitialized values in dib engine Product: Wine Version: 1.3.27 Platform: x86 URL: http://austinenglish.com/logs/valgrind/2011-09-06-04.1 5/vg-gdiplus_customlinecap.txt OS/Version: Linux Status: NEW Keywords: download, regression Severity: major Priority: P2 Component: gdi32 AssignedTo: wine-bugs@winehq.org ReportedBy: austinenglish@gmail.com CC: huw@codeweavers.com
E.g., gdiplus, which normally is valgrind clean, shows: Invalid read of size 1 at matching_color_info (bitblt.c:668) by dibdrv_PutImage (bitblt.c:738) by nulldrv_PutImage (bitmap.c:107) by SetBitmapBits (bitmap.c:535) by CreateBitmapIndirect (bitmap.c:333) by CreateBitmap (bitmap.c:140) by SYSPARAMS_Init (sysparams.c:955) by process_attach (user_main.c:276) by DllMain (user_main.c:332) by __wine_spec_dll_entry (dll_entry.c:40) by ??? (loader.c:139) by MODULE_InitDLL (loader.c:978) by process_attach (loader.c:1067) by process_attach (loader.c:1059) by process_attach (loader.c:1059) by process_attach (loader.c:1059) by attach_process_dlls (loader.c:2541) by ??? (port.c:60) Address 0x7f23ef68 is not stack'd, malloc'd or (recently) free'd ... } Conditional jump or move depends on uninitialised value(s) at matching_color_info (bitblt.c:668) by dibdrv_PutImage (bitblt.c:738) by nulldrv_PutImage (bitmap.c:107) by SetBitmapBits (bitmap.c:535) by CreateBitmapIndirect (bitmap.c:333) by CreateBitmap (bitmap.c:140) by SYSPARAMS_Init (sysparams.c:955) by process_attach (user_main.c:276) by DllMain (user_main.c:332) by __wine_spec_dll_entry (dll_entry.c:40) by ??? (loader.c:139) by MODULE_InitDLL (loader.c:978) by process_attach (loader.c:1067) by process_attach (loader.c:1059) by process_attach (loader.c:1059) by process_attach (loader.c:1059) by attach_process_dlls (loader.c:2541) by ??? (port.c:60) Uninitialised value was created by a stack allocation at SetBitmapBits (bitmap.c:449)
That machine is having some hardware issues, so a regression test will be delayed. Huw, if you can't reproduce, let me know and I'll try it elsewhere..
http://bugs.winehq.org/show_bug.cgi?id=28302
--- Comment #1 from Austin English austinenglish@gmail.com 2011-09-07 03:38:51 CDT --- Looking at local logs, appeared between 32c36b7505e59d29c25e193e598e9edf8496066b and b7ea63118ae1036b2a28ccbfafb43295362dd92e.
http://bugs.winehq.org/show_bug.cgi?id=28302
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #2 from Austin English austinenglish@gmail.com 2011-09-07 15:08:57 CDT --- Fixed by f4e9bdb90436b0e06c0cd30bfd3d2a12f5c56747.
http://bugs.winehq.org/show_bug.cgi?id=28302
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |
--- Comment #3 from Austin English austinenglish@gmail.com 2011-09-07 19:26:00 CDT --- (In reply to comment #2)
Fixed by f4e9bdb90436b0e06c0cd30bfd3d2a12f5c56747.
Rather, partially fixed. The invalid read is still there: Invalid read of size 1 at matching_color_info (bitblt.c:669) by dibdrv_PutImage (bitblt.c:739) by nulldrv_PutImage (bitmap.c:107) by SetBitmapBits (bitmap.c:544) by CreateBitmapIndirect (bitmap.c:333) by CreateBitmap (bitmap.c:140) by SYSPARAMS_Init (sysparams.c:955) by process_attach (user_main.c:276) by DllMain (user_main.c:332) by __wine_spec_dll_entry (dll_entry.c:40) by ??? (loader.c:139) by MODULE_InitDLL (loader.c:978) by process_attach (loader.c:1067) by process_attach (loader.c:1059) by process_attach (loader.c:1059) by process_attach (loader.c:1059) by attach_process_dlls (loader.c:2541) by ??? (port.c:60) Address 0x7f22ef68 is not stack'd, malloc'd or (recently) free'd
http://bugs.winehq.org/show_bug.cgi?id=28302
--- Comment #4 from Huw Davies huw@codeweavers.com 2011-09-08 03:56:52 CDT --- It's because the BITMAPINFO containing a DDB's colour map goes out of scope. Patch sent that'll copy the colour map in this case.
http://bugs.winehq.org/show_bug.cgi?id=28302
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED
--- Comment #5 from Alexandre Julliard julliard@winehq.org 2011-09-23 04:16:57 CDT --- Fixed now.
http://bugs.winehq.org/show_bug.cgi?id=28302
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org 2011-09-23 12:59:18 CDT --- Closing bugs fixed in 1.3.29.
http://bugs.winehq.org/show_bug.cgi?id=28302
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |f4e9bdb90436b0e06c0cd30bfd3 | |d2a12f5c56747 CC| |adys.wh@gmail.com Regression SHA1| |4266fcb28dcb0f2bc2c00b9ee6e | |b816f33660b63
http://bugs.winehq.org/show_bug.cgi?id=28302
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1|f4e9bdb90436b0e06c0cd30bfd3 |7bcd8fa20e99e4db61078846a44 |d2a12f5c56747 |1c0a126b31d50
-
wine-bugs＠winehq.org