[Bug 53719] New: Startopia crashes while loading

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53719

Bug ID: 53719
           Summary: Startopia crashes while loading
           Product: Wine-staging
           Version: 7.18
          Hardware: x86-64
               URL: https://archive.org/download/startopia_demo/startopia_
                    demo.exe
                OS: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail]
      Distribution: ArchLinux

Created attachment 73150
  --> https://bugs.winehq.org/attachment.cgi?id=73150
terminal output

The game crashes at various stages while loading the main menu.
Can be reproduced with the demo version.

Works properly in vanilla Wine-7.18 and used to work in Wine-7.17 Staging.

The patch in Staging causing the crash:
https://github.com/wine-staging/wine-staging/blob/master/patches/ntdll-Junct...

See also bug #53683.

I noticed similar crashes due to the very same patch in other games as well,
e.g. Warhammer 40k GOTY (Steam), Tomb Raider: Underworld (Steam), Morrowind
GOTY, Thief-Deadly Shadows, Quake 4, Battle Isle - The Andosia War.

startopia_demo.exe  (85M)
2e170f8c4700b2d271ac2a6fac23920a

[Bug 53719] Startopia crashes while loading

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53719

--- Comment #1 from Erich E. Hoover  ---
(In reply to Béla Gyebrószki from comment #0)
> ...
> The game crashes at various stages while loading the main menu.
> Can be reproduced with the demo version.
> ...
> See also bug #53683.
> ...

Oh my goodness, thank you - I have been struggling to reproduce what's going on
in Bug #53683 and this app did it immediately.  It looks like the issue is a
leaked file descriptor.  Please go to the end of lookup_unix_name (~4360) and
change:
===
    fchdir( old_cwd );
    free( name_buf );
===
to:
===
    fchdir( old_cwd );
    close ( old_cwd );
    free( name_buf );
===
and let me know if that fixes the problem for you.

[Bug 53719] Startopia crashes while loading

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53719

--- Comment #2 from Béla Gyebrószki  ---
(In reply to Erich E. Hoover from comment #1)
> (In reply to Béla Gyebrószki from comment #0)
> > ...
> > The game crashes at various stages while loading the main menu.
> > Can be reproduced with the demo version.
> > ...
> > See also bug #53683.
> > ...
>
> Oh my goodness, thank you - I have been struggling to reproduce what's going
> on in Bug #53683 and this app did it immediately.  It looks like the issue
> is a leaked file descriptor.  Please go to the end of lookup_unix_name
> (~4360) and change:
> ===
>     fchdir( old_cwd );
>     free( name_buf );
> ===
> to:
> ===
>     fchdir( old_cwd );
>     close ( old_cwd );
>     free( name_buf );
> ===
> and let me know if that fixes the problem for you.

That worked for me, thank you Erich!
All the affected games that I know of are starting properly with it.

[Bug 53719] Startopia crashes while loading

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53719

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Béla Gyebrószki  ---
Fixed in Wine-Staging 7.19.

[Bug 53719] Startopia crashes while loading

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53719

Erich E. Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
      Fixed by SHA1|                            |4f75966580a72cb45d4f351826b
                   |                            |158e527d1d754

--- Comment #4 from Erich E. Hoover  ---
(In reply to Béla Gyebrószki from comment #3)
> Fixed in Wine-Staging 7.19.