http://bugs.winehq.org/show_bug.cgi?id=22699
Summary: Swapchain_blit enhancement introduces x-axis inversion Product: Wine Version: 1.1.36 Platform: All OS/Version: Linux Status: UNCONFIRMED Severity: major Priority: P2 Component: directx-d3d AssignedTo: wine-bugs@winehq.org ReportedBy: kempe.marcus@gmail.com
Created an attachment (id=27970) --> (http://bugs.winehq.org/attachment.cgi?id=27970) 1.1.36 with the problem plainly visible. Notice that there are no y-axis displacements.
Wine release 1.1.36 includes the following changes:
wined3d: Add support for source and destination rectangles to swapchain_blit(). wined3d: Handle source and destination rectangles in IWineD3DSwapChainImpl_Present().
These changes do however introduce a new problem, when using D3DSWAPEFFECT_COPY.
It looks very much as rectangles are blitted on screen at position (x, h - y) instead of at (x, y).
The attached screen shots illustrate the problem. The 1.1.35 screen shot shows what the application looks like in windows, and in wine version <= 1.1.35. Second screenshot shows artefacts from all wine versions >= 1.1.36.
http://bugs.winehq.org/show_bug.cgi?id=22699
--- Comment #1 from Marcus Kempe kempe.marcus@gmail.com 2010-05-14 18:11:48 --- Created an attachment (id=27971) --> (http://bugs.winehq.org/attachment.cgi?id=27971) Same program under wine 1.1.35 (looks same down to wine 1.0)
http://bugs.winehq.org/show_bug.cgi?id=22699
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |dank@kegel.com
http://bugs.winehq.org/show_bug.cgi?id=22699
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other Severity|major |normal
http://bugs.winehq.org/show_bug.cgi?id=22699
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wylda@volny.cz
--- Comment #2 from Wylda wylda@volny.cz 2010-05-15 02:48:40 ---
* You should test it in 1.1.44, to be sure not chasing fixed bug
* Is this really a Direct3D?
* Could you pass direct download to the URL (if yes, then add download keyword)
http://bugs.winehq.org/show_bug.cgi?id=22699
Marcus Kempe kempe.marcus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
--- Comment #3 from Marcus Kempe kempe.marcus@gmail.com 2010-05-15 03:31:10 --- Direct download to application in question:
http://www.goldstrikepoker.com/download/Gold%20Strike%20Poker%20Setup.exe
Do regular install, then start application and login using these credentials: username: wine password: wine_debug
You will notice that there is no problem on the login screen (this is because the whole screen is redrawn once every frame here). But once logged in, it becomes very apparent.
Also, with regards to program version, I've tested practically every version between 1.1.36 - 1.1.44 and they all display the exact same problem. The problem definitely persists in 1.1.44.
http://bugs.winehq.org/show_bug.cgi?id=22699
Marcus Kempe kempe.marcus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Swapchain_blit enhancement |Swapchain_blit enhancement |introduces x-axis inversion |introduces y-axis inversion
http://bugs.winehq.org/show_bug.cgi?id=22699
Marcus Kempe kempe.marcus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #27970|1.1.36 with the problem |1.1.36 with the problem description|plainly visible. Notice |plainly visible. Notice |that there are no y-axis |that there are no x-axis |displacements. |displacements.
http://bugs.winehq.org/show_bug.cgi?id=22699
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.goldstrikepoker. | |com/download/Gold%20Strike% | |20Poker%20Setup.exe
http://bugs.winehq.org/show_bug.cgi?id=22699
--- Comment #4 from Wylda wylda@volny.cz 2010-05-15 14:08:06 ---
This is quite easy to reproduce and well prepared (download even with login;) When i move mouse cursor over some button it jumps usually upwards and is painted twice. (Yes/No button on exit for example).
1. Confirming, please consider UNCONFIRMED->NEW
2. I did a regression test between 1.1.35 and 1.1.36:
commit ce2c3ea6c74f7c28f0ec55e097d582b68c080d19 Author: Henri Verbeet hverbeet@codeweavers.com Date: Sun Jan 3 21:18:26 2010 +0100
wined3d: Handle source and destination rectangles in IWineD3DSwapChainImpl_Present().
:040000 040000 c9f702ad05cb5c903597bd934605ce3d6037bd20 ae2ee3eeff4d13357d2eb9914baa8a201ee57d30 M dlls
3. There are another bug reports suffering from this commit, see bug 21384 and bug 21869, but are marked as fixed in 1.1.41. Problem described here persist even in 1.1.41 and 1.1.44-170-g69326aa.
4. Revert of this patch after git checkout makes that problem go away.
5. Adding author of this patch to CC.
--private keyword: bisected
http://bugs.winehq.org/show_bug.cgi?id=22699
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hverbeet@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=22699
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #5 from Dan Kegel dank@kegel.com 2010-05-15 14:53:23 --- Confirming.
http://bugs.winehq.org/show_bug.cgi?id=22699
--- Comment #6 from Henri Verbeet hverbeet@gmail.com 2010-05-19 11:43:40 --- Should be fixed by 7bec8e1dcb1d08e22ff4929eed024eb470933bb8. There was also a crash on exit that should be fixed by 2c2e3f8665913776c84171c9521392d6f4c31fd3.
http://bugs.winehq.org/show_bug.cgi?id=22699
--- Comment #7 from Wylda wylda@volny.cz 2010-05-19 13:19:09 --- (In reply to comment #6)
Should be fixed by 7bec8e1dcb1d08e22ff4929eed024eb470933bb8. There was also a crash on exit that should be fixed by 2c2e3f8665913776c84171c9521392d6f4c31fd3.
What a speed :-D
You are definitely going for AJ's FOTMA (Fixer of the Month Award) if exists ;)
Confirming, fixed in wine-1.1.44-322-g5cc00e8.
http://bugs.winehq.org/show_bug.cgi?id=22699
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #8 from Austin English austinenglish@gmail.com 2010-05-19 14:12:31 --- Fixed.
http://bugs.winehq.org/show_bug.cgi?id=22699
--- Comment #9 from Marcus Kempe kempe.marcus@gmail.com 2010-05-19 15:03:10 --- Thank you all very much for this, greatly appreciated.
Keep up the great work!!
http://bugs.winehq.org/show_bug.cgi?id=22699
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Alexandre Julliard julliard@winehq.org 2010-05-21 14:40:20 --- Closing bugs fixed in 1.2-rc1.
http://bugs.winehq.org/show_bug.cgi?id=22699
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |7bec8e1dcb1d08e22ff4929eed0 | |24eb470933bb8 Regression SHA1| |ce2c3ea6c74f7c28f0ec55e097d | |582b68c080d19