[Bug 25089] New: Regression in usp10 - completely garbled output

http://bugs.winehq.org/show_bug.cgi?id=25089

Summary: Regression in usp10 - completely garbled output
           Product: Wine
           Version: 1.3.3
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: usp10
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=31811)
 --> (http://bugs.winehq.org/attachment.cgi?id=31811)
screen shot

I found a regression in recent Wine (1.3.3 and newer) with a commercial program
I am using from time to time. The characters in simple dialog (buttons and
labels) are completely garbled ("$BODFM" instead of "Cancel"). See attached
screen shots.

Bisection turned out that the regression was caused by

commit e8816357416a8d3c6bc3d539b869e2e5c29656b2
Author: Aric Stewart 
Date:   Wed Sep 8 13:30:46 2010 -0500

usp10: Attempt to shape with non TMPF_TRUETYPE fonts.

Just do not do the parts that are known to require ttf tables.

[Bug 25089] Regression in usp10 - completely garbled output

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #1 from Martin Wilck  2010-11-09 14:28:38 CST ---
Created an attachment (id=31812)
 --> (http://bugs.winehq.org/attachment.cgi?id=31812)
This is how this dialog is supposed to look

[Bug 25089] Regression in usp10 - completely garbled output

http://bugs.winehq.org/show_bug.cgi?id=25089

Martin Wilck  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 25089] Regression in usp10 - completely garbled output

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #2 from Aric Stewart  2010-11-09 14:31:04 CST ---
Can you give me a +uniscribe log?

[Bug 25089] Regression in usp10 - completely garbled output

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #3 from Martin Wilck  2010-11-09 14:33:06 CST ---
Created an attachment (id=31813)
 --> (http://bugs.winehq.org/attachment.cgi?id=31813)
trace=uniscribe log of good case

This log was generated with wine d82255575b8be0fc8068a5572f9077a965103f2a (the
commit immediately before the regression).

[Bug 25089] Regression in usp10 - completely garbled output

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #4 from Martin Wilck  2010-11-09 14:34:20 CST ---
Created an attachment (id=31814)
 --> (http://bugs.winehq.org/attachment.cgi?id=31814)
trace=uniscribe log of bad case

This trace was generated with e8816357416a8d3c6bc3d539b869e2e5c29656b2.

[Bug 25089] Regression in usp10 - completely garbled output

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #5 from Aric Stewart  2010-11-09 14:38:53 CST ---
(In reply to comment #4)
> Created an attachment (id=31814)

--> (http://bugs.winehq.org/attachment.cgi?id=31814) [details]
> trace=uniscribe log of bad case
>
> This trace was generated with e8816357416a8d3c6bc3d539b869e2e5c29656b2.

Could I get the logs in gzip or bzip?

[Bug 25089] Regression in usp10 - completely garbled output

http://bugs.winehq.org/show_bug.cgi?id=25089

Martin Wilck  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31813|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Wilck  2010-11-09 14:46:59 CST ---
Created an attachment (id=31815)
 --> (http://bugs.winehq.org/attachment.cgi?id=31815)
31813: trace=uniscribe log of good case

[Bug 25089] Regression in usp10 - completely garbled output

http://bugs.winehq.org/show_bug.cgi?id=25089

Martin Wilck  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31814|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Wilck  2010-11-09 14:47:36 CST ---
Created an attachment (id=31816)
 --> (http://bugs.winehq.org/attachment.cgi?id=31816)
trace=uniscribe log of bad case

[Bug 25089] Regression in usp10 - completely garbled output

http://bugs.winehq.org/show_bug.cgi?id=25089

Martin Wilck  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31815|31813: trace=uniscribe log  |trace=uniscribe log of good
        description|of good case                |case

[Bug 25089] Regression in usp10 - completely garbled output

http://bugs.winehq.org/show_bug.cgi?id=25089

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Regression in usp10 -       |The characters in simple
                   |completely garbled output   |dialog (buttons and labels)
                   |                            |are completely garbled
                   |                            |("$BODFM" instead of
                   |                            |"Cancel")
           Severity|major                       |normal

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #8 from Aric Stewart  2011-05-17 08:09:50 CDT ---
(In reply to comment #7)
> Created an attachment (id=31816)

--> (http://bugs.winehq.org/attachment.cgi?id=31816) [details]
> trace=uniscribe log of bad case

Sorry for the long delay,  Does this error still occur?

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #9 from Martin Wilck  2011-05-23 16:07:55 CDT ---
I need to check ...

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #10 from Martin Wilck  2011-05-31 16:01:14 CDT ---
Yes, it still happens.

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #11 from Martin Wilck  2011-05-31 16:01:49 CDT ---
Sorry: 
$ wine --version
wine-1.3.20-439-g1ec78b8

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |e8816357416a8d3c6bc3d539b86
                   |                            |9e2e5c29656b2

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #12 from Aric Stewart  2011-08-19 08:14:03 CDT ---
(In reply to comment #11)
> Sorry: 
> $ wine --version
> wine-1.3.20-439-g1ec78b8

Could you generate me a new bad log with +gdi,+font,+uniscribe

thanks!
-aric

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #13 from Martin Wilck  2011-08-27 13:57:57 CDT ---
Created an attachment (id=36125)
 --> (http://bugs.winehq.org/attachment.cgi?id=36125)
wine-1.3.26 trace with WINEDEBUG=+gdi,+font,+uniscribe

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #14 from Aric Stewart  2011-08-29 08:22:46 CDT ---
Created an attachment (id=36150)
 --> (http://bugs.winehq.org/attachment.cgi?id=36150)
disable shaping for Symbol and device fonts

Please try this patch and tell me if it improved the behavior.

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #15 from Martin Wilck  2011-08-29 17:01:54 CDT ---
Created an attachment (id=36153)
 --> (http://bugs.winehq.org/attachment.cgi?id=36153)
trace with WINEDEBUG=+gdi,+font,+uniscribe

wine from git commit 49dc1570b77dfa9f8a709d960af8be95284e5587, with patch from
attachment #36125 still fails.

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

--- Comment #16 from Aric Stewart  2011-09-06 11:43:53 CDT ---
(In reply to comment #15)
> Created an attachment (id=36153)

--> (http://bugs.winehq.org/attachment.cgi?id=36153) [details]
> trace with WINEDEBUG=+gdi,+font,+uniscribe
>
> wine from git commit 49dc1570b77dfa9f8a709d960af8be95284e5587, with patch from
> attachment #36125 [details] still fails.

I believe I have just submitted a patch that has been committed that corrects
this.

could you retest?

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

Martin Wilck  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #17 from Martin Wilck  2011-09-16 15:47:57 CDT ---
Congratulations! The problem is fixed.

wine  --version 
wine-1.3.28-308-gae80430

[Bug 25089] The characters in simple dialog (buttons and labels) are completely garbled ("$BODFM" instead of "Cancel")

http://bugs.winehq.org/show_bug.cgi?id=25089

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Alexandre Julliard  2011-09-23 12:59:32 CDT ---
Closing bugs fixed in 1.3.29.