[Bug 51778] New: ws2_32:sock crashes due to a double free

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51778

Bug ID: 51778
           Summary: ws2_32:sock crashes due to a double free
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: winsock
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

ws2_32:sock crashes due to a double free. This happens in all Wine builds
(win32 & wow*). In the report one usually sees a regular crash message:

sock.c:5599: Test marked todo: expected 1, got 0
Unhandled exception: page fault on execute access to 0x45455246, invalid
program stack in 32-bit code (0x45455246).
...

https://test.winehq.org/data/patterns.html#ws2_32:sock

But the tell-tale error is in the Wine logs ('Show full task log' in  the
TestBot):

free(): double free detected in tcache 2

A bisect shows that this started with the commit below:

commit 1eb56b20baefcdccaafbb622cadc71670c149e18
Author: Zebediah Figura 
Date:   Tue Sep 14 01:02:48 2021 -0500

ntdll: Explicitly return whether an async is complete in async_callback_t.

Signed-off-by: Zebediah Figura 
    Signed-off-by: Alexandre Julliard

[Bug 51778] ws2_32:sock crashes due to a double free

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51778

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression, source,
                   |                            |testcase
    Regression SHA1|                            |1eb56b20baefcdccaafbb622cad
                   |                            |c71670c149e18

[Bug 51778] ws2_32:sock crashes due to a double free

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51778

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Zebediah Figura  ---
It should be fixed by https://source.winehq.org/patches/data/215055 and
https://source.winehq.org/patches/data/215057.

[Bug 51778] ws2_32:sock crashes due to a double free

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51778

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |4f4fee53a61c231d21a9ba0669f
                   |                            |200b9f60a5de4
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
            Version|unspecified                 |6.17

--- Comment #2 from Zebediah Figura  ---
Fixed by
https://source.winehq.org/git/wine.git/commitdiff/4f4fee53a61c231d21a9ba0669f200b9f60a5de4.

[Bug 51778] ws2_32:sock crashes due to a double free

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51778

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 6.19.