[Bug 47992] New: msi:action tests fail when running them twice

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47992

Bug ID: 47992
           Summary: msi:action tests fail when running them twice
           Product: Wine
           Version: 4.17
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

See the test results on the cw-*-64 machines, which are being run after the 32
bit tests:

https://test.winehq.org/data/tests/msi:action.html

This is due to the

HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\UserData$USER\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\Features

key still being left after the tests. I'm not sure how to properly remove it.
Most machines are being reverted for every test run, so there it is not
visible.

[Bug 47992] msi:action tests fail when running them twice

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47992

--- Comment #1 from Hans Leidekker  ---
(In reply to Sven from comment #0)
> See the test results on the cw-*-64 machines, which are being run after the
> 32 bit tests:
>
> https://test.winehq.org/data/tests/msi:action.html
>
> This is due to the
>
> HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\UserDa
> ta$USER\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\Features
>
> key still being left after the tests. I'm not sure how to properly remove
> it. Most machines are being reverted for every test run, so there it is not
> visible.

Do you know which of the tests in that file is to blame?

[Bug 47992] msi:action tests fail when running them twice

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47992

--- Comment #2 from Sven  ---
I think almost all of them, but I tested that at least test_install_services
leaves a registry entry behind after the test if you want a minimal example.

[Bug 47992] msi:action tests fail when running them twice

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47992

--- Comment #3 from Hans Leidekker  ---
These errors appear to be gone now. I know that
4f7bd33a838afca7086e993a9be7fa2d8dbdb5b6 fixed some of them, but not all.

[Bug 47992] msi:action tests fail when running them twice

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47992

--- Comment #4 from Sven  ---
I think Zeb fixed the last few in 932ed6bf84a96efa6e0169eb7c9414824eef195c

[Bug 47992] msi:action tests fail when running them twice

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47992

--- Comment #5 from Hans Leidekker  ---
(In reply to Sven from comment #4)
> I think Zeb fixed the last few in 932ed6bf84a96efa6e0169eb7c9414824eef195c

Right, shall we close this bug then?

[Bug 47992] msi:action tests fail when running them twice

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47992

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |932ed6bf84a96efa6e0169eb7c9
                   |                            |414824eef195c

--- Comment #6 from Hans Leidekker  ---
Fixed by 932ed6bf84a96efa6e0169eb7c9414824eef195c.

[Bug 47992] msi:action tests fail when running them twice

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47992

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 5.3.