[Bug 55354] New: user32:msg - test_dialog_messages() sometimes gets a bad sequence on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55354

Bug ID: 55354
           Summary: user32:msg - test_dialog_messages() sometimes gets a
                    bad sequence on Windows 7
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]

user32:msg - test_dialog_messages() sometimes gets a bad message sequence on
Windows 7:

msg.c:15393: Test failed: CreateDialogParam_1: 17: the msg 0x001c was expected,
but got msg 0x000d instead
msg.c:15393: Test failed: CreateDialogParam_1: 18: the msg 0x0086 was expected,
but got msg 0x0083 instead
msg.c:15393: Test failed: CreateDialogParam_1: 19: the msg 0x0006 was expected,
but got msg 0x800b instead
msg.c:15393: Test failed: CreateDialogParam_1: 20: the msg 0x8005 was expected,
but got msg 0x001c instead
msg.c:15393: Test failed: CreateDialogParam_1: 21: the msg 0x0007 was expected,
but got msg 0x0086 instead
msg.c:15393: Test failed: CreateDialogParam_1: 23: the msg sequence is not
complete: expected 0000 - actual 0006

See https://test.winehq.org/data/patterns.html#user32:msg

Where: 0x0006 == WM_ACTIVATE
       0x000d == WM_GETTEXT
       0x001c == WM_ACTIVATEAPP
       0x0083 == WM_NCCALCSIZE
       0x0086 == WM_NCACTIVATE
       0x8005 == EVENT_OBJECT_FOCUS
       0x800b == EVENT_OBJECT_LOCATIONCHANGE

This first happened on 2023-06-22 and there has been about one instance per
week since, always receiving the same unexpected message sequence:
* 2023-06-22 win7_newtb-w7u-2qxl
* 2023-06-28 win7_newtb-w7u-es
* 2023-07-05 win7_newtb-w7u-2qxl
* 2023-07-27 win7_newtb-w7u-2qxl

[Bug 55354] user32:msg - test_dialog_messages() sometimes gets a bad sequence on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55354

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

--- Comment #1 from François Gouget  ---
Also 0x0007 == WM_SETFOCUS

[Bug 55354] user32:msg - test_dialog_messages() sometimes gets a bad sequence on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55354

--- Comment #2 from Esme Povirk  ---
Can you link to an actual log, which will have the full message sequence?

[Bug 55354] user32:msg - test_dialog_messages() sometimes gets a bad sequence on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55354

Esme Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 55354] user32:msg - test_dialog_messages() sometimes gets a bad sequence on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55354

--- Comment #3 from Esme Povirk  ---
Found it here:
http://test.winehq.org/data/9285aa5bb1338d8e2c1ac6b95974182b3f4881a9/win7_ne...

From having spent a lot of time with this test unit recently, those messages
are common on win7 and can just be added.

MR sent: https://gitlab.winehq.org/wine/wine/-/merge_requests/3444

[Bug 55354] user32:msg - test_dialog_messages() sometimes gets a bad sequence on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55354

--- Comment #4 from Esme Povirk  ---
The MR was merged as
https://gitlab.winehq.org/wine/wine/-/commit/1dc8cdae25cf42cceae04274688f4ed...

I guess there's no way to retest this except to wait and see if it appears
again.

[Bug 55354] user32:msg - test_dialog_messages() sometimes gets a bad sequence on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55354

Esme Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |1dc8cdae25cf42cceae04274688
                   |                            |f4ed1260fe14b
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Esme Povirk  ---
It's not showing up in https://testbot.winehq.org/FailureDetails.pl?Key=755 so
I'm going to say this is fixed.

[Bug 55354] user32:msg - test_dialog_messages() sometimes gets a bad sequence on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55354

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 8.16.