[Bug 43196] New: Eve Online Crash on macos wined3d-csmt.dll.so buffer_destroy_buffer_object ()

https://bugs.winehq.org/show_bug.cgi?id=43196

Bug ID: 43196
           Summary: Eve Online Crash on macos wined3d-csmt.dll.so
                    buffer_destroy_buffer_object()
           Product: Wine-staging
           Version: 2.10
          Hardware: x86
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail]

Created attachment 58470
  --> https://bugs.winehq.org/attachment.cgi?id=58470
lldb_wine-2.10_Eve_Online_crash_backtrace txt

Eve Online has been crashing lately when run in both wine and wine-staging.
I have "subjectively" noticed this since wine 2.9 and it seems that the crashes
"subjectively" occur more in wine 2.10. The crashes are random. There does not
seem to be an particular action that will trigger the crash.

[Bug 43196] Eve Online Crash on macos wined3d-csmt.dll.so buffer_destroy_buffer_object ()

https://bugs.winehq.org/show_bug.cgi?id=43196

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |be20ddc38b3f9e101460f5f8f04
                   |                            |015b148d3e13d
                 CC|                            |[e-mail]
           Keywords|                            |regression
          Component|-unknown                    |directx-d3d
            Product|Wine-staging                |Wine

--- Comment #1 from Sebastian Lackner  ---
Thanks for the bug report. Based on the backtrace, this particular commit was
introduced in:

https://source.winehq.org/git/wine.git/patch/be20ddc38b3f9e101460f5f8f04015b...

The WINED3D_BUFFER_APPLESYNC code manually creates a query (see
buffer_sync_apple() in buffer.c), but fails to set proper query_ops. Adding the
author as CC.

[Bug 43196] Eve Online Crash on macos wined3d-csmt.dll.so buffer_destroy_buffer_object ()

https://bugs.winehq.org/show_bug.cgi?id=43196

--- Comment #2 from Józef Kucia  ---
Created attachment 58479
  --> https://bugs.winehq.org/attachment.cgi?id=58479
Patch

Could you please test the attached patch?

[Bug 43196] Eve Online Crash on macos wined3d-csmt.dll.so buffer_destroy_buffer_object ()

https://bugs.winehq.org/show_bug.cgi?id=43196

--- Comment #3 from Dave-C  ---
Patch seems to work. No random crashes so far.

[Bug 43196] Eve Online Crash on macos wined3d-csmt.dll.so buffer_destroy_buffer_object ()

https://bugs.winehq.org/show_bug.cgi?id=43196

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |STAGED
                 CC|                            |[e-mail]
    Staged patchset|                            |https://github.com/wine-com
                   |                            |pholio/wine-staging/tree/ma
                   |                            |ster/patches/wined3d-buffer
                   |                            |_sync_apple

[Bug 43196] Eve Online Crash on macos wined3d-csmt.dll.so buffer_destroy_buffer_object ()

https://bugs.winehq.org/show_bug.cgi?id=43196

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |0edb71a35ffe00450b315a735b9
                   |                            |853bd2d982e77
             Status|STAGED                      |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Józef Kucia  ---
Fixed by commit 0edb71a35ffe00450b315a735b9853bd2d982e77

[Bug 43196] Eve Online Crash on macos wined3d-csmt.dll.so buffer_destroy_buffer_object ()

https://bugs.winehq.org/show_bug.cgi?id=43196

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 2.13.