[Bug 49244] New: GdipDeleteFontFamily is declared, but does nothing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49244

Bug ID: 49244
           Summary: GdipDeleteFontFamily is declared, but does nothing
           Product: Wine
           Version: 5.9
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdiplus
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Function just check if FontFamily is null and return value without doing
anything.

https://github.com/wine-mirror/wine/blame/056c9df854817670dc4fb9c095cba29c99...

[Bug 49244] GdipDeleteFontFamily is declared, but does nothing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49244

Michael McGuire  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Michael McGuire  ---
afaik this is normal for wine, presumably 12 years ago someone found an app
that calls that function and "do nothing but return ok" made it work.

[Bug 49244] GdipDeleteFontFamily is declared, but does nothing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49244

--- Comment #2 from Nikolay Sivov  ---
It's a recent change, see b9307cfa61e9884b01d34c2310ec1ffbb1868728. If you have
discovered any issues with that please outline them, otherwise I don't see a
reason for this report.

[Bug 49244] GdipDeleteFontFamily is declared, but does nothing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49244

--- Comment #3 from Rafał Mikrut  ---
I don't have any real world problems caused by this, but Coverity Scan shows
"Useless Call" bug, because function doesn't change anything and sometimes even
others functions doesn't use return value from this function.

https://github.com/wine-mirror/wine/blob/6d801377055911d914226a3c6af8d8637a6...

https://github.com/wine-mirror/wine/search?q=GdipDeleteFontFamily&unscop...

[Bug 49244] GdipDeleteFontFamily is declared, but does nothing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49244

--- Comment #4 from Esme Povirk  ---
It's not clear that this function needs to do anything. We know that for every
installed font there is exactly one FontFamily object, and in all current tests
GdipCloneFontFamily returns the same pointer that was passed in. It wouldn't
make sense to ever free the FontFamily for an installed font.

For a private font collection, it's less clear, should each font family have
its own lifetime or be tied to the collection? If they have an independent
lifetime, we need reference counting. But it's also possible that they
shouldn't be used after the font collection is destroyed. Until we know for
sure, I think we should take the simpler approach.

[Bug 49244] GdipDeleteFontFamily is declared, but does nothing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49244

--- Comment #5 from Rafał Mużyło  ---
Just for reference: bug 50896.

[Bug 49244] GdipDeleteFontFamily is declared, but does nothing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49244

Esme Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 49244] GdipDeleteFontFamily is declared, but does nothing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49244

Bartosz  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]

--- Comment #6 from Bartosz  ---
The issue was fixed with commit by Esme:
a5540798605b3ef9abcf654bc28d9dd8d8736e53

[Bug 49244] GdipDeleteFontFamily is declared, but does nothing

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49244

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 9.17.