[Bug 124] Review of Wine Server Protocol

http://bugs.winehq.org/show_bug.cgi?id=124

Steven Edwards  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Steven Edwards   2008-05-02 23:09:02 ---
I'd like to see the x86-64 server request padding patch go in if there is still
time as Winelib64 is partly working these days.

See Greg van Geldorp's comments here

http://oss.gse.nl/wine/

Allocate more space in server request structure

I submitted a patch for this which was at first ignored. Some time later, a
thread
[http://www.winehq.org/pipermail/wine-devel/2006-July/049811.html] was started
on wine-devel about this patch. If I understand the argument correctly,
Alexandre says the patch wastes memory. I'm not sure I understand that, it's
not like there are thousands or even hundreds of these structures allocated at
the same time. In fact, I ran some tests and found the maximum number of
request structures allocated at the same time to be 3. So the maximum amount of
memory saved would be 3 * 32 = 96 bytes of stack space, on Wine64 only (no
waste on Wine32). To conserve that amount, extra code would need to be added
for more complicated packing and unpacking. My guess is that the code to do
that would take up more than 96 bytes, making this a nett loss.
In the mean time, Pavel Roskin submitted a slightly better version:
Patch [http://oss.gse.nl/wine/Win64-needs-more-space.txt]