[Bug 58437] New: Total Commander 11.55 complains "Access denied" for EVERY file >= 1 MB in "Compare files by content"

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58437

Bug ID: 58437
           Summary: Total Commander 11.55 complains "Access denied" for
                    EVERY file >= 1 MB in "Compare files by content"
           Product: Wine
           Version: 10.0
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 78885
  --> http://bugs.winehq.org/attachment.cgi?id=78885
screenshot displaying the error message

When I call in TC (Total Commander) Menu "Files / Compare By Content" and one
(or both) files have a size of 1 MB or greater (exactly 1.048.576 bytes or
anything greater) then TC shows an Error Message "Access denied on file XYZ"
(see attached screenshot) and the compare aborts. 
But EXACTLY the same file(s) can be displayed (by F3 = Lister) and edited (by
F4 = Editor) WITHOUT any problems! So this file has NO general problems, but
only always with Menu "Files / Compare By Content".

More infos:
 - this bug occurs identically with ALL tested 32-bit versions of TC = 11.55 +
11.51 + 10.51 + 10.50 + 9.51 + 8.52
 - this bug does NOT occur with all tested 64-bit versions of TC = 11.51 +
10.52 (but in all 64-bit versions of TC it's GUI is displayed not correctly,
which makes using them confusing and uncomfortable, so 64-bit is no good
workaround)
 - it did not help to create a new 32 bit wineprefix via "WINEARCH=win32
WINEPREFIX=/home/hg6/.wine32 winecfg"
 - this bug occurs with wine-10.0 and wine-9.0 (Ubuntu 9.0~repack-4build3),
both on Ubuntu 24.04 x86_64
 - this bug only occurs with all files >= 1 MB on NTFS + FAT32 + FAT16 file
systems, but not on an ext4 file system
 - this bug did NOT occur with wine-6.0.3 (on Ubuntu 22.04 x86_64 with exactly
the same files and exactly the same TC versions)
 - of course this bug does not occur on pure Windows (with exactly the same
files and exactly the same TC versions)
 - chkdsk (in pure Windows) did not find any errors on the affected drives

Download link:
https://totalcommander.ch/1155/tcmd1155x32.exe or now via
https://www.ghisler.com/download.htm

SHA1 checksum:
sha1sum tcmd1155x32.exe
bcb1dbbc22e08d6c7a5fa39687fa55c745698ea9  tcmd1155x32.exe

[Bug 58437] Total Commander 11.55 complains "Access denied" for EVERY file >= 1 MB in "Compare files by content"

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58437

--- Comment #1 from Hartmut  ---
Created attachment 78886
  --> http://bugs.winehq.org/attachment.cgi?id=78886
terminal output when the error occurs

[Bug 58437] Total Commander 11.55 complains "Access denied" for EVERY file >= 1 MB in "Compare files by content"

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58437

Hartmut  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
       Distribution|---                         |Ubuntu
           Keywords|                            |download, regression

[Bug 58437] Total Commander 11.55 complains "Access denied" for EVERY file >= 1 MB in "Compare files by content"

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58437

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|x86-64                      |x86
                 CC|                            |[e-mail]
                URL|                            |https://totalcommander.ch/1
                   |                            |155/tcmd1155x32.exe

--- Comment #2 from Alex Henrie  ---
I can't reproduce the error. Maybe something else changed between Ubuntu 22.04
and Ubuntu 24.04? Can you please retest Wine 6.0.3 and Wine 9.0 on the same
version of Ubuntu?

[Bug 58437] Total Commander 11.55 complains "Access denied" for EVERY file >= 1 MB in "Compare files by content"

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58437

--- Comment #3 from Hartmut  ---
Thanks Alex for your answer.
I saw you changed "Hardware" from x86-64 to x86. To be clear: my OS is 64-bit,
but the bug occurs only with TC (Total Commander) 32-bit.

You wrote "I can't reproduce the error". On which Ubuntu version and WINE
version and TC version and file system did you test please?

I don't have Ubuntu 22.04 any longer. I can only test something with Ubuntu
24.04.
I already tested wine-9.0 (Ubuntu 9.0~repack-4build3) and wine-10.0 on Ubuntu
24.04 (where both the bug occured).
Are you sure that wine 6.0.3 is installable and will work on Ubuntu 24.04?

[Bug 58437] Total Commander 11.55 complains "Access denied" for EVERY file >= 1 MB in "Compare files by content"

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58437

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Bernhard Übelacker  ---
I could reproduce it with these steps:

truncate -s 300M /mnt/test.img
mkfs.ntfs -F /mnt/test.img
mkdir /mnt/test
mount -o noexec,nodev,nosuid,uid=1000,gid=1000 /mnt/test.img /mnt/test

wine /home/benutzer/tcmd1155x32.exe
truncate -s 1048576 /mnt/test/sect0
truncate -s 104857 /mnt/test/_infos.txt
cd $WINEPREFIX/drive_c/Program Files/totalcmd
wine TOTALCMD.EXE
- change both panes to z:\mnt\test
- right click in left pane to file sect0, to mark it
- right click in right pane to file _infos.txt, to mark it
- Files - Compare by Content...
- shows a message ending with "...The two files are DIFFERENT!"
- button OK
- button Compare
- shows a message ending with "...Error: Cannot read ..." like in the
screenshot

broken  10.0.0~bookworm-1
broken  10.3~bookworm-1
broken  6c9d59c9d2e6
working 07160a23fa21
working 10.4~bookworm-1     
working 10.5~bookworm-1
working 10.11~bookworm-1

07160a23fa2139c2dc9cad92158ddf0b64a3e75e is the first working commit
commit 07160a23fa2139c2dc9cad92158ddf0b64a3e75e
Author: Alexandre Julliard 
Date:   Thu Mar 20 15:35:39 2025 +0100

ntdll: Always map files as writable and adjust permissions.

So that PAGE_WRITECOPY can be set after the fact.

Therefore I think this issue is already solved since wine-10.4.

[Bug 58437] Total Commander 11.55 complains "Access denied" for EVERY file >= 1 MB in "Compare files by content"

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58437

--- Comment #5 from Bernhard Übelacker  ---
I did also a few tests because of the regression.
But I could reproduce this error down to wine-4.13, so might
it be possible Ubuntu 22.04 did not mount those filesystems noexec?

broken  4.13~bullseye
broken  5.0.0~bullseye
broken  6.0.0~bullseye-1
broken  6.16~bookworm-1
broken  7.0.0~bookworm-2
broken  8.0.0~bookworm-1
broken  8.10~bookworm-1
broken  9.0.0~bookworm-1

[Bug 58437] Total Commander 11.55 complains "Access denied" for EVERY file >= 1 MB in "Compare files by content"

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58437

Hartmut  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Hartmut  ---
Thank you VERY MUCH Bernhard for your extensive tests and their detailed
report!
I installed wine 10.11 on Ubuntu 24.04 and the bug is now gone! I'm very happy!

You wrote:
> might it be possible Ubuntu 22.04 did not mount those filesystems noexec?

I don't know. I mount always all affected drives via /etc/fstab with option
'users', which from the documentation should automatically include 'noexec'. So
'noexec' should have been active also in Ubuntu 22.04.
I made a test in Ubuntu 24.04 by adding 'noexec' respective 'exec' in
/etc/fstab after option 'users', but both made no difference.

Because this is my very first bug report for WINE: should I now "close" this
report? Is this done by editing 'Status' from UNCONFIRMED to RESOLVED? Or
should better somebody else close this report?

[Bug 58437] Total Commander 11.55 complains "Access denied" for EVERY file >= 1 MB in "Compare files by content"

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58437

--- Comment #7 from Bernhard Übelacker  ---
(In reply to Hartmut from comment #6)
> Thank you VERY MUCH Bernhard for your extensive tests and their detailed
> report!
> I installed wine 10.11 on Ubuntu 24.04 and the bug is now gone! I'm very
> happy!

That is great news, nice to hear.
> Because this is my very first bug report for WINE: should I now "close" this
> report? Is this done by editing 'Status' from UNCONFIRMED to RESOLVED? Or
> should better somebody else close this report?

As you reported the bug and if your issues is resolved, you can change the
state to resolved-fixed, if you are convinced it is fixed with the latest
development version.
And because there is a commit known which got identified as fixing the issue,
please put that one in the "Fixed by SHA1" that appears above right,
when changing the state.
In the next wine release the bug will get changed to closed, and usually
appear in the release notes.

[Bug 58437] Total Commander 11.55 complains "Access denied" for EVERY file >= 1 MB in "Compare files by content"

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58437

Hartmut  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |07160a23fa2139c2dc9cad92158
                   |                            |ddf0b64a3e75e
         Resolution|---                         |FIXED

--- Comment #8 from Hartmut  ---
bug was fixed in version wine-10.4 by commit
07160a23fa2139c2dc9cad92158ddf0b64a3e75e

[Bug 58437] Total Commander 11.55 complains "Access denied" for EVERY file >= 1 MB in "Compare files by content"

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58437

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 10.12.