http://bugs.winehq.org/show_bug.cgi?id=20742
Summary: Sorted list view control always inserts at the end Product: Wine Version: 1.1.31 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 AssignedTo: wine-bugs@winehq.org ReportedBy: nakamoto2@users.sourceforge.net
In a sorted list view control, in report mode, InsertItemA always inserts at the end instead of the correctly sorted location.
In my test case, the values being sorted always start with the same character, such as: 0010 0020 0030 0040
If 0025 is inserted, it will be inserted at the end. It doesn't matter if the list is sorted ascending or descending.
I think it's because this line of code is comparing the internal wide-char string with the passed in single-width char string without converting it:
on line 7221 of dlls\comctl32\listview.c cmpv = textcmpWT(item_s->hdr.pszText, lpLVItem->pszText, TRUE);
shouldn't TRUE be changed to isW? cmpv = textcmpWT(item_s->hdr.pszText, lpLVItem->pszText, isW);
It was working correctly in version 1.1.20 and 1.0.1.
http://bugs.winehq.org/show_bug.cgi?id=20742
--- Comment #1 from Satoshi Nakamoto nakamoto2@users.sourceforge.net 2009-11-17 13:21:01 --- Clarification: in my test case, I'm using sort-descending, so I have: "0040" "0030" "0020" "0010"
If I insert "0025" and "0050", I get: "0040" "0030" "0020" "0010" "0025" "0050"
I tried to workaround by changing the values to 10000-x and using sort-ascending, but it still didn't sort right.
http://bugs.winehq.org/show_bug.cgi?id=20742
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
--- Comment #2 from Dmitry Timoshkov dmitry@codeweavers.com 2009-11-17 23:40:19 --- Please post the results of your regression testing: http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=20742
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com 2009-11-19 05:40:30 --- Hi, Satoshi.
Looks like it's mine. Try to revert 2829c5fd1e4d36274031c5e78543b4ec741ba8b2, even manually if it fails in auto. I think you're right about problem anyway, I'll send a patch soon.
http://bugs.winehq.org/show_bug.cgi?id=20742
--- Comment #4 from Nikolay Sivov bunglehead@gmail.com 2009-11-19 06:12:00 --- Patch sent:
http://www.winehq.org/pipermail/wine-patches/2009-November/081618.html
http://bugs.winehq.org/show_bug.cgi?id=20742
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com 2009-11-19 10:42:25 --- This should be fixed by http://source.winehq.org/git/wine.git/?a=commit;h=b0861921b2a4e0c72ad7389b18...
http://bugs.winehq.org/show_bug.cgi?id=20742
--- Comment #6 from Nikolay Sivov bunglehead@gmail.com 2009-11-20 04:17:21 --- Satoshi, could you please retest with current Wine from git or provide a test application for that?
http://bugs.winehq.org/show_bug.cgi?id=20742
--- Comment #7 from Nikolay Sivov bunglehead@gmail.com 2009-12-04 13:27:38 --- Test with 1.1.34 please.
http://bugs.winehq.org/show_bug.cgi?id=20742
Satoshi Nakamoto nakamoto2@users.sourceforge.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #8 from Satoshi Nakamoto nakamoto2@users.sourceforge.net 2009-12-11 17:57:34 --- Tested with 1.1.34 -- fixed, it sorts correctly.
Thanks for all your work on listview!
http://bugs.winehq.org/show_bug.cgi?id=20742
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org 2009-12-18 13:07:57 --- Closing bugs fixed in 1.1.35.
http://bugs.winehq.org/show_bug.cgi?id=20742
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |b0861921b2a4e0c72ad7389b181 | |910f9b4b4e935