[Bug 11424] New: Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Summary: Canon Digital Photo Professional (DPP) pane refresh
           Product: Wine
           Version: 0.9.54.
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The folders pane (the one on the left hand side) doesn't refresh properly. I'm
attaching two screenshots showing the problem under wine and the expected
behavior under windows:

http://download.erasmix.net/DPP-WINE/Screenshot-1.png Shows the problem

http://download.erasmix.net/DPP-WINE/DPP-Windows.png Shows behavior on windows

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #1 from Austin English   2008-02-01 12:00:00 ---
Duplicate.

*** This bug has been marked as a duplicate of bug 11390 ***

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Austin English   2008-02-01 12:00:08 ---
Closing dupe.

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

--- Comment #3 from Erasmo Acosta   2008-05-18 11:34:14 ---
I continue to see garbage on the DPP file pane. If this was a dup of 11390, it
should have been fixed. I'm testing on 1.0-rc1, after removing my .wine
directory. Here is the latest screenshot:

http://download.erasmix.net/DPP-WINE/Screenshot-5.png

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
         Resolution|DUPLICATE                   |

--- Comment #4 from Austin English   2008-05-18 12:54:07 ---
Reopening then.

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Karl Piers  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Karl Piers   2008-05-22 01:47:59 ---
I can confirm that I see this problem with DPP 3.4.1.1 and wine 1.0-rc1 (on
Debian Etch). It's been around for some time, and occurred also for DPP 3.4.1.1
and wine 0.9.25, and also for DPP 3.2 with wine 0.9.25.

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

--- Comment #6 from Karl Piers   2008-05-26 09:52:22 ---
I retested with wine 1.0-rc2 and DPP 3.4.1.1, and the problem still occurs.

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

John Sadler  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from John Sadler   2008-06-02 09:13:53 ---
Bug is present with rc3 too.

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Karl Piers  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #8 from Karl Piers   2008-06-02 10:09:13 ---
*** This bug has been confirmed by popular vote. ***

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

--- Comment #9 from John Sadler   2008-06-07 17:38:13 ---
Bug remains in rc4.

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Sergey  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Sergey   2008-06-14 11:44:11 ---
the same bug in RC5

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Lukas Jirkovsky  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Lukas Jirkovsky   2008-06-18 05:26:02 ---
Confirming with 1.0

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Lukas Jirkovsky  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Lukas Jirkovsky   2008-06-18 05:26:02 ---
Confirming with 1.0

--- Comment #12 from John Sadler   2008-06-28 12:41:40 ---
Still persists in 1.1.0

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Dan Kegel   2008-12-07 11:16:15 ---
Does using native comctl32 work around the problem?
e.g.
  wget http://kegel.com/wine/winetricks
  sh winetricks cc580
?

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

--- Comment #14 from John Sadler   2008-12-13 04:38:53 ---
Created an attachment (id=17889)
 --> (http://bugs.winehq.org/attachment.cgi?id=17889)
DPP folder view with native comctl32

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

--- Comment #15 from John Sadler   2008-12-13 04:40:34 ---

Hey Dan,

That does indeed work! Thanks!

There's still one little glitch, in that the folder icons render with a black
background (see my attachment), but other than that it works very well.

Regards,

John

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |comctl32

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

--- Comment #16 from Austin English   2008-12-13 10:41:36 ---
Please get a +commctrl trace

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

--- Comment #17 from Lei Zhang   2008-12-16 20:52:01 ---
Maybe a treeview problem. I found a Canon DSLR with the CD. :)

BTW, Austin, +commctrl doesn't give any useful info.

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #18 from [e-mail]  2009-05-14 11:02:54 ---
Still here in wine 1.1.21

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

[e-mail]  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from [e-mail]   2009-06-28 04:09:14 ---
Still there in 1.1.24

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

--- Comment #20 from Nikolay Sivov   2009-10-17 06:35:09 ---
Could someone try it again with patch from bug 12572?

http://bugs.winehq.org/attachment.cgi?id=24174

I'm almost sure it's the same problem.

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Gilles Gregoire  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from Gilles Gregoire   2009-10-17 09:02:20 ---
I just tried your patch with DPP 3.6 on two distributions: Jaunty 32 and Hardy
x64

the folder pane now refreshs fine

Gilles

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

--- Comment #22 from Nikolay Sivov   2009-10-17 09:07:04 ---
(In reply to comment #21)
> I just tried your patch with DPP 3.6 on two distributions: Jaunty 32 and Hardy
> x64
>
> the folder pane now refreshs fine
>
> Gilles

Great. Let's make this a main bug for this treeview problem, since there's a
lot of subscribers.

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

--- Comment #23 from Nikolay Sivov   2009-10-17 09:08:55 ---
Created an attachment (id=24198)
 --> (http://bugs.winehq.org/attachment.cgi?id=24198)
treeview background fill fix

Here is an updated version of the same patch.

Problem description:

For subclassed controls (like in this application) it's ok not to forward
WM_ERASEBKGND to original window procedure, instead only WM_PAINT is forwarded
with NULL wParam which leads to BeginPaint/EndPaint sequence. After that
returned PAINTSTRUCT contains not zero fErase field - it means we need to fill
background before making main WM_PAINT painting.

This fact currently is completely ignored for Wine common controls.

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

--- Comment #24 from Nikolay Sivov   2009-10-17 09:10:13 ---
*** Bug 12572 has been marked as a duplicate of this bug. ***

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #25 from Nikolay Sivov   2009-10-19 10:07:52 ---
Fixed by commit:

http://source.winehq.org/git/wine.git/?a=commit;h=76859b0f47ef98eb932cfc220e...

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #26 from Alexandre Julliard   2009-10-23 13:18:21 ---
Closing bugs fixed in 1.1.32.

[Bug 11424] Canon Digital Photo Professional (DPP) pane refresh

http://bugs.winehq.org/show_bug.cgi?id=11424

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |76859b0f47ef98eb932cfc220e5
                   |                            |b1afa81a4f0a3
                 CC|                            |[e-mail]