[Bug 36835] New: Microsoft OneDrive/SkyDrive needs support for Shell32.dll.SHGetKnownFolderPath with 'KNOWNFOLDERID_Links'

https://bugs.winehq.org/show_bug.cgi?id=36835

Bug ID: 36835
           Summary: Microsoft OneDrive/SkyDrive needs support for
                    Shell32.dll.SHGetKnownFolderPath with
                    'KNOWNFOLDERID_Links'
           Product: Wine
           Version: 1.7.21
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: shell32
          Assignee: [e-mail]
          Reporter: [e-mail]

Hello folks,

as the summary says ...

The installer needs WINEPREFIX Windows version set to 'Vista' or later.

--- snip ---
$ WINEDEBUG=+tid,+seh,+relay,+shell wine ./OneDriveSetup.exe >>log2.txt 2>&1
...
0044:Call shell32.SHGetKnownFolderPath(004053e4,00000000,ffffffff,00bee754)
ret=00432f55
0044:trace:shell:SHGetKnownFolderPath {bfb9d5e0-c6a9-404c-b2b2-ae6db6af4968},
0x00000000, 0xffffffff, 0xbee754
0044:trace:shell:SHGetFolderPathAndSubDirW (nil),0xbee4b0,nFolder=0x004d,(null)
0044:trace:shell:_SHGetUserProfilePath 0xffffffff,0x00000000,0x4d,0xbedfc8
0044:trace:shell:_SHGetUserShellFolderPath 0x80000003,L".Default",
...
0044:trace:shell:_SHGetUserShellFolderPath returning 0x80004005
0044:trace:shell:_SHGetUserShellFolderPath 0x80000002,(null),(null),0xbedfc8
0044:Call advapi32.RegCreateKeyW(80000002,7ebfa220
L"Software\Microsoft\Windows\CurrentVersion\Explorer\Shell
Folders",00bedad0) ret=7ebacb12
...
0044:trace:shell:_SHGetUserShellFolderPath returning 0x80004005
...
0044:trace:shell:_SHGetUserProfilePath returning 0x00000000 (output path is
L"%USERPROFILE%\Links")
0044:trace:shell:_SHExpandEnvironmentStrings L"%USERPROFILE%\Links", 0xbee1d0
...
0044:trace:shell:PathCanonicalizeW (0xbee1d0,L"C:\users\focht\Links")
...
0044:trace:shell:_SHExpandEnvironmentStrings returning 0x00000000 (input was
L"%USERPROFILE%\Links", output is L"C:\users\focht\Links")
0044:Call shlwapi.PathFileExistsW(00bee1d0 L"C:\users\focht\Links")
ret=7ebae9eb
0044:trace:shell:PathFileExistsW (L"C:\users\focht\Links")
0044:Call KERNEL32.SetErrorMode(00000001) ret=7eafcd6f
0044:Ret  KERNEL32.SetErrorMode() retval=00000000 ret=7eafcd6f
0044:Call KERNEL32.GetFileAttributesW(00bee1d0 L"C:\users\focht\Links")
ret=7eafcd7f
0044:Ret  KERNEL32.GetFileAttributesW() retval=ffffffff ret=7eafcd7f
0044:Call KERNEL32.SetErrorMode(00000000) ret=7eafcd90
0044:Ret  KERNEL32.SetErrorMode() retval=00000001 ret=7eafcd90
0044:Ret  shlwapi.PathFileExistsW() retval=00000000 ret=7ebae9eb
0044:trace:shell:SHGetFolderPathAndSubDirW returning 0x80070003 (final path is
L"C:\users\focht\Links")
0044:Ret  shell32.SHGetKnownFolderPath() retval=80070002 ret=00432f55
0044:Call KERNEL32.GetLastError() ret=00453265
0044:Ret  KERNEL32.GetLastError() retval=00000002 ret=00453265
...
0044:Call KERNEL32.IsDebuggerPresent() ret=0045482b
0044:Ret  KERNEL32.IsDebuggerPresent() retval=00000000 ret=0045482b
0044:Call KERNEL32.SetUnhandledExceptionFilter(00000000) ret=00454276
0044:Ret  KERNEL32.SetUnhandledExceptionFilter() retval=00452f40 ret=00454276
0044:Call KERNEL32.UnhandledExceptionFilter(00be62b4) ret=0045427f
0044:trace:seh:start_debugger Starting debugger "winedbg --auto 64 208"
0044:Ret  KERNEL32.UnhandledExceptionFilter() retval=00000000 ret=0045427f
0044:Call KERNEL32.TerminateProcess(ffffffff,c0000417) ret=00454264 
--- snip ---

MSDN: http://msdn.microsoft.com/en-us/library/bb762584%28v=VS.85%29.aspx

--- quote ---
FOLDERID_Links

GUID     {bfb9d5e0-c6a9-404c-b2b2-ae6db6af4968}
    Display Name     Links
    Folder Type     PERUSER
    Default Path     %USERPROFILE%\Links
    CSIDL Equivalent     None
    Legacy Display Name     Not applicable
    Legacy Default Path     Not applicable
--- quote ---

Discussion here:

https://stackoverflow.com/questions/16656342/how-to-programmatically-add-a-f...

$ sha1sum OneDriveSetup.exe 
172ea5833afcc53b4876cb8d9849ba122e5e9223  OneDriveSetup.exe

$ du -sh OneDriveSetup.exe 
5.9M    OneDriveSetup.exe

$ wine --version
wine-1.7.21-41-g5af3b8c

Regards

[Bug 36835] Microsoft OneDrive/SkyDrive needs support for Shell32.dll.SHGetKnownFolderPath with 'KNOWNFOLDERID_Links'

https://bugs.winehq.org/show_bug.cgi?id=36835

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://go.microsoft.com/fwl
                   |                            |ink/p/?LinkId=248256

[Bug 36835] Microsoft OneDrive/SkyDrive needs support for Shell32.dll.SHGetKnownFolderPath with 'KNOWNFOLDERID_Links'

http://bugs.winehq.org/show_bug.cgi?id=36835

--- Comment #1 from Stefan Leichter  ---
Created attachment 49007
  --> http://bugs.winehq.org/attachment.cgi?id=49007
SHGetKnownFolderPath fix

Is this patch enough to fix the problem?

[Bug 36835] Microsoft OneDrive/SkyDrive needs support for Shell32.dll.SHGetKnownFolderPath with 'KNOWNFOLDERID_Links'

http://bugs.winehq.org/show_bug.cgi?id=36835

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Sebastian Lackner  ---
Could someone please test if this is also fixed with:

http://source.winehq.org/git/wine.git/patch/e38d1c9aa1ff39d5fae25ec64d895396...

?

[Bug 36835] Microsoft OneDrive/SkyDrive needs support for Shell32.dll.SHGetKnownFolderPath with 'KNOWNFOLDERID_Links'

http://bugs.winehq.org/show_bug.cgi?id=36835

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Installer
      Fixed by SHA1|                            |e38d1c9aa1ff39d5fae25ec64d8
                   |                            |95396afd31835
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Anastasius Focht  ---
Hello folks,

this is fixed by commit
http://source.winehq.org/git/wine.git/commitdiff/e38d1c9aa1ff39d5fae25ec64d8...

Thanks Michael

Next is bug 35375

Regards

[Bug 36835] Microsoft OneDrive/SkyDrive needs support for Shell32.dll.SHGetKnownFolderPath with 'KNOWNFOLDERID_Links'

https://bugs.winehq.org/show_bug.cgi?id=36835

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.24.

[Bug 36835] Microsoft OneDrive/SkyDrive needs support for Shell32.dll.SHGetKnownFolderPath with 'KNOWNFOLDERID_Links'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36835

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://go.microsoft.com/fwl |https://web.archive.org/web
                   |ink/p/?LinkId=248256        |/20140819001912/http://wl.d
                   |                            |lservice.microsoft.com/down
                   |                            |load/3/7/9/379B6693-4308-44
                   |                            |9C-8556-AB1494F184AF/OneDri
                   |                            |veSetup.exe