[Bug 53136] New: crypt32:cert - testVerifyRevocation() fails in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53136

Bug ID: 53136
           Summary: crypt32:cert - testVerifyRevocation() fails in Wine
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: crypt32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

crypt32:cert - testVerifyRevocation() fails in Wine:

cert.c:4177: Test failed: got 80092012
cert.c:4178: Test failed: got 80092012

https://test.winehq.org/data/patterns.html#crypt32:cert

0c80092012 is CRYPT_E_NO_REVOCATION_CHECK.

The failures started on 2022-05-30 and were initially random but are systematic
since 2022-06-07. The actual test was introduced on 2022-05-24 in the commit
below and reverting to that commit produces systematic failures.

So this is not a regression but instead looks like an outside change that broke
the test.

commit 74832c2177808c6222d44f7e4580de84e0ada8f0
Author:     Hans Leidekker 
AuthorDate: Tue May 24 09:46:22 2022 +0200

crypt32/tests: Add more OCSP revocation tests.

Signed-off-by: Hans Leidekker 
    Signed-off-by: Alexandre Julliard

[Bug 53136] crypt32:cert - testVerifyRevocation() fails in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53136

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |source, testcase

[Bug 53136] crypt32:cert - testVerifyRevocation() fails in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53136

--- Comment #1 from Hans Leidekker  ---
(In reply to François Gouget from comment #0)
> crypt32:cert - testVerifyRevocation() fails in Wine:
>
> cert.c:4177: Test failed: got 80092012
> cert.c:4178: Test failed: got 80092012
>
> https://test.winehq.org/data/patterns.html#crypt32:cert
>
> 0c80092012 is CRYPT_E_NO_REVOCATION_CHECK.
>
> The failures started on 2022-05-30 and were initially random but are
> systematic since 2022-06-07. The actual test was introduced on 2022-05-24 in
> the commit below and reverting to that commit produces systematic failures.
>
> So this is not a regression but instead looks like an outside change that
> broke the test.

Right, we get a different response now from ocsp.digicert.org. What's
interesting is that this test doesn't fail on Windows. I verified that we get
the same OCSP response on Windows, which implies that Windows falls back to a
CRL check when this happens.

Making Wine follow this behavior should also fix bug 53138.

[Bug 53136] crypt32:cert - testVerifyRevocation() fails in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53136

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |987d637e31ca087487ef26337ad
                   |                            |081b9de9ca36a
             Status|NEW                         |RESOLVED

--- Comment #2 from Hans Leidekker  ---
Fixed by 987d637e31ca087487ef26337ad081b9de9ca36a.

[Bug 53136] crypt32:cert - testVerifyRevocation() fails in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53136

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 7.11.