[Bug 45156] New: autohotkey can't seem to click buttons any more ( breaking winetricks -q dirac et al)

https://bugs.winehq.org/show_bug.cgi?id=45156

Bug ID: 45156
           Summary: autohotkey can't seem to click buttons any more
                    (breaking winetricks -q dirac et al)
           Product: Wine
           Version: 3.7
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, Installer, regression, source
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 5d10abde503fc4a952c114c658fed74f97bff090
      Distribution: Gentoo

Regression caused by:
commit 5d10abde503fc4a952c114c658fed74f97bff090 (refs/bisect/bad)
Author: Nikolay Sivov 
Date:   Tue Feb 6 08:50:21 2018 +0300

comctl32: Introduce Button control.

Signed-off-by: Nikolay Sivov 
    Signed-off-by: Alexandre Julliard

to reproduce:
wineserver -k ; rm -rf ~/.wine ; WINE=$PWD/wine winetricks -q dirac

Before, winetricks will call autohotkey to click through the installer
After, the installer sits on the first screen and doesn't progress

[Bug 45156] autohotkey can't seem to click buttons any more ( breaking winetricks -q dirac et al)

https://bugs.winehq.org/show_bug.cgi?id=45156

--- Comment #1 from Nikolay Sivov  ---
It looks like class name management issue. For local case we have 'basename' as
a remedy, for CLASS_OTHER_PROCESS case atom name is returned as is -
'6.x.x.x!Button', that obviously breaks lookup logic.

[Bug 45156] autohotkey can't seem to click buttons any more ( breaking winetricks -q dirac et al)

https://bugs.winehq.org/show_bug.cgi?id=45156

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|comctl32                    |user32

[Bug 45156] autohotkey can't seem to click buttons any more ( breaking winetricks -q dirac et al)

https://bugs.winehq.org/show_bug.cgi?id=45156

tokktokk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 45156] autohotkey can't seem to click buttons any more ( breaking winetricks -q dirac et al)

https://bugs.winehq.org/show_bug.cgi?id=45156

--- Comment #2 from Nikolay Sivov  ---
Created attachment 61493
  --> https://bugs.winehq.org/attachment.cgi?id=61493
patch

Hi, Austin.

This one seems to work for me. Could you please test?

[Bug 45156] autohotkey can't seem to click buttons any more ( breaking winetricks -q dirac et al)

https://bugs.winehq.org/show_bug.cgi?id=45156

--- Comment #3 from Austin English  ---
(In reply to Nikolay Sivov from comment #2)
> Created attachment 61493 [details]
> patch
>
> Hi, Austin.
>
> This one seems to work for me. Could you please test?

Fails to build for me (gcc-7.3.0):
make[1]: Entering directory '/home/austin/wine-git/dlls/user32'
gcc -m32 -c -o class.o class.c -I. -I../../include -I/usr/include/libpng16
-D__WINESRC__ -D_USER32_ \
  -D_WINABLE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing
-Wdeclaration-after-statement \
  -Wempty-body -Wignored-qualifiers -Wshift-overflow=2 -Wstrict-prototypes
-Wtype-limits \
  -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op
-gdwarf-2 \
  -gstrict-dwarf -fno-omit-frame-pointer -g -O2 -U_FORTIFY_SOURCE
-D_FORTIFY_SOURCE=0
class.c: In function 'CLASS_RegisterClass':
class.c:490:12: error: 'struct create_class_request' has no member named
'name_offset'
         req->name_offset = basename_offset;
            ^~
In file included from class.c:38:0:
class.c: In function 'GetClassNameW':
class.c:1196:27: error: 'union generic_request' has no member named
'get_class_name_request'; did you mean 'set_class_info_request'?
         SERVER_START_REQ( get_class_name )
                           ^
../../include/wine/server.h:129:58: note: in definition of macro
'SERVER_START_REQ'
         struct type##_request * const req = &__req.u.req.type##_request; \
                                                          ^~~~
class.c:1196:27: error: 'union generic_reply' has no member named
'get_class_name_reply'; did you mean 'set_class_info_reply'?
         SERVER_START_REQ( get_class_name )
                           ^
../../include/wine/server.h:130:66: note: in definition of macro
'SERVER_START_REQ'
         const struct type##_reply * const reply = &__req.u.reply.type##_reply;
\
                                                                  ^~~~
../../include/wine/server.h:132:42: error: 'REQ_get_class_name' undeclared
(first use in this function); did you mean 'REQ_set_class_info'?
         __req.u.req.request_header.req = REQ_##type; \
                                          ^
class.c:1196:9: note: in expansion of macro 'SERVER_START_REQ'
         SERVER_START_REQ( get_class_name )
         ^~~~~~~~~~~~~~~~
../../include/wine/server.h:132:42: note: each undeclared identifier is
reported only once for each function it appears in
         __req.u.req.request_header.req = REQ_##type; \
                                          ^
class.c:1196:9: note: in expansion of macro 'SERVER_START_REQ'
         SERVER_START_REQ( get_class_name )
         ^~~~~~~~~~~~~~~~
class.c:1198:16: error: dereferencing pointer to incomplete type 'struct
get_class_name_request'
             req->handle = wine_server_user_handle( hwnd );
                ^~
make[1]: *** [Makefile:275: class.o] Error 1
make[1]: Leaving directory '/home/austin/wine-git/dlls/user32'
make: *** [Makefile:9551: dlls/user32] Error 2

austin@valgrindbox ~/wine-git $ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/7.3.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with:
/var/tmp/portage/sys-devel/gcc-7.3.0-r1/work/gcc-7.3.0/configure
--host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr
--bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/7.3.0
--includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/7.3.0/include
--datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/7.3.0
--mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/7.3.0/man
--infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/7.3.0/info
--with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/7.3.0/include/g++-v7
--with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/7.3.0/python
--enable-languages=c,c++,go --enable-obsolete --enable-secureplt
--disable-werror --with-system-zlib --disable-nls --enable-checking=yes
--with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo 7.3.0-r1 p1.1'
--disable-esp --enable-libstdcxx-time --disable-libstdcxx-pch --enable-shared
--enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu
--enable-multilib --with-multilib-list=m32,m64 --disable-altivec
--disable-fixed-point --enable-targets=all --disable-libgcj --enable-libgomp
--disable-libmudflap --disable-libssp --disable-libcilkrts --enable-libmpx
--enable-vtable-verify --enable-libvtv --disable-libquadmath --enable-lto
--without-isl --enable-libsanitizer --enable-default-pie --enable-default-ssp
Thread model: posix
gcc version 7.3.0 (Gentoo 7.3.0-r1 p1.1)

[Bug 45156] autohotkey can't seem to click buttons any more ( breaking winetricks -q dirac et al)

https://bugs.winehq.org/show_bug.cgi?id=45156

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #4 from Austin English  ---
Forgot to run ./tools/make_requests; after that, it builds and winetrick -q
steam works again.

[Bug 45156] autohotkey can't seem to click buttons any more ( breaking winetricks -q dirac et al)

https://bugs.winehq.org/show_bug.cgi?id=45156

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Nikolay Sivov  ---
This is fixed now, 7a45d2fa781852d5f1b8c2f8433dd9054ec1797f.

[Bug 45156] autohotkey can't seem to click buttons any more ( breaking winetricks -q dirac et al)

https://bugs.winehq.org/show_bug.cgi?id=45156

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61493|0                           |1
        is obsolete|                            |

[Bug 45156] autohotkey can't seem to click buttons any more ( breaking winetricks -q dirac et al)

https://bugs.winehq.org/show_bug.cgi?id=45156

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |7a45d2fa781852d5f1b8c2f8433
                   |                            |dd9054ec1797f

[Bug 45156] autohotkey can't seem to click buttons any more ( breaking winetricks -q dirac et al)

https://bugs.winehq.org/show_bug.cgi?id=45156

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 3.11.