https://bugs.winehq.org/show_bug.cgi?id=49929
Bug ID: 49929 Summary: winetricks -q gfw fails Product: Wine Version: 5.18 Hardware: x86-64 OS: Linux Status: NEW Keywords: download, Installer, regression, source Severity: normal Priority: P2 Component: msi Assignee: wine-bugs@winehq.org Reporter: austinenglish@gmail.com Distribution: Gentoo
Backtrace: =>0 0x7bc2869c HEAP_CreateFreeBlock+0x12c(subheap=<is not available>, ptr=0x1b77f0, size=<is not available>) [Z:\home\austin\wine-git\include\wine\list.h:101] in ntdll (0x0063f088) 1 0x7bc28816 HEAP_MakeInUseBlockFree+0xa5(subheap=<is not available>, pArena=<is not available>) [Z:\home\austin\wine-git\dlls\ntdll\heap.c:666] in ntdll (0x0063f0c8) 2 0x7bc28a48 HEAP_MakeInUseBlockFree+0x2d7(subheap=<is not available>, pArena=<is not available>) [Z:\home\austin\wine-git\dlls\ntdll\heap.c:1762] in ntdll (0x0063f128) 3 0x6510282a msi_apply_registered_patch+0x889(package=<is not available>, patch_code=<is not available>) [Z:\home\austin\wine-git\dlls\msi\msipriv.h:1272] in msi (0x0063f158) 4 0x65102858 MSI_CloseRecord+0x27() [Z:\home\austin\wine-git\dlls\msi\record.c:73] in msi (0x0063f178) 5 0x650d180c msiobj_unlock+0x5b() [Z:\home\austin\wine-git\dlls\msi\handle.c:258] in msi (0x0063f1a8) 6 0x650a3063 msi_load_assembly+0x532(package=<is not available>, comp=<is not available>) [Z:\home\austin\wine-git\dlls\msi\assembly.c:407] in msi (0x0063f208) 7 0x650888d0 load_component+0xef() [Z:\home\austin\wine-git\dlls\msi\action.c:935] in msi (0x0063f248) 8 0x650f1869 MSI_IterateRecords+0x78() [Z:\home\austin\wine-git\dlls\msi\msiquery.c:185] in msi (0x0063f298) 9 0x650865f9 load_media+0x1288() [Z:\home\austin\wine-git\dlls\msi\action.c:954] in msi (0x0063f2c8) 10 0x65086897 ACTION_CostInitialize+0x1e6() [Z:\home\austin\wine-git\dlls\msi\action.c:1266] in msi (0x0063f308) 11 0x6508befb ACTION_HandleStandardAction+0xda(package=<is not available>, action=<is not available>) [Z:\home\austin\wine-git\dlls\msi\action.c:8051] in msi (0x0063f618) 12 0x6509aa6b ACTION_ValidateProductID+0x3a(package=(nil)) [Z:\home\austin\wine-git\dlls\msi\action.c:8080] in msi (0x0063f658) 13 0x6509ad44 ITERATE_Actions+0x73(row=<is not available>) [Z:\home\austin\wine-git\dlls\msi\action.c:544] in msi (0x0063f698) 14 0x650f1869 MSI_IterateRecords+0x78() [Z:\home\austin\wine-git\dlls\msi\msiquery.c:185] in msi (0x0063f6e8) 15 0x6509b65e ACTION_ExecuteAction+0x5ad(package=<is not available>) [Z:\home\austin\wine-git\dlls\msi\action.c:609] in msi (0x0063f738) 16 0x6509b79a ACTION_ExecuteAction+0x6e9(package=<is not available>) [Z:\home\austin\wine-git\dlls\msi\action.c:5836] in msi (0x0063f768) 17 0x6508befb ACTION_HandleStandardAction+0xda(package=<is not available>, action=<is not available>) [Z:\home\austin\wine-git\dlls\msi\action.c:8051] in msi (0x0063fa78) 18 0x6509aa6b ACTION_ValidateProductID+0x3a(package=0x6514808c) [Z:\home\austin\wine-git\dlls\msi\action.c:8080] in msi (0x0063fab8) 19 0x6509bc9b MSI_InstallPackage+0x32a(package=<is not available>, szPackagePath=<is not available>, szCommandLine=<is not available>) [Z:\home\austin\wine-git\dlls\msi\action.c:8225] in msi (0x0063fb18) 20 0x650e09b6 MsiInstallProductW+0x105() [Z:\home\austin\wine-git\dlls\msi\msi.c:269] in msi (0x0063fb58) 21 0x00403c20 WinMain+0x1daf(hInstance=<is not available>, hPrevInstance=<is not available>, lpCmdLine=<is not available>, nCmdShow=<is not available>) [Z:\home\austin\wine-git\programs\msiexec\msiexec.c:1059] in msiexec (0x0063fe68) 22 0x00406b94 main+0xd3() [Z:\home\austin\wine-git\dlls\msvcrt\crt_winmain.c:53] in msiexec (0x0063fef8) 23 0x00406089 mainCRTStartup+0x68() [Z:\home\austin\wine-git\dlls\msvcrt\crt_main.c:62] in msiexec (0x0063ff30) 24 0x7b653910 in kernel32 (+0x3390f) (0x0063ff48) 25 0x7bc5aa07 RtlSleepConditionVariableSRW+0x176(variable=<is not available>, lock=<is not available>, timeout=<is not available>, flags=<is not available>) [Z:\home\austin\wine-git\dlls\ntdll\sync.c:556] in ntdll (0x0063ff5c) 26 0x7bc5ac30 call_thread_func+0xaf() [Z:\home\austin\wine-git\dlls\ntdll\thread.c:133] in ntdll (0x0063ffec) 0x7bc2869c HEAP_CreateFreeBlock+0x12c [Z:\home\austin\wine-git\include\wine\list.h:101] in ntdll: movl %edi,0x0(%esi) 101 elem->prev->next = elem->next;
wine-5.18
Haven't bisected yet, will try to sometime today.
https://bugs.winehq.org/show_bug.cgi?id=49929
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|source |
https://bugs.winehq.org/show_bug.cgi?id=49929
--- Comment #1 from Austin English austinenglish@gmail.com --- Created attachment 68313 --> https://bugs.winehq.org/attachment.cgi?id=68313 +msi
https://bugs.winehq.org/show_bug.cgi?id=49929
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |c460d4ff35e69052a917a8d75f9 | |7f39d36747e52 CC| |dmitry@baikal.ru
--- Comment #2 from Austin English austinenglish@gmail.com --- austin@laptop ~/wine-git ((no branch, bisect started on master)) $ git bisect good c460d4ff35e69052a917a8d75f97f39d36747e52 is the first bad commit commit c460d4ff35e69052a917a8d75f97f39d36747e52 Author: Dmitry Timoshkov dmitry@baikal.ru Date: Fri Sep 18 12:58:33 2020 +0300
sxs: Return correct path from IAssemblyCache::QueryAssemblyInfo().
Some applications call IAssemblyCache::QueryAssemblyInfo(), then append DLL name to the returned path, and call GetFileAttributes() to check DLL existence.
Signed-off-by: Dmitry Timoshkov dmitry@baikal.ru Signed-off-by: Alexandre Julliard julliard@winehq.org
dlls/sxs/cache.c | 18 ++++++++---------- dlls/sxs/tests/cache.c | 2 ++ 2 files changed, 10 insertions(+), 10 deletions(-)
https://bugs.winehq.org/show_bug.cgi?id=49929
--- Comment #3 from Dmitry Timoshkov dmitry@baikal.ru --- Thanks for the regression test. The following patch should fix the problem: https://www.winehq.org/pipermail/wine-devel/2020-October/174992.html
https://bugs.winehq.org/show_bug.cgi?id=49929
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #4 from Austin English austinenglish@gmail.com --- (In reply to Dmitry Timoshkov from comment #3)
Thanks for the regression test. The following patch should fix the problem: https://www.winehq.org/pipermail/wine-devel/2020-October/174992.html
Yep, works here as well, thanks for the quick fix!
https://bugs.winehq.org/show_bug.cgi?id=49929
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED Fixed by SHA1| |9ba6e5c2ab4c4d113e9d98454af | |cdfd9fc30dbf5
--- Comment #5 from Dmitry Timoshkov dmitry@baikal.ru --- Committed as 9ba6e5c2ab4c4d113e9d98454afcdfd9fc30dbf5.
https://bugs.winehq.org/show_bug.cgi?id=49929
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|winetricks -q gfw fails |Game for Windows Live | |installer fails with | |'winetricks -q gfw'
https://bugs.winehq.org/show_bug.cgi?id=49929
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|msi |sxs
https://bugs.winehq.org/show_bug.cgi?id=49929
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.19.