[Bug 54060] New: Error: junk at end of line, first unrecognized character is `"'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

Bug ID: 54060
           Summary: Error: junk at end of line, first unrecognized
                    character is `"'
           Product: Wine
           Version: 7.21
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: ucrtbase
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 73614
  --> https://bugs.winehq.org/attachment.cgi?id=73614
log.txt

Compiling in distro with:

compiler version 4.8.4
# gcc --version

glibc 2.19
# ldd --version

config line:
configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --with-x
--libdir=/usr/lib32 CFLAGS="-O2 -march=i686 -mtune=i686"

Compile error in wine-7.21

libucrtbase-63899ddc.s: Assembler messages:
libucrtbase-63899ddc.s:2: Error: junk at end of line, first unrecognized
character is `"'
libucrtbase-63899ddc.s:11: Error: junk at end of line, first unrecognized
character is `"'
libucrtbase-63899ddc.s:14: Error: junk at end of line, first unrecognized
character is `"'
winebuild: /usr/bin/i686-w64-mingw32-as failed with status 1
make: *** [dlls/ucrtbase/i386-windows/libucrtbase.a] Error 1

[Bug 54060] Error: junk at end of line, first unrecognized character is `"'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

--- Comment #1 from Nathan Bennett  ---
I get the same compiling error for wine-7.22

[Bug 54060] Compilation fails with gcc 4.8.4 (Error: junk at end of line, first unrecognized character is `"')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Error: junk at end of line, |Compilation fails with gcc
                   |first unrecognized          |4.8.4 (Error: junk at end
                   |character is `"'            |of line, first unrecognized
                   |                            |character is `"')

--- Comment #2 from Fabian Maurer  ---
Is there a reason you use such an old gcc version? And upgrade should fix the
problem.

Though I don't think wine has a compiler requirement, so this should probably
be fixed.

[Bug 54060] Compilation fails with gcc 4.8.4 (Error: junk at end of line, first unrecognized character is `"')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|ucrtbase                    |build-env

--- Comment #3 from Zeb Figura  ---
I think it doesn't like quoted .section names? I can't confirm this easily,
though. Do we need to bother quoting?

[Bug 54060] Compilation fails with gcc 4.8.4 (Error: junk at end of line, first unrecognized character is `"')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

--- Comment #4 from Zeb Figura  ---
For reference, I *assume* this is the kind of file it's choking on:

whatsit@camazotz:~/git/wine32$ less libucrtbase-63ad2344.s

.section ".idata$2"
        .globl ___wine_import_ucrtbase_desc
___wine_import_ucrtbase_desc:
        .rva .L__wine_import_names
        .long 0
        .long 0
        .rva ___wine_import_ucrtbase_name
        .rva .L__wine_import_addrs

.section ".idata$4"
.L__wine_import_names:

.section ".idata$5"
.L__wine_import_addrs:

[Bug 54060] Compilation fails with gcc 4.8.4 (Error: junk at end of line, first unrecognized character is `"')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

--- Comment #5 from Nathan Bennett  ---
my attempt at bisecting:

# git clone git://source.winehq.org/git/wine.git wine-git/
# cd wine-git/

# git bisect start
# git bisect good wine-7.20
# git bisect bad wine-7.21

# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc
--localstatedir=/var --with-x --libdir=/usr/lib32 CFLAGS="-O2 -march=i686
-mtune=i686" --verbose --disable-tests && make
# git bisect good

# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc
--localstatedir=/var --with-x --libdir=/usr/lib32 CFLAGS="-O2 -march=i686
-mtune=i686" --verbose --disable-tests && make
# git bisect bad

# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc
--localstatedir=/var --with-x --libdir=/usr/lib32 CFLAGS="-O2 -march=i686
-mtune=i686" --verbose --disable-tests && make
# git bisect good

# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc
--localstatedir=/var --with-x --libdir=/usr/lib32 CFLAGS="-O2 -march=i686
-mtune=i686" --verbose --disable-tests && make
# git bisect bad

# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc
--localstatedir=/var --with-x --libdir=/usr/lib32 CFLAGS="-O2 -march=i686
-mtune=i686" --verbose --disable-tests && make
# git bisect good

# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc
--localstatedir=/var --with-x --libdir=/usr/lib32 CFLAGS="-O2 -march=i686
-mtune=i686" --verbose --disable-tests && make
# git bisect good

# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc
--localstatedir=/var --with-x --libdir=/usr/lib32 CFLAGS="-O2 -march=i686
-mtune=i686" --verbose --disable-tests && make
# git bisect bad

# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc
--localstatedir=/var --with-x --libdir=/usr/lib32 CFLAGS="-O2 -march=i686
-mtune=i686" --verbose --disable-tests && make
# git bisect bad

# CC="gcc -m32" ./configure --prefix=/usr --sysconfdir=/etc
--localstatedir=/var --with-x --libdir=/usr/lib32 CFLAGS="-O2 -march=i686
-mtune=i686" --verbose --disable-tests && make
# git bisect bad
103eb831564decc9812239f454ed1cc40714c0a1 is the first bad commit
commit 103eb831564decc9812239f454ed1cc40714c0a1
Author: Rémi Bernon 
Date:   Wed Oct 12 11:57:26 2022 +0200

winebuild: Implement import lib generation without dlltool.

:040000 040000 110a3c78f90970299de4c2342297e1d248892bfc
0ba2fa3df68a65e58ee8ac9aa89b16dc21d9ccc7 M    tools

[Bug 54060] Compilation fails with gcc 4.8.4 (Error: junk at end of line, first unrecognized character is `"')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
                 CC|                            |[e-mail]

[Bug 54060] Compilation fails with gcc 4.8.4 (Error: junk at end of line, first unrecognized character is `"')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

--- Comment #6 from Alexandre Julliard  ---
Hopefully fixed by 4b59142f34bbc19b67786c5c4cf29af55487ae03, please retest.

[Bug 54060] Compilation fails with gcc 4.8.4 (Error: junk at end of line, first unrecognized character is `"')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

--- Comment #7 from Nathan Bennett  ---
(In reply to Alexandre Julliard from comment #6)

Using that patch on wine-7.21:

# patch -p1 < patch.diff
patching file tools/winebuild/import.c
Hunk #1 succeeded at 1733 (offset -31 lines).
Hunk #2 succeeded at 1754 (offset -31 lines).
Hunk #3 succeeded at 1768 (offset -31 lines).
Hunk #4 FAILED at 1891.
Hunk #5 succeeded at 1889 (offset -14 lines).
1 out of 5 hunks FAILED -- saving rejects to file tools/winebuild/import.c.rej

---------------------
contents of wine-7.21/tools/winebuild/import.c.rej :

--- tools/winebuild/import.c
+++ tools/winebuild/import.c
@@ -1891,10 +1891,10 @@
                 break;
             }

-            output( "\n\t.section ".idata$4"\n" );
+            output( "\n\t.section .idata$4\n" );
             output_thunk_rva( by_name ? -1 : odp->ordinal,
".L__wine_import_name" );

-            output( "\n\t.section ".idata$5"\n" );
+            output( "\n\t.section .idata$5\n" );
             output( "%s\n", asm_globl( imp_name ) );
             if (is_delay)
                 output( "\t%s .L__wine_delay_import\n", get_asm_ptr_keyword()
);

---------------------
attempting to compile results in what appears to be same original error.

[Bug 54060] Compilation fails with gcc 4.8.4 (Error: junk at end of line, first unrecognized character is `"')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

--- Comment #8 from Alexandre Julliard  ---
The patch didn't apply cleanly, so it would still be broken. Please retest with
8.0-rc1.

[Bug 54060] Compilation fails with gcc 4.8.4 (Error: junk at end of line, first unrecognized character is `"')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

--- Comment #9 from Nathan Bennett  ---
(In reply to Alexandre Julliard from comment #8)
Attempting to compile 8.0-rc1 results in a different compilation fail:
https://bugs.winehq.org/show_bug.cgi?id=54166

[Bug 54060] Compilation fails with gcc 4.8.4 (Error: junk at end of line, first unrecognized character is `"')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |4b59142f34bbc19b67786c5c4cf
                   |                            |29af55487ae03

--- Comment #10 from Alexandre Julliard  ---
OK thanks, marking this one fixed then.

[Bug 54060] Compilation fails with gcc 4.8.4 (Error: junk at end of line, first unrecognized character is `"')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54060

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  ---
Closing bugs fixed in 8.0-rc2.