[Bug 23021] New: Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

Summary: Spider black suits fail to display
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Sorry, but my wife really likes MS Spider.  So, I have been using it for
several years under Wine.  Now, with the latest Ubuntu release (10.04) and the
latest Wine from the repository, the black suite's spade, clubs, do not
display.  I am running the proprietary nvidia driver.  Also, over the last two
years, the general performance has slowed down.  When you select a new block of
cards to be put into the stacks, it just grinds until all the cards are moved
around.

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.2-rc2
              Alias|Spider                      |

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

--- Comment #1 from Austin English   2010-06-03 11:15:36 ---
Please run a regression test:
http://wiki.winehq.org/RegressionTesting

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

--- Comment #2 from Rob   2010-06-03 18:45:15 ---
ok, tested this problem on a Gateway with wine version 1.1.42 and the black
cards showed up ok.  Then upgraded to 1.2-rc2 and the same problem i.e. the
black suites did not display correctly and the card movement was very slow.
Rob

Athlon64 with ATI readeon card.

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

--- Comment #3 from Rob   2010-06-03 19:02:24 ---
deleted the old .wine directory and let wine recreate it.  Interesting, the
speed picked up quite a bit.  However, the dark suites still do not show up.

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail],
                   |                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #4 from Rosanne DiMesio   2010-06-03 23:37:51 ---
Confirming for the black suits not displaying properly. The cards are solid
black until clicked, which turns them transparent.

Regression test results:

636e35d8ada49883fc16de3700a006f7daad6441 is first bad commit
commit 636e35d8ada49883fc16de3700a006f7daad6441
Author: Wolfram Sang 
Date:   Mon May 17 04:57:36 2010 +0200

user32: Apply sanity-check in BITMAP_Load.

:040000 040000 6f7cff774c27a6f78b70fa3e9482f73ac60ce80d
e3573e2417a049b96d3e4fa4444071aeb54d7941 M      dlls

The patch wouldn't revert cleanly; I got the following message when I tried:
Hunk #1 FAILED at 2421.
Hunk #2 succeeded at 2297 (offset -193 lines).

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

--- Comment #5 from Rosanne DiMesio   2010-06-03 23:39:38 ---
Created an attachment (id=28548)
 --> (http://bugs.winehq.org/attachment.cgi?id=28548)
Screenshot

Attaching a screenshot showing the problem.

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

--- Comment #6 from Wolfram Sang   2010-06-04 03:49:45 ---
Created an attachment (id=28549)
 --> (http://bugs.winehq.org/attachment.cgi?id=28549)
First take on the problem

Bah, regression without download possibility, bad luck :(

Can you try if this patch helps and if it produces "Strange Bitmap" fixmes?

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

--- Comment #7 from Rosanne DiMesio   2010-06-04 10:08:39 ---
The patch fixes it. It produces lots of BITMAP_Load Strange Bitmap fixmes.

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

--- Comment #8 from Wolfram Sang   2010-06-04 18:28:32 ---
Can you post them?

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

--- Comment #9 from Rosanne DiMesio   2010-06-04 19:14:37 ---
Created an attachment (id=28565)
 --> (http://bugs.winehq.org/attachment.cgi?id=28565)
Log from one hand of spider solitaire

Attaching console log from starting game, dealing one hand.

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

Wolfram Sang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28549|0                           |1
        is obsolete|                            |

--- Comment #10 from Wolfram Sang   2010-06-04 23:02:29 ---
Created an attachment (id=28570)
 --> (http://bugs.winehq.org/attachment.cgi?id=28570)
Proper solution, take #1

Thanks for the notification and additional support. I found a mistake doing the
sanity checks and sent the attached patch also to wine-patches. Let's wait for
the review.

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

--- Comment #11 from Rob   2010-06-05 16:25:40 ---
I appreciate the quick effort by the folks who support wine.  For what its
worth,  uninstalled the release candidate and reinstalled 1.1.38.  The
performance is once again very good and yes the black suits show.  I will stay
with this release until a new update is available.  Will this fix get into the
1.2 release?

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

--- Comment #12 from Rosanne DiMesio   2010-06-06 07:00:35 ---
The "proper solution" patch works, and there are no Strange Bitmap fixmes.

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Rosanne DiMesio   2010-06-07 14:35:33 ---
The patch was committed. Fixed in wine-1.2-rc2-197-ge1fd439.

[Bug 23021] Spider black suits fail to display

http://bugs.winehq.org/show_bug.cgi?id=23021

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard   2010-06-11 12:53:19 ---
Closing bugs fixed in 1.2-rc3.

[Bug 23021] Spider black suits fail to display

https://bugs.winehq.org/show_bug.cgi?id=23021

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |0dfedd50c38356c8049aef48e69
                   |                            |b630204de0f79
                 CC|                            |[e-mail]
          Component|-unknown                    |user32
    Regression SHA1|                            |636e35d8ada49883fc16de3700a
                   |                            |006f7daad6441