[Bug 55219] New: Sample() method fails to compile for ps_2_0

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55219

Bug ID: 55219
           Summary: Sample() method fails to compile for ps_2_0
           Product: vkd3d
           Version: 1.8
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: hlsl
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 74833
  --> https://bugs.winehq.org/attachment.cgi?id=74833
test

Extracted from existing d3dcompiler tests:

---
  1 sampler s;
  2 Texture2D t;
  3 float4 main() : COLOR
  4 {
  5     return t.Sample(s, float2(0.5, 0.5));
  6 }
---

This fails to compile currently, on Windows this produces (combined?) s+t
definition at s0.

[Bug 55219] Sample() method fails to compile for ps_2_0

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55219

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical

[Bug 55219] Sample() method fails to compile for ps_2_0

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55219

yan12125  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from yan12125  ---
I'd like to see if I can help on this issue to unblock vkd3d 1.8 in wine [1].
Am I looking at the correct error?
```
$ ./vkd3d-compiler -p ps_2_0 ../55219.hlsl -b d3dbc -o /dev/null
vkd3d-compiler: libs/vkd3d-shader/d3dbc.c:2037: write_sm1_sampler_dcls:
Assertion `sampler_dim != HLSL_SAMPLER_DIM_GENERIC' failed.
zsh: IOT instruction (core dumped)  ./vkd3d-compiler -p ps_2_0 ../55219.hlsl -b
d3dbc -o /dev/null
```

[1] https://gitlab.winehq.org/wine/wine/-/merge_requests/3172

[Bug 55219] Sample() method fails to compile for ps_2_0

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55219

--- Comment #2 from Nikolay Sivov  ---
Assert is now removed with
https://source.winehq.org/git/vkd3d.git/commit/1bd873fb2b887d6b4a21d0f009374....
Compilation will still fail of course, but without a crash.

[Bug 55219] Sample() method fails to compile for ps_2_0

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55219

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |3a6bf3be24a47c53e99609c796c
                   |                            |8e0c2bf0b037b
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Nikolay Sivov  ---
This appears to be implemented now, with
3a6bf3be24a47c53e99609c796c8e0c2bf0b037b.

[Bug 55219] Sample() method fails to compile for ps_2_0

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55219

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Nikolay Sivov  ---
Fixed with vkd3d 1.15.