http://bugs.winehq.org/show_bug.cgi?id=21519
Summary: Mass Effect 2 crashes after start Product: Wine Version: 1.1.37 Platform: x86 URL: http://masseffect.bioware.com OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d AssignedTo: wine-bugs@winehq.org ReportedBy: andras@csevego.net CC: hverbeet@gmail.com
Created an attachment (id=25919) --> (http://bugs.winehq.org/attachment.cgi?id=25919) output without any extended debug option
If you start Mass Effect 2, it will crash with newest wine. It's a regression, because somebody reported, it is working with version 1.1.21 of wine. I did a bisect, that shows the problematic commit is:
-- author Henri Verbeet hverbeet@codeweavers.com Thu, 11 Jun 2009 08:24:30 +0000 (10:24 +0200) committer Alexandre Julliard julliard@winehq.org Thu, 11 Jun 2009 09:53:55 +0000 (11:53 +0200) commit 5fbf895da683c21a89ad6a5e1433279c241b564f tree 6b606159d92bb69e8c186440d4e6d1f63f592c31 tree | snapshot parent da12ac05a4a5fe857fa317fbdbbb2ccce12b838a commit | diff
wined3d: Use the format info to calculate compressed surface pitch in IWineD3DBaseSurfaceImpl_GetPitch(). --
I reverted this patch manually, and game started. I can confirm the problem is the new pitch calculation.
CCing Henri Verbeet.
http://bugs.winehq.org/show_bug.cgi?id=21519
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=21519
--- Comment #1 from Henri Verbeet hverbeet@gmail.com 2010-01-29 05:54:47 --- Could you attach a +d3d,+d3d_surface log?
http://bugs.winehq.org/show_bug.cgi?id=21519
--- Comment #2 from Andras Kovacs andras@csevego.net 2010-01-29 06:55:39 --- Created an attachment (id=25938) --> (http://bugs.winehq.org/attachment.cgi?id=25938) +d3d, +d3d_surface trace
http://bugs.winehq.org/show_bug.cgi?id=21519
--- Comment #3 from Henri Verbeet hverbeet@gmail.com 2010-01-29 11:27:04 --- It seems to be using ATI2N, which was previously not handled as a compressed format. As far as I can see the reported pitch of 512 is correct for a 128x128 texture of that format though.
http://bugs.winehq.org/show_bug.cgi?id=21519
knipl@in.tum.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |knipl@in.tum.de
http://bugs.winehq.org/show_bug.cgi?id=21519
Cuchac cuchac@email.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cuchac@email.cz
--- Comment #4 from Cuchac cuchac@email.cz 2010-02-02 15:18:18 --- Same here. ME2 crashes and after reverting the commit everything is smooth.
I've compared return values of IWineD3DBaseSurfaceImpl_GetPitch() before and after patch and the results are the same (until the crash). I can't see why it is page-faulting.
http://bugs.winehq.org/show_bug.cgi?id=21519
Zdeněk Kopřivík zdenek.koprivik@post.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #5 from Zdeněk Kopřivík zdenek.koprivik@post.cz 2010-02-02 15:19:14 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=21519
--- Comment #6 from Cuchac cuchac@email.cz 2010-02-02 16:45:50 --- Created an attachment (id=26032) --> (http://bugs.winehq.org/attachment.cgi?id=26032) Revert commit 5fbf895da683c21a89ad6a5e1433279c241b564f
http://bugs.winehq.org/show_bug.cgi?id=21519
jonathan strander mblackwell1024@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mblackwell1024@gmail.com
--- Comment #7 from jonathan strander mblackwell1024@gmail.com 2010-02-02 22:26:43 --- (In reply to comment #6)
Created an attachment (id=26032)
--> (http://bugs.winehq.org/attachment.cgi?id=26032) [details]
Revert commit 5fbf895da683c21a89ad6a5e1433279c241b564f
Using the above patch with v1.1.37 causes numerous graphical artifacts. v1.1.22 doesn't have them.
http://bugs.winehq.org/show_bug.cgi?id=21519
--- Comment #8 from jonathan strander mblackwell1024@gmail.com 2010-02-06 17:38:09 --- (In reply to comment #7)
(In reply to comment #6)
Created an attachment (id=26032)
--> (http://bugs.winehq.org/attachment.cgi?id=26032) [details] [details]
Revert commit 5fbf895da683c21a89ad6a5e1433279c241b564f
Using the above patch with v1.1.37 causes numerous graphical artifacts. v1.1.22 doesn't have them.
Here's an example of the graphical glitches present using a patched v1.1.37.
http://mb.mirage.org/bugzilla/me2screenshot1.png http://mb.mirage.org/bugzilla/me2screenshot2.png http://mb.mirage.org/bugzilla/me2screenshot3.png
As you can see, textures have those odd patches, and the lighting on character models (the player especially) is oddly blocky. Additionally, lights that are out of view in relation to the camera flicker out, causing the world to be dark.
http://bugs.winehq.org/show_bug.cgi?id=21519
--- Comment #9 from jonathan strander mblackwell1024@gmail.com 2010-02-08 09:10:15 --- (In reply to comment #8)
(In reply to comment #7)
(In reply to comment #6)
Created an attachment (id=26032)
--> (http://bugs.winehq.org/attachment.cgi?id=26032) [details] [details] [details]
Revert commit 5fbf895da683c21a89ad6a5e1433279c241b564f
Using the above patch with v1.1.37 causes numerous graphical artifacts. v1.1.22 doesn't have them.
Here's an example of the graphical glitches present using a patched v1.1.37.
http://mb.mirage.org/bugzilla/me2screenshot1.png http://mb.mirage.org/bugzilla/me2screenshot2.png http://mb.mirage.org/bugzilla/me2screenshot3.png
As you can see, textures have those odd patches, and the lighting on character models (the player especially) is oddly blocky. Additionally, lights that are out of view in relation to the camera flicker out, causing the world to be dark.
Scratch that. Updating the NVIDIA Binary driver from 195.30 to 195.36.03 fixed this in v1.1.38 (where it was still present), meaning it is unrelated.
http://bugs.winehq.org/show_bug.cgi?id=21519
Ričardas Barkauskas miegalius@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |miegalius@gmail.com
--- Comment #10 from Ričardas Barkauskas miegalius@gmail.com 2010-02-19 19:56:23 --- Just sent test for ATI2N behavior (d3d9/tests: Added test for ATI2N locking offset) and possible fix (wined3d: Fix calculation of pitch for ATI2N format). Not sure if it should and if so how it could be made nicer.
On Windows 7 (and most likely others) ATI2N pitch/locking offset calculations are not the same as for DXT formats, but follows normal surface calculations. This was the reason offending patch caused problems.
http://bugs.winehq.org/show_bug.cgi?id=21519
--- Comment #11 from Ričardas Barkauskas miegalius@gmail.com 2010-03-16 14:03:38 --- Fix is in today's git. Try if it works (it does for me).
http://bugs.winehq.org/show_bug.cgi?id=21519
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|hverbeet@gmail.com |
http://bugs.winehq.org/show_bug.cgi?id=21519
Xavier Vachon xvachon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xvachon@gmail.com
--- Comment #12 from Xavier Vachon xvachon@gmail.com 2010-04-20 17:05:45 --- Confirming, in current git (1.1.43) I am able to launch Mass Effect 2 and start a game.
http://bugs.winehq.org/show_bug.cgi?id=21519
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #13 from Jeff Zaroyko jeffz@jeffz.name 2010-04-20 18:02:55 --- Reported fixed.
http://bugs.winehq.org/show_bug.cgi?id=21519
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Alexandre Julliard julliard@winehq.org 2010-05-07 13:29:54 --- Closing bugs fixed in 1.1.44.
-
wine-bugs＠winehq.org