[Bug 38726] New: valgrind shows uninitialized memory in qcap/tests/smartteefilter.c

https://bugs.winehq.org/show_bug.cgi?id=38726

Bug ID: 38726
           Summary: valgrind shows uninitialized memory in
                    qcap/tests/smartteefilter.c
           Product: Wine
           Version: 1.7.44
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase, valgrind
          Severity: normal
          Priority: P2
         Component: quartz
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Fedora

==2035== Conditional jump or move depends on uninitialised value(s)
==2035==    at 0x5FEF54F: QualityControlRender_DoQOS (qualitycontrol.c:214)
==2035==    by 0x5FE6F18: BaseRendererImpl_Receive (renderer.c:411)
==2035==    by 0x5FE670E: BaseRenderer_Receive (renderer.c:222)
==2035==    by 0x5FE280C: MemInputPin_Receive (pin.c:1122)
==2035==    by 0x5FE28DE: IMemInputPin_Receive (strmif.h:3395)
==2035==    by 0x5FE28DE: MemInputPin_ReceiveMultiple (???:0)
==2035==    by 0x47A39D0: IMemInputPin_ReceiveMultiple (strmif.h:3398)
==2035==    by 0x47A39D0: SinkMemInputPin_ReceiveMultiple (???:0)
==2035==    by 0x47A3856: IMemInputPin_ReceiveMultiple (strmif.h:3398)
==2035==    by 0x47A3856: SinkMemInputPin_Receive (???:0)
==2035==    by 0x5F10141: IMemInputPin_Receive (strmif.h:3395)
==2035==    by 0x5F10141: BaseOutputPinImpl_Deliver (???:0)
==2035==    by 0x5F05B6A: SmartTeeFilterInput_Receive (smartteefilter.c:436)
==2035==    by 0x5F11A8F: MemInputPin_Receive (pin.c:1122)
==2035==    by 0x47A4224: IMemInputPin_Receive (strmif.h:3395)
==2035==    by 0x47A4224: media_thread (???:0)
==2035==    by 0x7BC81BB7: ??? (signal_i386.c:2682)
==2035==    by 0x7BC81BFE: call_thread_func (signal_i386.c:2741)
==2035==    by 0x7BC81B95: ??? (signal_i386.c:2682)
==2035==    by 0x7BC88D78: start_thread (thread.c:443)
==2035==    by 0x4F88F37F: start_thread (in /usr/lib/libpthread-2.21.so)
==2035==    by 0x4F7ABD4D: clone (in /usr/lib/libc-2.21.so)
==2035==  Uninitialised value was created by a client request
==2035==    at 0x7BC4A7FD: mark_block_uninitialized (heap.c:208)
==2035==    by 0x7BC4A952: initialize_block (heap.c:239)
==2035==    by 0x7BC4ECB4: RtlAllocateHeap (heap.c:1716)
==2035==    by 0x5FEEA65: QualityControlImpl_Create (qualitycontrol.c:41)
==2035==    by 0x5FE68AC: BaseRenderer_Init (renderer.c:271)
==2035==    by 0x5F7CE5B: NullRenderer_create (nullrenderer.c:243)
==2035==    by 0x5F767F4: DSCF_CreateInstance (main.c:133)
==2035==    by 0x4C707E4: IClassFactory_CreateInstance (unknwn.h:226)
==2035==    by 0x4C707E4: CoCreateInstance (???:0)
==2035==    by 0x47A3ACA: create_SinkFilter (smartteefilter.c:578)
==2035==    by 0x47A64D4: test_smart_tee_filter_in_graph
(smartteefilter.c:1555)
==2035==    by 0x47A808B: test_smart_tee_filter (smartteefilter.c:1786)
==2035==    by 0x47A9097: func_smartteefilter (smartteefilter.c:2028)
==2035==    by 0x47A9EC5: run_test (test.h:584)
==2035==    by 0x47AA30D: main (test.h:666)
==2035==

[Bug 38726] valgrind shows uninitialized memory in qcap/tests/smartteefilter.c

https://bugs.winehq.org/show_bug.cgi?id=38726

--- Comment #1 from Nikolay Sivov  ---
Looks like it happens because current_rstart and current_rstop are not
initialized  on QOS instance creation.

[Bug 38726] valgrind shows uninitialized memory in qcap/tests/ smartteefilter.c

https://bugs.winehq.org/show_bug.cgi?id=38726

--- Comment #2 from Nikolay Sivov  ---
I believe this should be fixed with
http://source.winehq.org/git/wine.git/?a=commit;h=97fea6d80e043b5411c82cbc0b....
Please retest.

[Bug 38726] valgrind shows uninitialized memory in qcap/tests/ smartteefilter.c

https://bugs.winehq.org/show_bug.cgi?id=38726

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |97fea6d80e043b5411c82cbc0b5
                   |                            |3d236e4d6532e

--- Comment #3 from Nikolay Sivov  ---
I tried with this commit and without, it's fixed.

[Bug 38726] valgrind shows uninitialized memory in qcap/tests/ smartteefilter.c

https://bugs.winehq.org/show_bug.cgi?id=38726

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.17.