[Bug 29821] New: Notepad++: closed tabs aren't properly cleared

http://bugs.winehq.org/show_bug.cgi?id=29821

Bug #: 29821
           Summary: Notepad++: closed tabs aren't properly cleared
           Product: Wine
           Version: 1.4-rc2
          Platform: x86
               URL: http://notepad-plus-plus.org/
        OS/Version: Linux
            Status: NEW
          Keywords: download, source
          Severity: minor
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified

Created attachment 38731
  --> http://bugs.winehq.org/attachment.cgi?id=38731
screenshot

Using Noteapd++ 5.9.3 (doubt it matters though) as my dogfood text editor.
Noticed this today with several files open. To reproduce, open notepad++, and
make several files. Close the first one in the list. The other entries shift to
the left, but the artifacting from the last in the list isn't cleared, causing
a ghost effect.

Native comctl32 works around it. Not sure what logs would be useful, nothing
shows in terminal.

It's a pretty small download, around 8 MB, so shouldn't be hard to test. But if
you'd prefer logs, let me know.

[Bug 29821] Notepad++: closed tabs aren't properly cleared

http://bugs.winehq.org/show_bug.cgi?id=29821

--- Comment #1 from Nikolay Sivov  2012-02-07 01:21:19 CST ---
Is it a regression?

[Bug 29821] Notepad++: closed tabs aren't properly cleared

http://bugs.winehq.org/show_bug.cgi?id=29821

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |82258f4f2580a591d7a9940204b
                   |                            |194b7f833c09d

--- Comment #2 from Austin English  2012-02-07 14:16:57 CST ---
I hadn't really noticed, but testing old wine shows it is.

austin@aw25 ~/wine-git $ git bisect bad
82258f4f2580a591d7a9940204b194b7f833c09d is the first bad commit
commit 82258f4f2580a591d7a9940204b194b7f833c09d
Author: Nikolay Sivov 
Date:   Sat Apr 9 19:46:59 2011 +0400

comctl32/tab: Use dpa to store item data.

:040000 040000 a3b729820b1b9d662125e4fada10af517f3edf1a
a08ba3115d11b06c74f8da69dc1d3a74adc9f8ad M    dlls

[Bug 29821] Notepad++: closed tabs aren't properly cleared

http://bugs.winehq.org/show_bug.cgi?id=29821

--- Comment #3 from Nikolay Sivov  2012-02-08 01:09:56 CST ---
Okay, I can see this. Only happens when you're closing first of two tabs, with
more then 2 tabs it works fine.

[Bug 29821] Notepad++: closed tabs aren't properly cleared

http://bugs.winehq.org/show_bug.cgi?id=29821

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |b32b969eb6d13a60f59b9052807
                   |                            |d372a8bd448f7
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Austin English  2012-02-08 18:00:32 CST ---
http://source.winehq.org/git/wine.git/commitdiff/b32b969eb6d13a60f59b9052807...

Thanks Nikolay!

[Bug 29821] Notepad++: closed tabs aren't properly cleared

http://bugs.winehq.org/show_bug.cgi?id=29821

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2012-02-11 13:53:05 CST ---
Closing bugs fixed in 1.4-rc3.