[Bug 36094] New: advapi32/security test uses an unitialized variable in test_CreateDirectoryA

https://bugs.winehq.org/show_bug.cgi?id=36094

Bug ID: 36094
           Summary: advapi32/security test uses an unitialized variable in
                    test_CreateDirectoryA
           Product: Wine
           Version: 1.3.13
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: minor
          Priority: P2
         Component: advapi32
          Assignee: [e-mail]
          Reporter: [e-mail]

==7325== Syscall param writev(vector[...]) points to uninitialised byte(s)
==7325==    at 0x4E9528CC: writev (in /usr/lib/libc-2.18.so)
==7325==    by 0x7BC7FDBF: send_request (server.c:213)
==7325==    by 0x7BC7FF51: wine_server_call (server.c:294)
==7325==    by 0x7BC44D67: FILE_CreateFile (file.c:185)
==7325==    by 0x7BC44FB8: NtCreateFile (file.c:279)
==7325==    by 0x7B860841: CreateDirectoryW (path.c:1531)
==7325==    by 0x7B8608F0: CreateDirectoryA (path.c:1555)
==7325==    by 0x497D484: test_CreateDirectoryA (security.c:3085)
==7325==    by 0x498A469: func_security (security.c:5423)
==7325==    by 0x4999ED4: run_test (test.h:584)
==7325==    by 0x499A2C3: main (test.h:654)
==7325==  Address 0x472dcf8 is 88 bytes inside a block of size 120 alloc'd
==7325==    at 0x7BC4C735: notify_alloc (heap.c:255)
==7325==    by 0x7BC50F79: RtlAllocateHeap (heap.c:1716)
==7325==    by 0x7BC884F6: NTDLL_create_struct_sd (sync.c:118)
==7325==    by 0x7BC44C62: FILE_CreateFile (file.c:167)
==7325==    by 0x7BC44FB8: NtCreateFile (file.c:279)
==7325==    by 0x7B860841: CreateDirectoryW (path.c:1531)
==7325==    by 0x7B8608F0: CreateDirectoryA (path.c:1555)
==7325==    by 0x497D484: test_CreateDirectoryA (security.c:3085)
==7325==    by 0x498A469: func_security (security.c:5423)
==7325==    by 0x4999ED4: run_test (test.h:584)
==7325==    by 0x499A2C3: main (test.h:654)
==7325==  Uninitialised value was created by a client request
==7325==    at 0x7BC4C52C: mark_block_uninitialized (heap.c:209)
==7325==    by 0x7BC4C697: initialize_block (heap.c:240)
==7325==    by 0x7BC50FA3: RtlAllocateHeap (heap.c:1717)
==7325==    by 0x497D2A5: test_CreateDirectoryA (security.c:3067)
==7325==    by 0x498A469: func_security (security.c:5423)
==7325==    by 0x4999ED4: run_test (test.h:584)
==7325==    by 0x499A2C3: main (test.h:654)
==7325==

[Bug 36094] advapi32/security test uses an unitialized variable in test_CreateDirectoryA

https://bugs.winehq.org/show_bug.cgi?id=36094

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.13                      |1.7.17

[Bug 36094] advapi32/security test uses an unitialized variable in test_CreateDirectoryA

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36094

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from joaopa  ---
Created attachment 67720
  --> https://bugs.winehq.org/attachment.cgi?id=67720
consoe output with valgrind --trace-children=yes --leak-check=full
--show-leak-kinds=all

Looks like this bug is fixed in wine-5.12
Can an administrator close this bug as FIXED?

[Bug 36094] advapi32/security test uses an unitialized variable in test_CreateDirectoryA

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36094

--- Comment #2 from Austin English  ---
I get a different but somewhat similar error:
../../../tools/runtest -q -P wine -T ../../.. -M advapi32.dll -p
advapi32_test.exe.so security && touch security.ok
preloader: Warning: failed to reserve range 00110000-68000000
preloader: Warning: failed to reserve range 7f000000-82000000
==15419== Syscall param writev(vector[...]) points to uninitialised byte(s)
==15419==    at 0x4350DC7: writev (writev.c:26)
==15419==    by 0x487B322: send_request (server.c:213)
==15419==    by 0x487C094: server_call_unlocked (server.c:273)
==15419==    by 0x48928D7: virtual_locked_server_call (virtual.c:3011)
==15419==    by 0x4869E85: server_ioctl_file (file.c:4732)
==15419==    by 0x486D515: NtDeviceIoControlFile (file.c:5563)
==15419==    by 0x486D5EB: get_mountmgr_fs_info (file.c:1975)
==15419==    by 0x487036A: NtQueryVolumeInformationFile (file.c:6382)
==15419==    by 0x48601D1: __wine_syscall_dispatcher (in
/home/austin/wine-valgrind/dlls/ntdll/ntdll.so)
==15419==    by 0x7BC33DBB: NtQueryVolumeInformationFile (in
/home/austin/wine-valgrind/dlls/ntdll/ntdll.dll.so)
==15419==    by 0x7B03A615: GetFileInformationByHandle (file.c:2930)
==15419==    by 0x7B03BE56: CopyFileExW (file.c:528)
==15419==    by 0x7B03C197: CopyFileW (file.c:591)
==15419==    by 0x541B87E: do_file_copyW (queue.c:1127)
==15419==    by 0x541BC1C: queue_copy_file (queue.c:1308)
==15419==    by 0x541D984: SetupCommitFileQueueW (queue.c:1455)
==15419==    by 0x5411750: SetupInstallFromInfSectionW (install.c:1101)
==15419==    by 0x5411F3D: InstallHinfSectionW (install.c:1273)
==15419==    by 0x41F325F: ??? (in
/home/austin/wine-valgrind/programs/rundll32/rundll32.exe.so)
==15419==    by 0x41F3C4B: wWinMain (rundll32.c:345)
==15419==  Address 0x50aec28 is on thread 1's stack
==15419==  in frame #7, created by NtQueryVolumeInformationFile (file.c:6184)
==15419==  Uninitialised value was created by a stack allocation
==15419==    at 0x486FE5A: NtQueryVolumeInformationFile (file.c:6184)

that code has been refactored recently, so I'm not sure if this is a different
issue or just the new codepath.

[Bug 36094] advapi32/security test uses an uninitialized variable in test_CreateDirectoryA()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36094

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|advapi32/security test uses |advapi32/security test uses
                   |an unitialized variable in  |an uninitialized variable
                   |test_CreateDirectoryA       |in test_CreateDirectoryA()

[Bug 36094] advapi32/security test uses an uninitialized variable in test_CreateDirectoryA()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36094

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind