[Bug 48657] New: GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

Bug ID: 48657
           Summary: GdipGetNearestColor crash in Subtitle Edit
           Product: Wine
           Version: 5.2
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdiplus
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 5ca9da2c0197ac1260975c1b7b643dbd11185715
      Distribution: Debian

Created attachment 66512
  --> https://bugs.winehq.org/attachment.cgi?id=66512
Terminal log during crash

Steps to reproduce:
1. Install Subtitle Edit 3.5.13 from
https://github.com/SubtitleEdit/subtitleedit/releases/download/3.5.13/Subtit...
2. Run after installing
3. Application will crash almost immediately after starting.

I managed to git bisect first bad commit:
git bisect bad
5ca9da2c0197ac1260975c1b7b643dbd11185715 is the first bad commit
commit 5ca9da2c0197ac1260975c1b7b643dbd11185715
Author: Dmitry Timoshkov 
Date:   Fri Feb 7 18:31:38 2020 +0800

gdiplus: Make GdipGetNearestColor print FIXME only if indexed bitmap is
associated with the graphics object.

Signed-off-by: Dmitry Timoshkov 
    Signed-off-by: Vincent Povirk 
    Signed-off-by: Alexandre Julliard

:040000 040000 9fe62ebe33709629e4e20646059d6753eb55d1cc
6dd228c81c4850a3cc2da975c80f1dfd16a8a982 M      dlls

[Bug 48657] GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

--- Comment #1 from Oskar Wróbel  ---
Created attachment 66514
  --> https://bugs.winehq.org/attachment.cgi?id=66514
backtrace

[Bug 48657] GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |[e-mail]

--- Comment #2 from Zhiyi Zhang  ---
Confirmed with wine-5.2

[Bug 48657] GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

--- Comment #3 from Zhiyi Zhang  ---
Created attachment 66516
  --> https://bugs.winehq.org/attachment.cgi?id=66516
patch

[Bug 48657] GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

--- Comment #4 from Dmitry Timoshkov  ---
(In reply to Zhiyi Zhang from comment #3)
> Created attachment 66516 [details]
> patch

This looks like a correct way to fix this. Thanks.

[Bug 48657] GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

Nguyen Chinh Huu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Nguyen Chinh Huu  ---
*** Bug 48660 has been marked as a duplicate of this bug. ***

[Bug 48657] GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Louis Lenders  ---
*** Bug 48630 has been marked as a duplicate of this bug. ***

[Bug 48657] GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 48657] GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |83e95a609c8ee598ddd8f105497
                   |                            |4689e47e5168b
             Status|NEW                         |RESOLVED

--- Comment #7 from Zhiyi Zhang  ---
Fixed by 83e95a609c8ee598ddd8f1054974689e47e5168b

[Bug 48657] GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Zhiyi Zhang  ---
*** Bug 48679 has been marked as a duplicate of this bug. ***

[Bug 48657] GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 5.3.

[Bug 48657] GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Zhiyi Zhang  ---
*** Bug 48703 has been marked as a duplicate of this bug. ***

[Bug 48657] GdipGetNearestColor crash in Subtitle Edit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48657

Nguyen Chinh Huu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |