[Bug 41596] New: Insane 2 crashes in the menu

https://bugs.winehq.org/show_bug.cgi?id=41596

Bug ID: 41596
           Summary: Insane 2 crashes in the menu
           Product: Wine
           Version: 1.9.21
          Hardware: x86
               URL: http://store.steampowered.com/app/35320
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: e3a8cd20ced9f33db64a35f60bc8487ae8173e47
      Distribution: ---

Created attachment 55938
  --> https://bugs.winehq.org/attachment.cgi?id=55938
terminal output

The game crashes just when the main menu appears.
The problem is present with nouveau/mesa too (except that the crash occurs a
bit later, when starting a race).

Regression introduced by

commit e3a8cd20ced9f33db64a35f60bc8487ae8173e47
Author: Józef Kucia 
Date:   Sun Oct 16 21:46:45 2016 +0200

wined3d: Clean up buffer_internal_preload().

The conversion should never be performed for buffers with
    buffer_type_hint other than GL_ARRAY_BUFFER.

The game works properly with the previous commit.

wine-1.9.21-54-g686cfe3
OpenGL vendor string: NVIDIA Corporation
OpenGL renderer string: GeForce GT 730/PCIe/SSE2
OpenGL core profile version string: 4.5.0 NVIDIA 375.10

[Bug 41596] Insane 2 crashes in the menu

https://bugs.winehq.org/show_bug.cgi?id=41596

--- Comment #1 from Józef Kucia  ---
(In reply to Béla Gyebrószki from comment #0)
> Regression introduced by
>
> commit e3a8cd20ced9f33db64a35f60bc8487ae8173e47
> Author: Józef Kucia 
> Date:   Sun Oct 16 21:46:45 2016 +0200
> wined3d: Clean up buffer_internal_preload().
>
> The conversion should never be performed for buffers with
> buffer_type_hint other than GL_ARRAY_BUFFER.

Thanks for the report.

It was "overly optimistic" dropping device_invalidate_state() in favor of
context_invalidate_state() considering multiple GL contexts... I'll submit a
fix soon.

[Bug 41596] Insane 2 crashes in the menu

https://bugs.winehq.org/show_bug.cgi?id=41596

--- Comment #2 from Józef Kucia  ---
Fix sent https://www.winehq.org/pipermail/wine-patches/2016-October/155353.html

[Bug 41596] Insane 2 crashes in the menu

https://bugs.winehq.org/show_bug.cgi?id=41596

--- Comment #3 from Béla Gyebrószki  ---
(In reply to Józef Kucia from comment #2)
> Fix sent
> https://www.winehq.org/pipermail/wine-patches/2016-October/155353.html

The patch works here, thank you.

[Bug 41596] Insane 2 crashes in the menu

https://bugs.winehq.org/show_bug.cgi?id=41596

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from [e-mail] ---
This should be fixed with:

http://source.winehq.org/git/wine.git/commit/9fef0c49106ef717f0fa717928414f1...

[Bug 41596] Insane 2 crashes in the menu

https://bugs.winehq.org/show_bug.cgi?id=41596

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |9fef0c49106ef717f0fa7179284
                   |                            |14f1b37d06f95
             Status|NEW                         |RESOLVED

--- Comment #5 from Józef Kucia  ---
Fixed in git

[Bug 41596] Insane 2 crashes in the menu

https://bugs.winehq.org/show_bug.cgi?id=41596

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.23.