[Bug 46346] New: ntoskrnl/tests/ntoskrnl.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46346

Bug ID: 46346
           Summary: ntoskrnl/tests/ntoskrnl.c shows uninitalized memory
                    use
           Product: Wine
           Version: 4.0-rc3
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase, valgrind
          Severity: normal
          Priority: P2
         Component: ntoskrnl
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Gentoo

../../../tools/runtest -q -P wine -T ../../.. -M ntoskrnl.exe -p
ntoskrnl.exe_test.exe.so ntoskrnl && touch ntoskrnl.ok
==17895== Syscall param writev(vector[...]) points to uninitialised byte(s)
==17895==    at 0x43567D3: writev (writev.c:26)
==17895==    by 0x7BC75457: send_request (server.c:228)
==17895==    by 0x7BC76158: server_call_unlocked (server.c:288)
==17895==    by 0x7BC916EC: virtual_locked_server_call (virtual.c:2083)
==17895==    by 0x7BC41C1A: server_ioctl_file (file.c:1533)
==17895==    by 0x7BC43368: NtDeviceIoControlFile (file.c:1640)
==17895==    by 0x7B4409AA: DeviceIoControl (file.c:2662)
==17895==    by 0x4A7A518: main_test (ntoskrnl.c:163)
==17895==    by 0x4A7AAE7: func_ntoskrnl (ntoskrnl.c:264)
==17895==    by 0x4A7AEA6: run_test (test.h:617)
==17895==    by 0x4A7B8E4: main (test.h:701)
==17895==  Address 0x492f4e6 is 86 bytes inside a block of size 88 alloc'd
==17895==    at 0x7BC483AD: notify_alloc (heap.c:260)
==17895==    by 0x7BC4B8D1: RtlAllocateHeap (heap.c:1726)
==17895==    by 0x4A7A3EC: heap_alloc (heap.h:29)
==17895==    by 0x4A7A484: main_test (ntoskrnl.c:158)
==17895==    by 0x4A7AAE7: func_ntoskrnl (ntoskrnl.c:264)
==17895==    by 0x4A7AEA6: run_test (test.h:617)
==17895==    by 0x4A7B8E4: main (test.h:701)
==17895==  Uninitialised value was created by a client request
==17895==    at 0x7BC4831C: mark_block_uninitialized (heap.c:214)
==17895==    by 0x7BC4A643: initialize_block (heap.c:245)
==17895==    by 0x7BC4B8E7: RtlAllocateHeap (heap.c:1727)
==17895==    by 0x4A7A3EC: heap_alloc (heap.h:29)
==17895==    by 0x4A7A484: main_test (ntoskrnl.c:158)
==17895==    by 0x4A7AAE7: func_ntoskrnl (ntoskrnl.c:264)
==17895==    by 0x4A7AEA6: run_test (test.h:617)
==17895==    by 0x4A7B8E4: main (test.h:701)
==17895==

[Bug 46346] ntoskrnl/tests/ntoskrnl.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46346

--- Comment #1 from Gijs Vermeulen  ---
Created attachment 63210
  --> https://bugs.winehq.org/attachment.cgi?id=63210
test fix

Does this patch work?

[Bug 46346] ntoskrnl/tests/ntoskrnl.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46346

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 46346] ntoskrnl/tests/ntoskrnl.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46346

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Comment #2 is|1                           |0
            private|                            |

[Bug 46346] ntoskrnl/tests/ntoskrnl.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46346

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |db8f599863b2158fe854b3d937d
                   |                            |b8257c660bab5
             Status|NEW                         |RESOLVED

--- Comment #3 from Gijs Vermeulen  ---
(In reply to Austin English from comment #2)
> (In reply to Gijs Vermeulen from comment #1)
> > Created attachment 63210 [details]
> > test fix
> >
> > Does this patch work?
>
> Yes, thanks

A better version was committed as db8f599863b2158fe854b3d937db8257c660bab5
(Thanks Alexandre).
Thanks for testing.
Marking FIXED.

[Bug 46346] ntoskrnl/tests/ntoskrnl.c shows uninitalized memory use

https://bugs.winehq.org/show_bug.cgi?id=46346

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 4.0-rc6.