[Bug 29297] New: Cold Fear: graphical glitches when shadows enabled

http://bugs.winehq.org/show_bug.cgi?id=29297

Bug #: 29297
           Summary: Cold Fear: graphical glitches when shadows enabled
           Product: Wine
           Version: 1.3.5
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: regression
          Severity: minor
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: 20010235ad07b7be1f68da4c9b36e3ed00d0ca14

Created attachment 37890
  --> http://bugs.winehq.org/attachment.cgi?id=37890
terminal output

Strange black artefacts are covering the screen in Cold Fear when shadow
quality is set to medium, high or very high in the game options. Those black
polygons are covering most of the screen, making the game unplayable.
Game speed slows down to a crawl because this message is literally flooding the
console:
err:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
(0x502) from glUseProgramObjectARB @ glsl_shader.c / 4625

Workaround: disable GLSL

No demo available.
Still present as of wine-1.3.34-202-gb0f704d

The problem appeared in Wine-1.3.5, and the result of the regression test:

20010235ad07b7be1f68da4c9b36e3ed00d0ca14 is the first bad commit
commit 20010235ad07b7be1f68da4c9b36e3ed00d0ca14
Author: Matteo Bruni 
Date:   Thu Sep 30 12:16:16 2010 +0200

wined3d: Keep track of texture transformation states in compiled pixel
shaders.

:040000 040000 6d00f7c0dce4001797cf91527d4b5724296b6197
68a4f0e0309c39c9a970b828055235aa1ef9fb01 M    dlls

git checkout 20010235ad07b7be1f68da4c9b36e3ed00d0ca14  >>screen shows artefacts
git reset --hard HEAD^   >>no artefacts

Please let me know if you need a log with debug channels enabled.

Fedora 16 x86
Nvidia 250 / driver 290.10
X.Org X Server 1.11.2

[Bug 29297] Cold Fear: graphical glitches when shadows enabled

http://bugs.winehq.org/show_bug.cgi?id=29297

--- Comment #1 from GyB  2011-12-10 00:13:48 CST ---
Created attachment 37891
  --> http://bugs.winehq.org/attachment.cgi?id=37891
screenshot showing the issue

[Bug 29297] Cold Fear: graphical glitches when shadows enabled

http://bugs.winehq.org/show_bug.cgi?id=29297

--- Comment #2 from Matteo Bruni  2011-12-10 13:11:40 CST ---
Thanks for the bug report. Hmm, let's try with a +d3d9,+d3d,+d3d_shader log.
You can cut the log after the first

fixme:d3d_shader:print_glsl_info_log     0(13) : error C1115: unable to find
compatible overloaded function "texture2DProj(sampler2D, vec2)"

and the following shader dump. If the log is still too large to attach, you can
maybe drop +d3d_shader.

[Bug 29297] Cold Fear: graphical glitches when shadows enabled

http://bugs.winehq.org/show_bug.cgi?id=29297

--- Comment #3 from GyB  2011-12-10 13:35:21 CST ---
Created attachment 37908
  --> http://bugs.winehq.org/attachment.cgi?id=37908
7zipped +d3d,+d3d9,+d3d_shader log (uncompressed 157 MB)

[Bug 29297] Cold Fear: graphical glitches when shadows enabled

http://bugs.winehq.org/show_bug.cgi?id=29297

--- Comment #4 from Matteo Bruni  2011-12-11 13:01:14 CST ---
Created attachment 37929
  --> http://bugs.winehq.org/attachment.cgi?id=37929
Ignore invalid texture transform flags.

Does this patch help?

[Bug 29297] Cold Fear: graphical glitches when shadows enabled

http://bugs.winehq.org/show_bug.cgi?id=29297

--- Comment #5 from GyB  2011-12-11 13:49:06 CST ---
(In reply to comment #4)
> Created attachment 37929 [details]
> Ignore invalid texture transform flags.
>
> Does this patch help?

Thanks, the patch fixed the problem. Those black artefacts disappeared.

[Bug 29297] Cold Fear: graphical glitches when shadows enabled

http://bugs.winehq.org/show_bug.cgi?id=29297

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |68e0cd430f2e57e55278acd2422
                   |                            |127330628eb6d
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from GyB  2011-12-13 13:35:39 CST ---
Fixed in today's git (wine-1.3.34-295-g4918d91).

http://source.winehq.org/git/wine.git/commit/68e0cd430f2e57e55278acd24221273...

Thank you for fixing this so quickly.

[Bug 29297] Cold Fear: graphical glitches when shadows enabled

http://bugs.winehq.org/show_bug.cgi?id=29297

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2011-12-16 13:30:16 CST ---
Closing bugs fixed in 1.3.35.