[Bug 29180] New: WS_CHILD dialog might want WM_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

Bug #: 29180
           Summary: WS_CHILD dialog might want WM_CAPTION
           Product: Wine
           Version: 1.3.33
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: user32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 37645
  --> http://bugs.winehq.org/attachment.cgi?id=37645
Missing title bar in editable dialog

A child dialog (WS_CHILD) window can request WM_CAPTION and WS_SYSMENU.

The very obscure case of this is a free resource editor like ResEdit. With
ResEdit the WM_CAPTION style is ignored when the window is first created
leaving the editable window without a title bar, this is incorrect and also
causes height calculation problems when the program expect the title bar to
exist.

The incorrect rendering is shown in the attachment. Toggling some style options
which triggers SetWindowLong() will make the title bar appear and everything
continue working correctly.

I'm not 100% sure about WM_SYSMENU showing up on Windows, I'd expect it to be
shown if requested altough not working as the dialog is in disabled state to
prevent using them.

Patch attached to show the incorrect handling of WM_CAPTION. Fixing this should
be trivial by loosening the restrictions posed on WM_CHILD windows.

[Bug 29180] WS_CHILD dialog might want WM_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

--- Comment #1 from Toni Spets  2011-11-26 15:07:56 CST ---
Created attachment 37646
  --> http://bugs.winehq.org/attachment.cgi?id=37646
Probably not the correct fix

Added patch.

[Bug 29180] WS_CHILD dialog might want WM_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

--- Comment #2 from Toni Spets  2011-11-26 15:41:46 CST ---
Example rendering of the dialog editor with the title bar is at the program's
homepage:

http://www.resedit.net/images/dialog_editor.png

[Bug 29180] WS_CHILD dialog might want WM_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch
                URL|                            |http://www.resedit.net/
           Severity|normal                      |minor

[Bug 29180] WS_CHILD dialog might want WM_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

--- Comment #3 from Dmitry Timoshkov  2011-11-26 21:40:43 CST ---
It shouldn't be too hard to write a test case for this.

[Bug 29180] WS_CHILD dialog might want WS_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

Toni Spets  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|WS_CHILD dialog might want  |WS_CHILD dialog might want
                   |WM_CAPTION                  |WS_CAPTION

[Bug 29180] WS_CHILD dialog might want WS_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

--- Comment #4 from Toni Spets  2011-11-27 04:01:20 CST ---
I was of course talking about WS_CAPTION. Silly me.

[Bug 29180] WS_CHILD dialog might want WS_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

--- Comment #5 from Toni Spets  2011-11-27 06:54:37 CST ---
Confirming that on Windows toggling WS_SYSMENU off (by using ResEdit Properties
panel) removes the dialog icon and close button leaving only title with
WS_CAPTION.

The demo window also doesn't have an icon or any buttons, just the title like
in preview. Attaching a screenshot on win7 with WS_SYSMENU disabled and preview
window launched.

[Bug 29180] WS_CHILD dialog might want WS_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

--- Comment #6 from Toni Spets  2011-11-27 06:55:45 CST ---
Created attachment 37662
  --> http://bugs.winehq.org/attachment.cgi?id=37662
ResEdit WS_SYSMENU disabled with WS_CAPTION

[Bug 29180] WS_CHILD dialog might want WS_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #7 from Dmitry Timoshkov  2011-12-07 01:09:30 CST ---
Part 2 of

http://www.winehq.org/pipermail/wine-patches/2011-December/109533.html
http://www.winehq.org/pipermail/wine-patches/2011-December/109534.html

should fix this bug.

[Bug 29180] WS_CHILD dialog might want WS_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

--- Comment #8 from Toni Spets  2011-12-07 10:32:02 CST ---
Confirming the second patch fixes this bug.

[Bug 29180] WS_CHILD dialog might want WS_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |18576b36e4f5759cef7fe04474d
                   |                            |9e968748251fe
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Austin English  2011-12-07 14:23:54 CST ---
(In reply to comment #8)
> Confirming the second patch fixes this bug.

http://source.winehq.org/git/wine.git/commitdiff/18576b36e4f5759cef7fe04474d...

[Bug 29180] WS_CHILD dialog might want WS_CAPTION

http://bugs.winehq.org/show_bug.cgi?id=29180

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  2011-12-16 13:30:39 CST ---
Closing bugs fixed in 1.3.35.