[Bug 52993] New: msi:action - test_publish() fails on date change

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52993

Bug ID: 52993
           Summary: msi:action - test_publish() fails on date change
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]

msi:action - test_publish() fails on date change:

action.c:4219: Test failed: got "20220513"

https://test.winehq.org/data/patterns.html#msi:action

The issue is that when test_publish() started it was slightly before midnight
but when it checked the date in the registry is was slightly after midnight:

3708     get_date_str(date);                         // now it's 20220512
...
4186     /* complete install */
4187     r = MsiInstallProductA(msifile, "FULL=1");  // now it's 20220513
...
4219     CHECK_REG_STR(prodkey, "InstallDate", date);// --> failure

The registry date should be equal to either the date before the installation
started, or the date after the installation started.

The test was added in this commit:

commit 8db3c0e358c54e0ebc3f7b4b7461296d046029e9
Author:     Hans Leidekker 
AuthorDate: Thu Oct 14 11:06:13 2010 +0200

msi/tests: Move test coverage for standard actions to a separate module.

[Bug 52993] msi:action - test_publish() fails on date change

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52993

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression, source,
                   |                            |testcase
                 CC|                            |[e-mail]
    Regression SHA1|                            |8db3c0e358c54e0ebc3f7b4b746
                   |                            |1296d046029e9

[Bug 52993] msi:action - test_publish() fails on date change

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52993

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|8db3c0e358c54e0ebc3f7b4b746 |
                   |1296d046029e9               |
           Keywords|regression                  |

--- Comment #1 from Hans Leidekker  ---
Commit 7bf7340eb6e7135d45c7f233649cfe4989eaf3d2 should fix this. Note that this
is not a regression. The commit pointed out here only moved the test from one
file to another.

[Bug 52993] msi:action - test_publish() fails on date change

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52993

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |7bf7340eb6e7135d45c7f233649
                   |                            |cfe4989eaf3d2

--- Comment #2 from François Gouget  ---
It looks like this got fixed by the commit below:

commit 7bf7340eb6e7135d45c7f233649cfe4989eaf3d2
Author:     Hans Leidekker 
AuthorDate: Sat May 14 12:16:46 2022 +0200

msi/tests: Fix an intermittent test failure.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52993
    Signed-off-by: Hans Leidekker 
    Signed-off-by: Alexandre Julliard

[Bug 52993] msi:action - test_publish() fails on date change

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52993

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 7.11.