[Bug 26048] New: cmd tests show some uninitialized value errors under valgrind

http://bugs.winehq.org/show_bug.cgi?id=26048

Summary: cmd tests show some uninitialized value errors under
                    valgrind
           Product: Wine
           Version: 1.3.13
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: minor
          Priority: P2
         Component: cmd
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=33220)
 --> (http://bugs.winehq.org/attachment.cgi?id=33220)
valgrind log

Conditional jump or move depends on uninitialised value(s)
    at  real_length (sortkey.c:329)
    by  wine_compare_string (sortkey.c:338)
    by  CompareStringW (locale.c:2824)
    by  WCMD_expand_envvar (wcmdmain.c:548)
    by  handleExpansion (wcmdmain.c:823)
    by  WCMD_ReadAndParseLine (wcmdmain.c:1783)
    by  WCMD_batch (batch.c:93)
    by  WCMD_run_program (wcmdmain.c:1131)
    by  WCMD_execute (wcmdmain.c:1554)
    by  WCMD_process_commands (wcmdmain.c:2170)
    by  wmain (wcmdmain.c:2431)
    by  __wine_spec_exe_wentry (exe_wentry.c:36)
    by  ??? (process.c:1034)
    by  start_process (process.c:1086)
    by  ??? (signal_i386.c:2473)
    by  call_thread_entry_point (signal_i386.c:2499)
    by  start_process (loader.c:2606)
    by  ??? (port.c:60)
  Uninitialised value was created by a stack allocation
    at  WCMD_expand_envvar (wcmdmain.c:483)

[Bug 26048] cmd tests show some uninitialized value errors under valgrind

http://bugs.winehq.org/show_bug.cgi?id=26048

--- Comment #1 from Dan Kegel  2011-05-22 21:39:59 CDT ---
Created an attachment (id=34865)
 --> (http://bugs.winehq.org/attachment.cgi?id=34865)
Don't make assumptions about the length of the variable name

Draft fix...

[Bug 26048] cmd tests show some uninitialized value errors under valgrind

http://bugs.winehq.org/show_bug.cgi?id=26048

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #2 from Dan Kegel  2011-05-26 13:32:19 CDT ---
should be fixed by
http://source.winehq.org/git/wine.git/?a=commit;h=1857a05996d9f969bd090253a8...

[Bug 26048] cmd tests show some uninitialized value errors under valgrind

http://bugs.winehq.org/show_bug.cgi?id=26048

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  2011-05-27 13:38:22 CDT ---
Closing bugs fixed in 1.3.21.