[Bug 36749] New: WinLaunch 0.4.6.1 (OSX Style free Launcher) fails to save theme (libpng png_write_end fails with 'No IDATs written into file')

https://bugs.winehq.org/show_bug.cgi?id=36749

Bug ID: 36749
           Summary: WinLaunch 0.4.6.1 (OSX Style free Launcher) fails to
                    save theme (libpng png_write_end fails with 'No IDATs
                    written into file')
           Product: Wine
           Version: 1.7.20
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: windowscodecs
          Assignee: [e-mail]
          Reporter: [e-mail]

Hello folks,

continuation of bug 34942

Prerequisite: 'winetricks -q dotnet40'

'Settings' -> 'General' -> 'Open performance advisor', select theme -> 'done'

--- snip ---
$ WINEDEBUG=+tid,+seh,+relay,+wincodecs wine ./WinLaunch.exe >>log.txt 2>&1
...
002c:Call
windowscodecs.IWICBitmapFrameEncode_WriteSource_Proxy(058bfd1c,0582c404,0033e7d4)
ret=0986eebb
002c:trace:wincodecs:PngFrameEncode_WriteSource (0x58bfd1c,0x582c404,(nil))
002c:trace:wincodecs:BitmapImpl_GetPixelFormat (0x582c404,0x33e5c0)
002c:trace:wincodecs:BitmapImpl_GetSize (0x582c404,0x33e5b4,0x33e5b0)
002c:Call ntdll.RtlAllocateHeap(00110000,00000000,000204e8) ret=7df568c2
002c:Ret  ntdll.RtlAllocateHeap() retval=0857ad90 ret=7df568c2
002c:trace:wincodecs:BitmapImpl_CopyPixels
(0x582c404,0x33e5b8,952,132328,0x857ad90)
002c:trace:wincodecs:PngFrameEncode_WritePixels
(0x58bfd1c,139,952,132328,0x857ad90) 
...
002c:Ret  windowscodecs.IWICBitmapFrameEncode_WriteSource_Proxy()
retval=00000000 ret=0986eebb 
...
002c:Call windowscodecs.IWICBitmapFrameEncode_Commit_Proxy(058bfd1c)
ret=0986f0a6
002c:trace:wincodecs:PngFrameEncode_Commit (0x58bfd1c)
002c:warn:wincodecs:user_error_fn PNG error: "No IDATs written into file"
002c:Ret  windowscodecs.IWICBitmapFrameEncode_Commit_Proxy() retval=80004005
ret=0986f0a6
002c:Call KERNEL32.GetLastError() ret=7919c63c
002c:Ret  KERNEL32.GetLastError() retval=000036b7 ret=7919c63c 
...
002c:Call KERNEL32.RaiseException(e0434352,00000001,00000005,0033e66c)
ret=791cac08
002c:trace:seh:raise_exception code=e0434352 flags=1 addr=0x7b83ac6b
ip=7b83ac6b tid=002c
002c:trace:seh:raise_exception  info[0]=80004005
002c:trace:seh:raise_exception  info[1]=00000000
002c:trace:seh:raise_exception  info[2]=00000000
002c:trace:seh:raise_exception  info[3]=00000000
002c:trace:seh:raise_exception  info[4]=79140000
002c:trace:seh:raise_exception  eax=7b826c7d ebx=7b8bb000 ecx=80004005
edx=0033e584 esi=0033e628 edi=0033e5f0
002c:trace:seh:raise_exception  ebp=0033e5c8 esp=0033e564 cs=0023 ds=002b
es=002b fs=0063 gs=006b flags=00200283 
...
002c:Call user32.MessageBoxW(00030072,00f4cfd0 L"error saving theme!",00f4d608
L"WinLaunch error",00000000) ret=053d6d7f 
--- snip ---

Source:
http://source.winehq.org/git/wine.git/blob/3ccaad8b41fe9514b95aa7610a1b33bb7...

$ sha1sum WinLaunch.zip 
5d79fb1d160354a04548fc7bba1a78012800c59c  WinLaunch.zip

$ du -sh WinLaunch.zip 
20M    WinLaunch.zip

$ wine --version
wine-1.7.20-33-g3ccaad8

Regards

[Bug 36749] WinLaunch 0.4.6.1 (OSX Style free Launcher) fails to save theme (libpng png_write_end fails with 'No IDATs written into file')

https://bugs.winehq.org/show_bug.cgi?id=36749

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |dotnet, download
                URL|                            |http://sourceforge.net/proj
                   |                            |ects/winlaunch/files/WinLau
                   |                            |nch.zip/download

[Bug 36749] WinLaunch 0.4.6.1 (OSX Style free Launcher) fails to save theme (libpng png_write_end fails with 'No IDATs written into file')

https://bugs.winehq.org/show_bug.cgi?id=36749

--- Comment #1 from Vincent Povirk  ---
Turns out we need to use png_set_interlace_handling and call png_write_rows
multiple times in the interlace case.

[Bug 36749] WinLaunch 0.4.6.1 (OSX Style free Launcher) fails to save theme (libpng png_write_end fails with 'No IDATs written into file')

https://bugs.winehq.org/show_bug.cgi?id=36749

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e2d6b28a1b2ed064fe14409220e
                   |                            |9fce3c0573987
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Anastasius Focht  ---
Hello folks,

this is fixed by commit
http://source.winehq.org/git/wine.git/commitdiff/e2d6b28a1b2ed064fe14409220e...

Thanks Vincent

Regards

[Bug 36749] WinLaunch 0.4.6.1 (OSX Style free Launcher) fails to save theme (libpng png_write_end fails with 'No IDATs written into file')

https://bugs.winehq.org/show_bug.cgi?id=36749

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.21.

[Bug 36749] WinLaunch 0.4.6.1 (OSX Style free Launcher) fails to save theme (libpng png_write_end fails with 'No IDATs written into file')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36749

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://sourceforge.net/proj |https://web.archive.org/web
                   |ects/winlaunch/files/WinLau |/20210726125551/https://jzt
                   |nch.zip/download            |kft.dl.sourceforge.net/proj
                   |                            |ect/winlaunch/WinLaunch.zip