[Bug 45542] New: regression: WeGame hangs after login.

https://bugs.winehq.org/show_bug.cgi?id=45542

Bug ID: 45542
           Summary: regression: WeGame hangs after login.
           Product: Wine
           Version: 3.13
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: advapi32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 61948
  --> https://bugs.winehq.org/attachment.cgi?id=61948
0001-Revert-server-Assign-a-default-label-to-all-tokens.txt

WeGame is a game platform by Tencent.

Steps to reproduce:
1. $ winetricks -q mfc42 cjkfonts
2. $ wine WeGameMiniLoader.3.6.1.5080.gw.exe
3. $ cd .wine/drive_c/Program\ Files/WeGame
4. $ WINEDLLOVERRIDES="msvcr100=n" wine tgp_daemon.exe
5. Due to bug 45540 , we can't login by an account number and password. But we
can login it by scanning its QR code. Clicking the Wechat icon and scaning the
QR code on WeChat mobile for login.

Expected: We can login and enter WeGame's game store interface.

Actually: Login successfully but it will hang.

I found that it work well on Wine-2.8 and I did a regression tests for it found
that this commit broke it:

commit a78d419420a43e1f428ac155082b87143117e381
Author: Michael Müller 
Date:   Fri Jun 16 20:41:36 2017 +0200

server: Assign a default label to all tokens.

0001-Revert-server-Assign-a-default-label-to-all-tokens.txt is a patch for
reverting this commit on current Wine-3.13. And with this reverting WeGame
doesn't hang again.

[Bug 45542] regression: WeGame hangs after login.

https://bugs.winehq.org/show_bug.cgi?id=45542

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
                 CC|                            |[e-mail]
    Regression SHA1|                            |a78d419420a43e1f428ac155082
                   |                            |b87143117e381
                URL|                            |http://dldir1.qq.com/tgc/we
                   |                            |game/mini/3.6.1.5080/WeGame
                   |                            |MiniLoader.3.6.1.5080.gw.ex
                   |                            |e

[Bug 45542] WeGame hangs after login.

https://bugs.winehq.org/show_bug.cgi?id=45542

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|regression: WeGame hangs    |WeGame hangs after login.
                   |after login.                |

[Bug 45542] WeGame hangs after login.

https://bugs.winehq.org/show_bug.cgi?id=45542

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]    |

--- Comment #1 from Matteo Bruni  ---
Did you try with staging, by any chance? There are some follow-up patches
building on top of the regression commit which might have an effect.

[Bug 45542] WeGame hangs after login.

https://bugs.winehq.org/show_bug.cgi?id=45542

--- Comment #2 from Jactry Zeng  ---
Created attachment 61955
  --> https://bugs.winehq.org/attachment.cgi?id=61955
+advapi+pid+tid log on wine-3.13

(In reply to Matteo Bruni from comment #1)
> Did you try with staging, by any chance? There are some follow-up patches
> building on top of the regression commit which might have an effect.

Thanks for comment!

Yes, it works on wine-staging. So I tried more patches from staging's
advapi32-Token_Integrity_Level on wine-3.13, but it didn't help.

It seems that patch in staging's ntdll-APC_Start_Process is the one had effect
for it. I applied this patch to wine-3.13 and it works well too.

(Upload a log on pure wine-3.13 without any hack.)

[Bug 45542] WeGame hangs after login.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45542

--- Comment #3 from Gijs Vermeulen  ---
An updated version of the ntdll-APC_Start_Process patch was upstreamed as
https://source.winehq.org/git/wine.git/commit/b45d6125493e19e7e2befe071b7052bad4d2859f,
is this issue still present?

[Bug 45542] WeGame hangs after login.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45542

--- Comment #4 from Gijs Vermeulen  ---
Jactry, can you still reproduce this?

[Bug 45542] WeGame hangs after login.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45542

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |b45d6125493e19e7e2befe071b7
                   |                            |052bad4d2859f
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Jactry Zeng  ---
I didn't find a way to reproduce the original issue because logging in with an
old version of WeGame is forbidden and I didn't see the issue with the latest
version of WeGame on Wine 4.16.
Anyway, since the committed patch is almost the same one as the one in Wine
staging I tested with previously, I think it is reasonable to believe the
original issue was fixed by it, I am going to mark this bug as FIXED.

Thanks for the following up.

[Bug 45542] WeGame hangs after login.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45542

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 8.0-rc5.