[Bug 33271] New: advapi32 OpenServiceW on non-existing service causes crash in SERV_OpenServiceW() if 'service' debug channel is used

http://bugs.winehq.org/show_bug.cgi?id=33271

Bug #: 33271
           Summary: advapi32 OpenServiceW on non-existing service causes
                    crash in SERV_OpenServiceW() if 'service' debug
                    channel is used
           Product: Wine
           Version: 1.5.26
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: advapi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Hello folks,

found while using +service debug channel on app that tries to start a non
existing service...

Source:
http://source.winehq.org/git/wine.git/blob/08238b83b8282a60eef3b0fc5afcdb913...

--- snip ---
 932 DWORD SERV_OpenServiceW( SC_HANDLE hSCManager, LPCWSTR lpServiceName,
 933                          DWORD dwDesiredAccess, SC_HANDLE *handle )
 934 {
 935     DWORD err;
 936 
 937     TRACE("%p %s %d\n", hSCManager, debugstr_w(lpServiceName),
dwDesiredAccess);
 938 
 939     if (!hSCManager)
 940         return ERROR_INVALID_HANDLE;
 941 
 942     __TRY
 943     {
 944         err = svcctl_OpenServiceW(hSCManager, lpServiceName,
dwDesiredAccess, (SC_RPC_HANDLE *)handle);
 945     }
 946     __EXCEPT(rpc_filter)
 947     {
 948         err = map_exception_code(GetExceptionCode());
 949     }
 950     __ENDTRY
 951 
 952     if (err != ERROR_SUCCESS)
 953         handle = 0;
 954 
 955     TRACE("returning %p\n", *handle);
 956     return err;
 957 }
--- snip ---

Line 953: "*handle = 0" is what you want ;-)

Regards

[Bug 33271] advapi32 OpenServiceW on non-existing service causes crash in SERV_OpenServiceW() if 'service' debug channel is used

http://bugs.winehq.org/show_bug.cgi?id=33271

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c61df085432c5abe855c8df6043
                   |                            |e46af1bf678ef
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Nikolay Sivov  2013-03-25 22:48:33 CDT ---
Fixed.

[Bug 33271] advapi32 OpenServiceW on non-existing service causes crash in SERV_OpenServiceW() if 'service' debug channel is used

http://bugs.winehq.org/show_bug.cgi?id=33271

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard  2013-03-29 13:32:37 CDT ---
Closing bugs fixed in 1.5.27.