[Bug 58673] New: Kinco Dtools fails to start: err:msxml:doparse Unsupported encoding: gb2312

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58673

Bug ID: 58673
           Summary: Kinco Dtools fails to start: err:msxml:doparse
                    Unsupported encoding: gb2312
           Product: Wine
           Version: 10.14
          Hardware: x86-64
               URL: https://en.kinco.cn/download/download.html
                OS: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: msxml3
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Debian

This was program reported on the forum:
https://forum.winehq.org/viewtopic.php?t=41565

It needs mfc42.dll and mfc140u.dll (via winetricks vcrun2019) but even after
that installed, it fails to start with a vague error messagebox. After multiple 
"Unsupported encoding: gb2312" in the console

The hack below allows it to start; might be easy to solve (???) for someone
familiar with msxml?

diff --git a/dlls/msxml3/main.c b/dlls/msxml3/main.c
index 16e0b38b185..733a707cd31 100644
--- a/dlls/msxml3/main.c
+++ b/dlls/msxml3/main.c
@@ -322,6 +322,7 @@ static void init_char_encoders(void)
     } encoder[] =
     {
         { "gbk",          gbk_to_utf8,       utf8_to_gbk       },
+        { "gb2312",       gbk_to_utf8,       utf8_to_gbk       },
         { "iso8859-1",    iso8859_1_to_utf8, utf8_to_iso8859_1 },
         { "windows-1250", win1250_to_utf8,   utf8_to_win1250   },
         { "windows-1251", win1251_to_utf8,   utf8_to_win1251   },

[Bug 58673] Kinco Dtools fails to start: err:msxml:doparse Unsupported encoding: gb2312

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58673

--- Comment #1 from Dmitry Timoshkov  ---
According to https://en.wikipedia.org/wiki/GBK_(character_encoding)
"GBK is an extension of the GB 2312 character set", so your patch looks
reasonable.

[Bug 58673] Kinco Dtools fails to start: err:msxml:doparse Unsupported encoding: gb2312

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58673

--- Comment #2 from Louis Lenders  ---
 Dmitry, thank for the reply,
> "GBK is an extension of the GB 2312 character set", so your patch looks

reasonable.

Ok, but as I'm really unfamiliar with msxml and I gues this needs a test (?),
could someone else pick this up?

[Bug 58673] Kinco Dtools fails to start: err:msxml:doparse Unsupported encoding: gb2312

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58673

--- Comment #3 from Dmitry Timoshkov  ---
(In reply to Louis Lenders from comment #2)
> Dmitry, thank for the reply,
> > "GBK is an extension of the GB 2312 character set", so your patch looks
>
> reasonable.
>
> Ok, but as I'm really unfamiliar with msxml and I gues this needs a test
> (?), could someone else pick this up?

It's OK to send this patch without a test. The patch looks good to me.