https://bugs.winehq.org/show_bug.cgi?id=55772
Bug ID: 55772 Summary: uxtheme:system - test_EnableThemeDialogTexture() fails on Windows 7 Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: uxtheme Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com
uxtheme:system - test_EnableThemeDialogTexture() fails on Windows 7:
system.c:1947: Test failed: Expected brush changed. system.c:1954: Test failed: Expected a different brush. system.c:1972: Test failed: Expected a different brush. system.c:1983: Test failed: Expected a different brush. system.c:2007: Test failed: OpenThemeData failed. system.c:2011: Test failed: GetThemePartSize failed, hr 0x80070006. system.c:2034: Test failed: msg 0x132: Expected (-1,-2), got (0,0). system.c:2042: Test failed: msg 0x132: Expected mode 0x1, got 0x2. system.c:2057: Test failed: msg 0x132: Expected brush color 0, got 0xf0f0f0. system.c:2058: Test failed: msg 0x132: Expected brush style 0x3, got 0. system.c:2063: Test failed: msg 0x132: GetObjectA failed, error 2147943568. system.c:2069: Test failed: msg 0x132: Expected a different brush. system.c:2077: Test failed: msg 0x132: Expected a different brush. system.c:2034: Test failed: msg 0x135: Expected (-1,-2), got (0,0). system.c:2042: Test failed: msg 0x135: Expected mode 0x1, got 0x2. system.c:2057: Test failed: msg 0x135: Expected brush color 0, got 0xf0f0f0. system.c:2058: Test failed: msg 0x135: Expected brush style 0x3, got 0. system.c:2063: Test failed: msg 0x135: GetObjectA failed, error 2147943568. system.c:2069: Test failed: msg 0x135: Expected a different brush. system.c:2077: Test failed: msg 0x135: Expected a different brush. system.c:2034: Test failed: msg 0x136: Expected (-1,-2), got (0,0). system.c:2042: Test failed: msg 0x136: Expected mode 0x1, got 0x2. system.c:2057: Test failed: msg 0x136: Expected brush color 0, got 0xf0f0f0. system.c:2058: Test failed: msg 0x136: Expected brush style 0x3, got 0. system.c:2063: Test failed: msg 0x136: GetObjectA failed, error 2147943568. system.c:2069: Test failed: msg 0x136: Expected a different brush. system.c:2077: Test failed: msg 0x136: Expected a different brush. system.c:2090: Test failed: msg 0x136: Expected a different brush. system.c:2092: Test failed: msg 0x136: Expected a different brush. system.c:2034: Test failed: msg 0x138: Expected (-1,-2), got (0,0). system.c:2042: Test failed: msg 0x138: Expected mode 0x1, got 0x2. system.c:2057: Test failed: msg 0x138: Expected brush color 0, got 0xf0f0f0. system.c:2058: Test failed: msg 0x138: Expected brush style 0x3, got 0. system.c:2063: Test failed: msg 0x138: GetObjectA failed, error 2147943568. system.c:2069: Test failed: msg 0x138: Expected a different brush. system.c:2077: Test failed: msg 0x138: Expected a different brush. system.c:2165: Test failed: Expected a different brush. system.c:2246: Test failed: 0x1 to 0x6: Expected tab texture enabled. system.c:2246: Test failed: 0x1 to 0xa: Expected tab texture enabled. [...] system.c:2327: Test failed: "Static" 0x10: Expected tab texture enabled.
See: https://test.winehq.org/data/patterns.html#uxtheme:system
The failures started on 2023-10-10 and are systematic. A bisect shows that they started with the commit below:
commit 91e54e5f6d33ff17ce6ab904fbdcdeb6497de8cb Author: Helix Graziani helix.graziani@hotmail.com AuthorDate: Tue Sep 26 20:03:44 2023 -0400
uxtheme: Add ShouldSystemUseDarkMode.
Since that commit does not modify test_EnableThemeDialogTexture() it must be the new ShouldSystemUseDarkMode() call that breaks things (see bug 55771).
https://bugs.winehq.org/show_bug.cgi?id=55772
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, source, | |testcase Regression SHA1| |91e54e5f6d33ff17ce6ab904fbd | |cdeb6497de8cb
https://bugs.winehq.org/show_bug.cgi?id=55772
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |e5536fa0de6b9e5dc151bfe3593 | |ac6a72ddfc6f9 Resolution|--- |FIXED Status|NEW |RESOLVED
--- Comment #1 from François Gouget fgouget@codeweavers.com --- This is fixed:
commit e5536fa0de6b9e5dc151bfe3593ac6a72ddfc6f9 Author: Helix Graziani helix.graziani@hotmail.com AuthorDate: Sat Oct 14 17:48:22 2023 -0400
uxtheme/tests: Skip the test if the SystemUsesLightTheme value isn't found.
Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=55771
https://bugs.winehq.org/show_bug.cgi?id=55772
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #2 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 8.19.