[Bug 37194] New: SpellForce 2: Demons of the Past: textures too dark

https://bugs.winehq.org/show_bug.cgi?id=37194

Bug ID: 37194
           Summary: SpellForce 2: Demons of the Past: textures too dark
           Product: Wine
           Version: 1.7.3
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 991e47e3c9f1a774d6e0f9e0c30343650e8ac132

Created attachment 49441
  --> https://bugs.winehq.org/attachment.cgi?id=49441
screenshot (comparison)

I have this problem with the 3rd standalone expansion to Spellforce 2, but
can't reproduce it with the original game (S2:Shadow Wars) or with the first
expansion (S2:Dragon Storm).
Textures in the game and in the intro video are much darker than they should
be. The user interface is not affected.

No demo version has been released.
Native d3dx9_36 installed.

Terminal output:
> fixme:win:EnumDisplayDevicesW ((null),0,0x33f328,0x00000000), stub!
> fixme:d3d9:Direct3DShaderValidatorCreate9 stub
> fixme:d3d:state_lastpixel Last Pixel Drawing Disabled, not handled yet
> fixme:d3d:query_init Unhandled query type 0x4.

Reverting the following commit on 1.7.25 fixes the issue for me:

991e47e3c9f1a774d6e0f9e0c30343650e8ac132 is the first bad commit
commit 991e47e3c9f1a774d6e0f9e0c30343650e8ac132
Author: Henri Verbeet 
Date:   Wed Sep 25 09:58:11 2013 +0200

wined3d: Allow WINED3DFMT_R8G8B8A8_UNORM render targets.

:040000 040000 06dd09fc9fc2ce5a25a1304d01697cccb44d368e
bebc9490935f95749e14e808928b34c72703a325 M    dlls

Tested with Nvidia binary drivers 340.32 and Nouveau 1.0.9.

wine-1.7.25-40-g5aeb834

[Bug 37194] SpellForce 2: Demons of the Past: textures too dark

https://bugs.winehq.org/show_bug.cgi?id=37194

--- Comment #1 from Henri Verbeet  ---
Created attachment 49443
  --> https://bugs.winehq.org/attachment.cgi?id=49443
patch

This is more of a guess than anything else, but does the attached patch make it
any better?

[Bug 37194] SpellForce 2: Demons of the Past: textures too dark

https://bugs.winehq.org/show_bug.cgi?id=37194

--- Comment #2 from Béla Gyebrószki  ---
(In reply to Henri Verbeet from comment #1)
> Created attachment 49443 [details]
> patch
>
> This is more of a guess than anything else, but does the attached patch make
> it any better?

Thanks, the patch works here.

[Bug 37194] SpellForce 2: Demons of the Past: textures too dark

https://bugs.winehq.org/show_bug.cgi?id=37194

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |429d72965d5a0e32059bb2944bc
                   |                            |4fd6b2c8d4e96
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Béla Gyebrószki  ---
Fixed by 429d72965d5a0e32059bb2944bc4fd6b2c8d4e96

[Bug 37194] SpellForce 2: Demons of the Past: textures too dark

https://bugs.winehq.org/show_bug.cgi?id=37194

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.26.