[Bug 38459] New: valgrind shows an uninitialized variable in dlls/d3d9/tests/visual.c test_fragment_coords()

https://bugs.winehq.org/show_bug.cgi?id=38459

Bug ID: 38459
           Summary: valgrind shows an uninitialized variable in
                    dlls/d3d9/tests/visual.c test_fragment_coords()
           Product: Wine
           Version: 1.7.41
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase, valgrind
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Debian

==29750== Conditional jump or move depends on uninitialised value(s)
==29750==    at 0x66B227D: ??? (in
/usr/lib/i386-linux-gnu/libnvidia-glcore.so.340.65)
==29750==    by 0x49EE116: shader_glsl_load_constants (glsl_shader.c:958)
==29750==    by 0x49BEFB2: context_apply_draw_state (context.c:3128)
==29750==    by 0x49E8286: draw_primitive (drawprim.c:667)
==29750==    by 0x49BF86A: wined3d_cs_exec_draw (cs.c:318)
==29750==    by 0x49C10FD: wined3d_cs_st_submit (cs.c:1071)
==29750==    by 0x49BF8D7: wined3d_cs_emit_draw (cs.c:335)
==29750==    by 0x49CEED7: wined3d_device_draw_primitive (device.c:3425)
==29750==    by 0x494F3C4: d3d9_device_DrawPrimitiveUP (device.c:2287)
==29750==    by 0x48DDA69: test_fragment_coords (visual.c:9609)
==29750==    by 0x490668F: func_visual (visual.c:18053)
==29750==    by 0x4907463: run_test (test.h:584)
==29750==    by 0x490789D: main (test.h:666)
==29750==  Uninitialised value was created by a stack allocation
==29750==    at 0x49ED80A: shader_glsl_load_constants (glsl_shader.c:852)
==29750==

[Bug 38459] valgrind shows an uninitialized variable in dlls/d3d9/tests/visual.c test_fragment_coords()

https://bugs.winehq.org/show_bug.cgi?id=38459

--- Comment #1 from Henri Verbeet  ---
Created attachment 51302
  --> https://bugs.winehq.org/attachment.cgi?id=51302
patch

That's inside a proprietary graphics driver, which makes everyone's life a
little harder, but does the attached patch help?

[Bug 38459] valgrind shows an uninitialized variable in dlls/d3d9/tests/visual.c test_fragment_coords()

https://bugs.winehq.org/show_bug.cgi?id=38459

--- Comment #2 from Austin English  ---
(In reply to Henri Verbeet from comment #1)
> Created attachment 51302 [details]
> patch
>
> That's inside a proprietary graphics driver, which makes everyone's life a
> little harder, but does the attached patch help?

It works, thanks.

[Bug 38459] valgrind shows an uninitialized variable in dlls/d3d9/tests/visual.c test_fragment_coords()

https://bugs.winehq.org/show_bug.cgi?id=38459

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |de1450788b99f8976b1c49b74d3
                   |                            |52f6a24bb2cde
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Austin English  ---
(In reply to Henri Verbeet from comment #1)
> Created attachment 51302 [details]
> patch
>
> That's inside a proprietary graphics driver, which makes everyone's life a
> little harder, but does the attached patch help?

https://source.winehq.org/git/wine.git/commitdiff/de1450788b99f8976b1c49b74d...

[Bug 38459] valgrind shows an uninitialized variable in dlls/d3d9/tests/visual.c test_fragment_coords()

https://bugs.winehq.org/show_bug.cgi?id=38459

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.42.