http://bugs.winehq.org/show_bug.cgi?id=35485
Bug ID: 35485 Summary: Tab control is keeping pressed with TCM_SETCURSEL wParam:-1 Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs@winehq.org Reporter: s.wanabe@gmail.com Classification: Unclassified
When Wine is recieved TCM_SETCURSEL with wParam == -1, dwState of current pressed tab is kept TCIS_BUTTONPRESSED. I have confirmed this with wine-1.4.1 and master branch 82b38139, on ubuntu 13.10.
TAB_GetItem(infoPtr, prevItem)->dwState &= ~TCIS_BUTTONPRESSED;
This is a line in TAB_SetCurSel(). I guess this process is needed also when wParam == -1, isn't this?
Effects example:
xyzzy editor (Stable English version) http://xyzzy.s53.xrea.com/english/archive/ (Stable Japanese version) http://www.jsdlab.co.jp/~kamei/ (Developing Japanese version) https://github.com/xyzzy-022/xyzzy
To reproduce the issue:
1. Run xyzzy.exe on Wine 2. Type [ALT] v q b to show buffer-tab 3. Type [ESC] x new-file to create new buffer-tab 4. Click "*scratch*" tab to Select the buffer 5. Same as 3. (Type [ESC] x new-file to create new buffer-tab) 6. Make sure of unselectable buffer-tabs
Xyzzy send TCM_SETCURSEL with -1 in above 5.
http://bugs.winehq.org/show_bug.cgi?id=35485
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source Version|unspecified |1.4.1
--- Comment #1 from Ken Sharp imwellcushtymelike@gmail.com --- Have you tried with Wine 1.7.11? 1.4.1 is ancient.
http://bugs.winehq.org/show_bug.cgi?id=35485
--- Comment #2 from s.wanabe@gmail.com --- Thank you to comment!
I have tried master branch 82b38139, it is most recently version. http://source.winehq.org/git/wine.git/commit/82b38139eb21a6898e4621eb7405e99... And just now I tried with Wine 1.7.11 from launchpad, but the result is same.
http://bugs.winehq.org/show_bug.cgi?id=35485
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com --- So did you verify that native comctl32 fixes this problem?
http://bugs.winehq.org/show_bug.cgi?id=35485
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1
--- Comment #4 from Nikolay Sivov bunglehead@gmail.com --- Yes, this makes sense. I'll add a test for that and send with a fix next week.
http://bugs.winehq.org/show_bug.cgi?id=35485
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com --- Created attachment 47467 --> http://bugs.winehq.org/attachment.cgi?id=47467 patch
Here's a fix for this problem, feel free to test it and report any issues.
http://bugs.winehq.org/show_bug.cgi?id=35485
--- Comment #6 from s.wanabe@gmail.com --- I've confirmed that xyzzy editor works fine as same as Windows Environment (Windows 7 Home Premium) on Wine (master branch) with the patch. I can't find any issues.
Thanks a lot!
http://bugs.winehq.org/show_bug.cgi?id=35485
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |0e73e478ff3f8ee46fc18b1f1bf | |211b0dec80a2a Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #7 from Nikolay Sivov bunglehead@gmail.com --- Fixed with 0e73e478ff3f8ee46fc18b1f1bf211b0dec80a2a.
https://bugs.winehq.org/show_bug.cgi?id=35485
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.13.