[Bug 38593] New: valgrind shows uninitialized memory in set_mwm_hints()

https://bugs.winehq.org/show_bug.cgi?id=38593

Bug ID: 38593
           Summary: valgrind shows uninitialized memory in set_mwm_hints()
           Product: Wine
           Version: 1.7.42
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase, valgrind
          Severity: normal
          Priority: P2
         Component: opengl
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Fedora

shows up a lot of tests, this is in atl100/tests/atl.c

==23588== Syscall param writev(vector[...]) points to uninitialised byte(s)
==23588==    at 0x4F7A0F23: __writev_nocancel (in /usr/lib/libc-2.21.so)
==23588==    by 0x62BDA28: ??? (in /usr/lib/libxcb.so.1.1.0)
==23588==    by 0x62BDF07: ??? (in /usr/lib/libxcb.so.1.1.0)
==23588==    by 0x62BDFAB: xcb_writev (in /usr/lib/libxcb.so.1.1.0)
==23588==    by 0x61AD113: _XSend (in /usr/lib/libX11.so.6.3.0)
==23588==    by 0x61AD4B4: _XFlush (in /usr/lib/libX11.so.6.3.0)
==23588==    by 0x618B9BB: XFlush (in /usr/lib/libX11.so.6.3.0)
==23588==    by 0x5FDF7B6: create_whole_window (window.c:1477)
==23588==    by 0x5FE0550: X11DRV_create_win_data (window.c:1803)
==23588==    by 0x5FE1245: X11DRV_WindowPosChanging (window.c:2153)
==23588==    by 0x51AAA7C: set_window_pos (winpos.c:2062)
==23588==    by 0x51A0138: WIN_CreateWindowEx (win.c:1580)
==23588==    by 0x51A0841: CreateWindowExW (win.c:1750)
==23588==    by 0x4ADB32A: test_ax_win (atl.c:643)
==23588==    by 0x4ADD9FC: func_atl (atl.c:1034)
==23588==    by 0x4ADE77D: run_test (test.h:584)
==23588==    by 0x4ADEBC4: main (test.h:666)
==23588==  Address 0x432fccc is 252 bytes inside a block of size 16,384 alloc'd
==23588==    at 0x4008D0E: calloc (vg_replace_malloc.c:626)
==23588==    by 0x619B3B4: XOpenDisplay (in /usr/lib/libX11.so.6.3.0)
==23588==    by 0x5FE7DF8: x11drv_init_thread_data (x11drv_main.c:658)
==23588==    by 0x5FDBCB0: thread_init_display (x11drv.h:347)
==23588==    by 0x5FE04B3: X11DRV_create_win_data (window.c:1794)
==23588==    by 0x5FE1245: X11DRV_WindowPosChanging (window.c:2153)
==23588==    by 0x51AAA7C: set_window_pos (winpos.c:2062)
==23588==    by 0x51A0138: WIN_CreateWindowEx (win.c:1580)
==23588==    by 0x51A0841: CreateWindowExW (win.c:1750)
==23588==    by 0x4ADB32A: test_ax_win (atl.c:643)
==23588==    by 0x4ADD9FC: func_atl (atl.c:1034)
==23588==    by 0x4ADE77D: run_test (test.h:584)
==23588==    by 0x4ADEBC4: main (test.h:666)
==23588==  Uninitialised value was created by a stack allocation
==23588==    at 0x5FDD68B: set_mwm_hints (window.c:702)
==23588==

[Bug 38593] valgrind shows uninitialized memory in set_mwm_hints()

https://bugs.winehq.org/show_bug.cgi?id=38593

Indrek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Indrek  ---
I sent a patch https://source.winehq.org/patches/data/111353 (not yet
approved).
Do the warnings still occur for you with this patch?

[Bug 38593] valgrind shows uninitialized memory in set_mwm_hints()

https://bugs.winehq.org/show_bug.cgi?id=38593

--- Comment #2 from Austin English  ---
(In reply to Indrek from comment #1)
> I sent a patch https://source.winehq.org/patches/data/111353 (not yet
> approved).
> Do the warnings still occur for you with this patch?

Works here, thanks.

[Bug 38593] valgrind shows uninitialized memory in set_mwm_hints()

https://bugs.winehq.org/show_bug.cgi?id=38593

--- Comment #3 from Indrek  ---
Fix made it to the master as
http://source.winehq.org/git/wine.git/commit/68e1fdf99954c0f66f9a536d8f8a384...
(explicit zeroing instead of the original memset approach)

[Bug 38593] valgrind shows uninitialized memory in set_mwm_hints()

https://bugs.winehq.org/show_bug.cgi?id=38593

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |68e1fdf99954c0f66f9a536d8f8
                   |                            |a384033104bf1
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Austin English  ---
(In reply to Indrek from comment #3)
> Fix made it to the master as
> http://source.winehq.org/git/wine.git/commit/
> 68e1fdf99954c0f66f9a536d8f8a384033104bf1 (explicit zeroing instead of the
> original memset approach)

Yes, thanks.

[Bug 38593] valgrind shows uninitialized memory in set_mwm_hints()

https://bugs.winehq.org/show_bug.cgi?id=38593

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.45.