http://bugs.winehq.org/show_bug.cgi?id=19338
Summary: Regression in ResHacker Product: Wine Version: unspecified Platform: PC URL: http://www.angusj.com/resourcehacker/ OS/Version: Linux Status: NEW Keywords: regression Severity: normal Priority: P2 Component: comctl32 AssignedTo: wine-bugs@winehq.org ReportedBy: mstefani@redhat.com CC: dmitry@codeweavers.com
Created an attachment (id=22393) --> (http://bugs.winehq.org/attachment.cgi?id=22393) ResHacker bad
ee7ca802f4839fab9efd1759a762a9839d931a9b is first bad commit commit ee7ca802f4839fab9efd1759a762a9839d931a9b Author: Dmitry Timoshkov dmitry@codeweavers.com Date: Wed Jul 15 21:21:26 2009 +0900
comctl32: Do not redraw treeview in TVM_INSERTITEM handler if bRedraw is not set, trigger the redraw on WM_SETREDRAW/TRUE.
:040000 040000 6581adc5a4c37b359b4bdd1f35e35ebb5dc70a9d 0bcde40d001433b39cdc73cf2a69e2a0677ea5d3 M dlls
This patch introduced a regression in ResHacker.exe: When opening a file a treeview shows up on the left hand side with the resources available in that file. With the above patch only very little of the treeview is shown at the top. The bad.png and good.png demonstrate the problem.
http://bugs.winehq.org/show_bug.cgi?id=19338
--- Comment #1 from Michael Stefaniuc mstefani@redhat.com 2009-07-15 15:37:50 --- Created an attachment (id=22394) --> (http://bugs.winehq.org/attachment.cgi?id=22394) ResHacker without the regression
http://bugs.winehq.org/show_bug.cgi?id=19338
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #22393|0 |1 is obsolete| |
--- Comment #2 from Michael Stefaniuc mstefani@redhat.com 2009-07-15 15:41:46 --- Created an attachment (id=22395) --> (http://bugs.winehq.org/attachment.cgi?id=22395) The correct bad ResHacker image
http://bugs.winehq.org/show_bug.cgi?id=19338
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download CC| |austinenglish@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=19338
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |1.1.25 Summary|Regression in ResHacker |ResHacker - only small part | |of treeview is visible
http://bugs.winehq.org/show_bug.cgi?id=19338
--- Comment #3 from Dmitry Timoshkov dmitry@codeweavers.com 2009-07-16 03:36:00 --- I sent the patch: http://www.winehq.org/pipermail/wine-patches/2009-July/076003.html
http://bugs.winehq.org/show_bug.cgi?id=19338
--- Comment #4 from Michael Stefaniuc mstefani@redhat.com 2009-07-16 03:47:53 --- I have tested the patch and it fixes the regression. Thanks!
http://bugs.winehq.org/show_bug.cgi?id=19338
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #5 from Dmitry Timoshkov dmitry@codeweavers.com 2009-07-17 07:36:59 --- The patch has been committed.
http://bugs.winehq.org/show_bug.cgi?id=19338
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org 2009-07-17 12:34:56 --- Closing bugs fixed in 1.1.26.
http://bugs.winehq.org/show_bug.cgi?id=19338
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |ee7ca802f4839fab9efd1759a76 | |2a9839d931a9b